-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hygiene: Do not treat Self
ctor as a local variable
#57560
Conversation
r? @alexreg |
Apparently bors hasn't rebooted yet... @bors delegate=alexreg |
✌️ @alexreg can now approve this pull request |
This is a small delta and looks totally fine to me, so I'm going to go ahead and r+ it. Travis would fail before Bors gets around to it anyway... @bors r+ |
📌 Commit 805099c has been approved by |
@petrochenkov: are these still necessary now? rust/src/librustc_resolve/lib.rs Lines 3410 to 3419 in 0e1402d
|
@varkor |
hygiene: Do not treat `Self` ctor as a local variable Fixes rust-lang#57523
Rollup of 16 pull requests Successful merges: - #57351 (Don't actually create a full MIR stack frame when not needed) - #57353 (Optimise floating point `is_finite` (2x) and `is_infinite` (1.6x).) - #57412 (Improve the wording) - #57436 (save-analysis: use a fallback when access levels couldn't be computed) - #57453 (lldb_batchmode.py: try `import _thread` for Python 3) - #57454 (Some cleanups for core::fmt) - #57461 (Change `String` to `&'static str` in `ParseResult::Failure`.) - #57473 (std: Render large exit codes as hex on Windows) - #57474 (save-analysis: Get path def from parent in case there's no def for the path itself.) - #57494 (Speed up item_bodies for large match statements involving regions) - #57496 (re-do docs for core::cmp) - #57508 (rustdoc: Allow inlining of reexported crates and crate items) - #57547 (Use `ptr::eq` where applicable) - #57557 (resolve: Mark extern crate items as used in more cases) - #57560 (hygiene: Do not treat `Self` ctor as a local variable) - #57564 (Update the const fn tracking issue to the new metabug) Failed merges: r? @ghost
Fixes #57523