submodules: update rls and clippy #57805

matthiaskrgr · 2019-01-21T15:40:46Z

Changes:

Remove state.analysis due to Rust PR #57476
Improve missing nightly readme info
Bump languageserver-types to v0.54.0 and renam crate name to lsp-types
Delete bors.toml
Fix tests
Fix https://github.com/rust-lang/rls/issues/1231
Implement asynchronous message reading
Use typed requests
Implement Tokio-based test LSP client
Update README.md to account for Travis url change
Simplify wait_for_all recv calls
Update dependencies
Revert NLL bug workaround
Remove old test_data entry in .gitignore
Reorganize some tests
Don't test RLS binary target directly
Move tooltip tests to integration tests
Simplify tooltip test harness
Only use FIXTURES_DIR to determine fixtures
Remove src/test/mod.rs
Centralise FIXTURES_DIR across unit and integration tests
Move lens test to tests/
Suppress unused warnings in tests/*
Beautify main.rs and lib.rs
WIP: Move tests
Move src/test/harness to tests/support/harness
Split RLS into bin/lib
Update Clippy
Change all mentions of `rls-preview` to `rls`
Make config mutex borrow scope explicit
Fallback to racer definition

Fixes rls build.

rust-highfive · 2019-01-21T15:40:57Z

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

rust-highfive · 2019-01-21T15:40:58Z

⚠️ Warning ⚠️

These commits modify submodules.

matthiaskrgr · 2019-01-21T15:41:01Z

cc @Xanewok

Xanewok · 2019-01-21T16:37:16Z

Thanks!

@bors r+ p=1

bors · 2019-01-21T16:37:17Z

📌 Commit 26cbe198e63a9201c83601693fe02c1ca2f67f9a has been approved by Xanewok

bors · 2019-01-21T16:40:42Z

⌛ Testing commit 26cbe198e63a9201c83601693fe02c1ca2f67f9a with merge 39506b3b0d74d7178d6bd2d11de5e1a0e230483f...

bors · 2019-01-21T18:14:03Z

💔 Test failed - status-appveyor

Xanewok · 2019-01-21T20:32:23Z

This submodule update pulls Tokio and some related bits - that's surely why we depend on more winapi features.

@matthiaskrgr From what I understand is the problem, could you please add the threadpoollegacyapiset winapi feature to the list and try again?

@bors delegate+

bors · 2019-01-21T20:32:24Z

✌️ @matthiaskrgr can now approve this pull request

matthiaskrgr · 2019-01-21T22:05:32Z

@Xanewok This needs to go into the rls repo, right?
I'll try to get a pr prepped within the next 24 hours, if nobody else does.

Xanewok · 2019-01-21T22:08:19Z

@matthiaskrgr whoops, I was sure I linked to the list:

rust/src/tools/rustc-workspace-hack/Cargo.toml

Lines 22 to 53 in 7164a9f

    
           [target.'cfg(windows)'.dependencies.winapi] 
        
           version = "0.3" 
        
           features = [ 
        
             "basetsd", 
        
             "consoleapi", 
        
             "errhandlingapi", 
        
             "jobapi", 
        
             "jobapi2", 
        
             "knownfolders", 
        
             "lmcons", 
        
             "memoryapi", 
        
             "minschannel", 
        
             "minwinbase", 
        
             "ntsecapi", 
        
             "ntstatus", 
        
             "objbase", 
        
             "profileapi", 
        
             "processenv", 
        
             "psapi", 
        
             "schannel", 
        
             "securitybaseapi", 
        
             "shellapi", 
        
             "shlobj", 
        
             "sspi", 
        
             "synchapi", 
        
             "sysinfoapi", 
        
             "timezoneapi", 
        
             "userenv", 
        
             "winbase", 
        
             "wincon", 
        
             "wincrypt", 
        
           ]

That's in-tree, so it doesn't need an extra PR against RLS.

matthiaskrgr · 2019-01-22T00:53:39Z

Like this?
https://github.com/rust-lang/rust/compare/26cbe198e63a9201c83601693fe02c1ca2f67f9a..4efb826d0b3e03a7ea36b21ea9f88ce1e0d0a304#diff-74ddac4e00c7d76369ef8a0f520b6d0f

rust-highfive · 2019-01-22T02:40:23Z

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

travis_time:end:2bfb75a8:start=1548124581903027526,finish=1548124582820233245,duration=917205719
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
Setting environment variables from .travis.yml
$ export IMAGE=x86_64-gnu-llvm-6.0
---
$ pip install --user awscli; export PATH=$PATH:$HOME/.local/bin:$HOME/Library/Python/2.7/bin/
/usr/local/lib/python2.7/dist-packages/pip/_vendor/requests/__init__.py:83: RequestsDependencyWarning: Old version of cryptography ([1, 2, 3]) may cause slowdown.
  warnings.warn(warning, RequestsDependencyWarning)
Collecting awscli
  Downloading https://files.pythonhosted.org/packages/04/be/6529423f80959e3c9ce05d1425e4237e3c3a01bb4b8a83061ae57ddfa5ab/awscli-1.16.93-py2.py3-none-any.whl (1.4MB)
    1% |▌                               | 20kB 2.2MB/s eta 0:00:01
    2% |▊                               | 30kB 3.2MB/s eta 0:00:01
    2% |█                               | 40kB 2.1MB/s eta 0:00:01
    3% |█▏                              | 51kB 2.6MB/s eta 0:00:01
---
[00:02:38]   Downloaded regex-syntax v0.5.6
[00:02:38]   Downloaded precomputed-hash v0.1.1
[00:02:38]   Downloaded home v0.3.4
[00:02:38]   Downloaded winapi v0.2.8
[00:02:39]   Downloaded tokio-signal v0.2.7
[00:02:39]   Downloaded open v1.2.2
[00:02:39]   Downloaded tokio-threadpool v0.1.10
[00:02:39]   Downloaded xattr v0.2.2
[00:02:39]   Downloaded utf8-ranges v1.0.2
[00:02:39]   Downloaded rls-analysis v0.16.10
[00:02:39]   Downloaded wait-timeout v0.1.5
[00:02:39]   Downloaded wait-timeout v0.1.5
[00:02:39]   Downloaded parking_lot v0.6.4
[00:02:39]   Downloaded rustc-rayon-core v0.1.1
[00:02:39]   Downloaded lock_api v0.1.5
[00:02:39]   Downloaded lsp-types v0.54.0
[00:02:39]   Downloaded socket2 v0.3.8
[00:02:39]   Downloaded percent-encoding v1.0.1
[00:02:39]   Downloaded tokio-codec v0.1.1
[00:02:39]   Downloaded tokio-executor v0.1.6
[00:02:39]   Downloaded bufstream v0.1.4
[00:02:39]   Downloaded foreign-types v0.3.2
[00:02:39]   Downloaded rustc_version v0.2.3
[00:02:39]   Downloaded maplit v1.0.1
[00:02:39]   Downloaded maplit v1.0.1
[00:02:39]   Downloaded json v0.11.13
[00:02:39]   Downloaded rusty-fork v0.2.1
[00:02:39]   Downloaded memmap v0.6.2
[00:02:39]   Downloaded tokio-tcp v0.1.3
[00:02:39]   Downloaded phf v0.7.24
[00:02:39]   Downloaded phf v0.7.24
[00:02:39]   Downloaded tokio-timer v0.2.8
[00:02:39]   Downloaded lazycell v1.2.1
[00:02:39]   Downloaded thread_local v0.3.6
[00:02:39]   Downloaded crypto-hash v0.3.3
[00:02:39]   Downloaded rustc-hash v1.0.1
---
[00:02:40]   Downloaded rustc-ap-serialize v306.0.0
[00:02:40]   Downloaded proptest v0.8.7
[00:02:40]   Downloaded bytesize v1.0.0
[00:02:40]   Downloaded libgit2-sys v0.7.11
[00:02:40]   Downloaded tokio-fs v0.1.5
[00:02:40]   Downloaded datafrog v2.0.1
[00:02:40]   Downloaded tendril v0.4.1
[00:02:40]   Downloaded termion v1.5.1
[00:02:40]   Downloaded termion v1.5.1
[00:02:40]   Downloaded iovec v0.1.2
[00:02:40]   Downloaded tokio-io v0.1.11
[00:02:40]   Downloaded atty v0.2.11
[00:02:40]   Downloaded aho-corasick v0.6.9
[00:02:40]   Downloaded rayon v1.0.3
[00:02:40]   Downloaded bitflags v0.9.1
---
[00:02:41]   Downloaded memchr v2.1.3
[00:02:41]   Downloaded humantime v1.2.0
[00:02:41]   Downloaded rand_hc v0.1.0
[00:02:41]   Downloaded fortanix-sgx-abi v0.3.2
[00:02:41]   Downloaded tokio-udp v0.1.3
[00:02:41]   Downloaded num-traits v0.2.6
[00:02:41]   Downloaded same-file v1.0.4
[00:02:41]   Downloaded same-file v1.0.4
[00:02:41]   Downloaded tokio-uds v0.2.5
[00:02:41]   Downloaded minifier v0.0.26
[00:02:41]   Downloaded difference v2.0.0
[00:02:41]   Downloaded colored v1.7.0
[00:02:41]   Downloaded globset v0.4.2
[00:02:41]   Downloaded globset v0.4.2
[00:02:41]   Downloaded crossbeam-deque v0.6.3
[00:02:41]   Downloaded backtrace-sys v0.1.27
[00:02:41]   Downloaded unicode-bidi v0.3.4
[00:02:41]   Downloaded rustc-ap-rustc_target v306.0.0
[00:02:42]   Downloaded derive_more v0.13.0
[00:02:42]   Downloaded fuchsia-zircon v0.3.3
[00:02:42]   Downloaded tokio v0.1.14
[00:02:42]   Downloaded vec_map v0.8.1
[00:02:42]   Downloaded mio v0.6.16
[00:02:42]   Downloaded rls-blacklist v0.1.3
[00:02:42]   Downloaded rustc-ap-rustc_cratesio_shim v306.0.0
---
[00:02:42]   Downloaded vcpkg v0.2.6
[00:02:42]   Downloaded rustc_tools_util v0.1.1
[00:02:43]   Downloaded hex v0.3.2
[00:02:43]   Downloaded compiletest_rs v0.3.18
[00:02:43]   Downloaded tokio-reactor v0.1.8
[00:02:43]   Downloaded tar v0.4.20
[00:02:43]   Downloaded bytecount v0.4.0
[00:02:43]   Downloaded crc v1.8.1
[00:02:43]   Downloaded openssl-sys v0.9.40
[00:02:43]   Downloaded openssl-sys v0.9.40
[00:02:43]   Downloaded derive-new v0.5.6
[00:02:43]   Downloaded strum_macros v0.11.0
[00:02:43]   Downloaded winapi-i686-pc-windows-gnu v0.4.0
[00:02:43]   Downloaded git2-curl v0.9.0
[00:02:43]   Downloaded tokio-current-thread v0.1.4
[00:02:43]   Downloaded lazy_static v1.2.0
[00:02:43]   Downloaded pulldown-cmark v0.1.2
[00:02:43]   Downloaded crossbeam-channel v0.3.6
[00:02:43]   Downloaded cargo_metadata v0.6.4
---
[00:02:44]   Downloaded heck v0.3.1
[00:02:44]   Downloaded glob v0.2.11
[00:02:44]   Downloaded rustc-ap-syntax v306.0.0
[00:02:44]   Downloaded rls-vfs v0.7.0
[00:02:44]   Downloaded tokio-process v0.2.3
[00:02:44]   Downloaded futures v0.1.25
[00:02:44]   Downloaded bitflags v1.0.4
[00:02:44]   Downloaded smallvec v0.6.8
[00:02:44]   Downloaded miow v0.2.1
---
[00:03:35] * rdrand 
[00:03:35] some tidy checks failed
[00:03:35] 
[00:03:35] 
[00:03:35] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/tidy" "/checkout/src" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "--no-vendor" "--quiet"
[00:03:35] 
[00:03:35] 
[00:03:35] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test src/tools/tidy
[00:03:35] Build completed unsuccessfully in 0:00:47
[00:03:35] Build completed unsuccessfully in 0:00:47
[00:03:35] make: *** [tidy] Error 1
[00:03:35] Makefile:69: recipe for target 'tidy' failed
The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:00380018
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
Tue Jan 22 02:40:09 UTC 2019
---
travis_time:end:00c4269c:start=1548124810385322120,finish=1548124810390177209,duration=4855089
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:12f29f5c
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:015c1c4d
travis_time:start:015c1c4d
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:1a7d1a09
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

rust-highfive · 2019-01-22T04:22:12Z

The job x86_64-gnu-tools of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

travis_time:end:16243480:start=1548124983030602468,finish=1548124984487910045,duration=1457307577
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
Setting environment variables from .travis.yml
$ export IMAGE=x86_64-gnu-tools
---
$ pip install --user awscli; export PATH=$PATH:$HOME/.local/bin:$HOME/Library/Python/2.7/bin/
/usr/local/lib/python2.7/dist-packages/pip/_vendor/requests/__init__.py:83: RequestsDependencyWarning: Old version of cryptography ([1, 2, 3]) may cause slowdown.
  warnings.warn(warning, RequestsDependencyWarning)
Collecting awscli
  Downloading https://files.pythonhosted.org/packages/04/be/6529423f80959e3c9ce05d1425e4237e3c3a01bb4b8a83061ae57ddfa5ab/awscli-1.16.93-py2.py3-none-any.whl (1.4MB)
    1% |▌                               | 20kB 2.2MB/s eta 0:00:01
    2% |▊                               | 30kB 3.1MB/s eta 0:00:01
    2% |█                               | 40kB 2.1MB/s eta 0:00:01
    3% |█▏                              | 51kB 2.6MB/s eta 0:00:01
---
[00:02:41]   Downloaded rand_core v0.3.0
[00:02:41]   Downloaded curl-sys v0.4.15
[00:02:41]   Downloaded compiler_builtins v0.1.4
[00:02:41]   Downloaded rls-rustc v0.5.0
[00:02:41]   Downloaded tokio-timer v0.2.8
[00:02:41]   Downloaded rustc-ap-rustc_cratesio_shim v306.0.0
[00:02:41]   Downloaded fuchsia-zircon-sys v0.3.3
[00:02:41]   Downloaded synstructure v0.10.1
[00:02:41]   Downloaded ucd-util v0.1.3
---
[00:02:42]   Downloaded fs2 v0.4.3
[00:02:42]   Downloaded derive_more v0.13.0
[00:02:42]   Downloaded void v1.0.2
[00:02:42]   Downloaded serde_ignored v0.0.4
[00:02:42]   Downloaded tokio-signal v0.2.7
[00:02:42]   Downloaded rustc-rayon v0.1.1
[00:02:42]   Downloaded bitflags v1.0.4
[00:02:42]   Downloaded strum v0.11.0
[00:02:42]   Downloaded thread_local v0.3.6
[00:02:42]   Downloaded thread_local v0.3.6
[00:02:42]   Downloaded phf_codegen v0.7.22
[00:02:42]   Downloaded miow v0.3.3
[00:02:42]   Downloaded environment v0.1.1
[00:02:42]   Downloaded winapi-util v0.1.1
[00:02:42]   Downloaded tokio-uds v0.2.5
[00:02:42]   Downloaded proc-macro2 v0.3.8
[00:02:42]   Downloaded xz2 v0.1.5
[00:02:42]   Downloaded lsp-types v0.54.0
[00:02:42]   Downloaded flate2 v1.0.6
---
[00:02:42]   Downloaded bit-set v0.5.0
[00:02:42]   Downloaded foreign-types-shared v0.1.1
[00:02:43]   Downloaded crc v1.8.1
[00:02:43]   Downloaded directories v1.0.2
[00:02:43]   Downloaded tokio-udp v0.1.3
[00:02:43]   Downloaded pulldown-cmark v0.1.2
[00:02:43]   Downloaded parking_lot_core v0.4.0
[00:02:43]   Downloaded regex-syntax v0.5.6
[00:02:43]   Downloaded openssl-probe v0.1.2
---
[00:02:43]   Downloaded unicode-normalization v0.1.7
[00:02:43]   Downloaded crypto-hash v0.3.1
[00:02:43]   Downloaded rand v0.4.3
[00:02:43]   Downloaded im-rc v12.2.0
[00:02:43]   Downloaded mio-uds v0.6.7
[00:02:43]   Downloaded tokio-tcp v0.1.3
[00:02:43]   Downloaded bytesize v1.0.0
[00:02:43]   Downloaded rustc-serialize v0.3.24
[00:02:43]   Downloaded fnv v1.0.6
[00:02:43]   Downloaded termion v1.5.1
---
[00:02:44]   Downloaded wait-timeout v0.1.5
[00:02:44]   Downloaded lazy_static v1.2.0
[00:02:44]   Downloaded bytes v0.4.11
[00:02:44]   Downloaded wincolor v1.0.1
[00:02:44]   Downloaded tokio-threadpool v0.1.10
[00:02:44]   Downloaded url v1.7.2
[00:02:44]   Downloaded xattr v0.2.2
[00:02:44]   Downloaded num-integer v0.1.39
[00:02:44]   Downloaded rand_hc v0.1.0
[00:02:44]   Downloaded rand_hc v0.1.0
[00:02:44]   Downloaded adler32 v1.0.3
[00:02:44]   Downloaded iovec v0.1.2
[00:02:44]   Downloaded memchr v2.1.1
[00:02:44]   Downloaded lock_api v0.1.3
[00:02:44]   Downloaded redox_termios v0.1.1
[00:02:44]   Downloaded error-chain v0.12.0
[00:02:44]   Downloaded error-chain v0.12.0
[00:02:44]   Downloaded opener v0.3.2
[00:02:44]   Downloaded fwdansi v1.0.1
[00:02:44]   Downloaded rustc_tools_util v0.1.1
[00:02:44]   Downloaded rustc-demangle v0.1.10
[00:02:44]   Downloaded nodrop v0.1.12
[00:02:44]   Downloaded tokio-executor v0.1.6
[00:02:44]   Downloaded rusty-fork v0.2.1
[00:02:44]   Downloaded clap v2.32.0
[00:02:44]   Downloaded log v0.4.6
[00:02:44]   Downloaded rand_pcg v0.1.1
---
[00:02:45]   Downloaded lsp-codec v0.1.0
[00:02:45]   Downloaded redox_syscall v0.1.43
[00:02:45]   Downloaded fuchsia-zircon v0.3.3
[00:02:45]   Downloaded dlmalloc v0.1.1
[00:02:45]   Downloaded tokio-current-thread v0.1.4
[00:02:45]   Downloaded lzma-sys v0.1.10
[00:02:45]   Downloaded pretty_assertions v0.5.1
[00:02:45]   Downloaded rustc-hash v1.0.1
[00:02:45]   Downloaded commoncrypto v0.2.0
---
[00:02:46]   Downloaded elasticlunr-rs v2.3.4
[00:02:46]   Downloaded html5ever v0.22.5
[00:02:46]   Downloaded libnghttp2-sys v0.1.1
[00:02:46]   Downloaded url_serde v0.2.0
[00:02:46]   Downloaded tokio-reactor v0.1.8
[00:02:46]   Downloaded rand_core v0.2.2
[00:02:46]   Downloaded remove_dir_all v0.5.1
[00:02:46]   Downloaded miniz_oxide v0.2.0
[00:02:46]   Downloaded tar v0.4.20
[00:02:46]   Downloaded tar v0.4.20
[00:02:46]   Downloaded rustc-ap-rustc_errors v306.0.0
[00:02:46]   Downloaded memoffset v0.2.1
[00:02:46]   Downloaded quote v0.5.2
[00:02:46]   Downloaded crossbeam-deque v0.6.3
[00:02:46]   Downloaded termcolor v1.0.4
[00:02:46]   Downloaded precomputed-hash v0.1.1
[00:02:46]   Downloaded tokio-codec v0.1.1
[00:02:46]   Downloaded rls-blacklist v0.1.3
[00:02:46]   Downloaded typenum v1.10.0
[00:02:46]   Downloaded core-foundation-sys v0.6.2
[00:02:46]   Downloaded socket2 v0.3.8
---
[00:02:47]   Downloaded winapi v0.3.6
[00:02:47]   Downloaded winapi v0.2.8
[00:02:47]   Downloaded winapi-i686-pc-windows-gnu v0.4.0
[00:02:47]   Downloaded quote v0.3.15
[00:02:47]   Downloaded tokio-io v0.1.11
[00:02:47]   Downloaded tokio v0.1.14
[00:02:47]   Downloaded rustc-ap-graphviz v306.0.0
[00:02:47]   Downloaded libssh2-sys v0.2.11
[00:02:47]   Downloaded libssh2-sys v0.2.11
[00:02:47]   Downloaded tokio-fs v0.1.5
[00:02:47]   Downloaded num-derive v0.2.3
[00:02:47]   Downloaded build_const v0.2.1
[00:02:47]   Downloaded env_logger v0.6.0
[00:02:47]   Downloaded parking_lot v0.6.4
---
[00:02:48]   Downloaded rustc-ap-serialize v306.0.0
[00:02:48]   Downloaded git2-curl v0.9.0
[00:02:48]   Downloaded semver-parser v0.7.0
[00:02:48]   Downloaded unicode-width v0.1.5
[00:02:48]   Downloaded tokio-process v0.2.3
[00:02:48]   Downloaded regex-syntax v0.6.4
[00:02:48]   Downloaded string_cache_shared v0.3.0
[00:02:48]   Downloaded futures v0.1.21
[00:02:48]   Downloaded semver v0.9.0
---
[01:30:27] Verifying status of rust-by-example...
[01:30:27] Verifying status of rls...
[01:30:27] This PR updated 'src/tools/rls', verifying if status is 'test-pass'...
[01:30:27] 
[01:30:27] ⚠️ We detected that this PR updated 'rls', but its tests failed.
[01:30:27] 
[01:30:27] If you do intend to update 'rls', please check the error messages above and
[01:30:27] commit another update.
[01:30:27] 
[01:30:27] If you do NOT intend to update 'rls', please ensure you did not accidentally
[01:30:27] change the submodule at 'src/tools/rls'. You may ask your reviewer for the
[01:30:27] proper steps.
The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 3.
travis_time:start:01c8c615
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
Tue Jan 22 04:13:42 UTC 2019
---
travis_time:end:32bf4b10:start=1548130423964079983,finish=1548130423969308512,duration=5228529
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:1da27792
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:05c5d434
travis_time:start:05c5d434
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:17c70fc0
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

matthiaskrgr · 2019-01-22T11:05:43Z

clippy broke again...

Xanewok · 2019-01-22T11:18:34Z

Like this?

Yeah, although watch out since there are also unrelated changes including recently merged Iterator::is_sorted 😅

Changes: ```` Remove state.analysis due to Rust PR rust-lang#57476 Improve missing nightly readme info Bump languageserver-types to v0.54.0 and renam crate name to lsp-types Delete bors.toml Fix tests Fix rust-lang/rls#1231 Implement asynchronous message reading Use typed requests Implement Tokio-based test LSP client Update README.md to account for Travis url change Simplify wait_for_all recv calls Update dependencies Revert NLL bug workaround Remove old test_data entry in .gitignore Reorganize some tests Don't test RLS binary target directly Move tooltip tests to integration tests Simplify tooltip test harness Only use FIXTURES_DIR to determine fixtures Remove src/test/mod.rs Centralise FIXTURES_DIR across unit and integration tests Move lens test to tests/ Suppress unused warnings in tests/* Beautify main.rs and lib.rs WIP: Move tests Move src/test/harness to tests/support/harness Split RLS into bin/lib Update Clippy Change all mentions of `rls-preview` to `rls` Make config mutex borrow scope explicit Fallback to racer definition ```` Fixes rls build.

Changes: ```` Rustfmt all the things Don't make decisions on values that don't represent the decision Rustup Actually check for constants. formatting fix Update clippy_lints/src/needless_bool.rs formatting fix needless bool lint suggestion is wrapped in brackets if it is an "else" clause of an "if-else" statement Remove negative integer literal checks. Fix `implicit_return` false positives. ````

matthiaskrgr · 2019-01-22T17:05:59Z

pulled in a clippy update as well....
@bors r=Xanewok

bors · 2019-01-22T17:05:59Z

📌 Commit 7f8e4aa has been approved by Xanewok

bors · 2019-01-22T20:04:21Z

⌛ Testing commit 7f8e4aa with merge 4c2be9c...

submodules: update rls and clippy Changes: ```` Remove state.analysis due to Rust PR #57476 Improve missing nightly readme info Bump languageserver-types to v0.54.0 and renam crate name to lsp-types Delete bors.toml Fix tests Fix rust-lang/rls#1231 Implement asynchronous message reading Use typed requests Implement Tokio-based test LSP client Update README.md to account for Travis url change Simplify wait_for_all recv calls Update dependencies Revert NLL bug workaround Remove old test_data entry in .gitignore Reorganize some tests Don't test RLS binary target directly Move tooltip tests to integration tests Simplify tooltip test harness Only use FIXTURES_DIR to determine fixtures Remove src/test/mod.rs Centralise FIXTURES_DIR across unit and integration tests Move lens test to tests/ Suppress unused warnings in tests/* Beautify main.rs and lib.rs WIP: Move tests Move src/test/harness to tests/support/harness Split RLS into bin/lib Update Clippy Change all mentions of `rls-preview` to `rls` Make config mutex borrow scope explicit Fallback to racer definition ```` Fixes rls build.

bors · 2019-01-22T23:02:32Z

☀️ Test successful - checks-travis, status-appveyor
Approved by: Xanewok
Pushing 4c2be9c to master...

rust-highfive · 2019-01-22T23:04:15Z

📣 Toolstate changed by #57805!

Tested on commit 4c2be9c.
Direct link to PR: #57805

🎉 clippy-driver on windows: build-fail → test-pass (cc @Manishearth @llogiq @mcarton @oli-obk, @rust-lang/infra).
🎉 clippy-driver on linux: build-fail → test-pass (cc @Manishearth @llogiq @mcarton @oli-obk, @rust-lang/infra).
🎉 rls on windows: build-fail → test-pass (cc @nrc @Xanewok, @rust-lang/infra).
🎉 rls on linux: build-fail → test-pass (cc @nrc @Xanewok, @rust-lang/infra).

@Manishearth

Tested on commit rust-lang/rust@4c2be9c. Direct link to PR: <rust-lang/rust#57805> 🎉 clippy-driver on windows: build-fail → test-pass (cc @Manishearth @llogiq @mcarton @oli-obk, @rust-lang/infra). 🎉 clippy-driver on linux: build-fail → test-pass (cc @Manishearth @llogiq @mcarton @oli-obk, @rust-lang/infra). 🎉 rls on windows: build-fail → test-pass (cc @nrc @Xanewok, @rust-lang/infra). 🎉 rls on linux: build-fail → test-pass (cc @nrc @Xanewok, @rust-lang/infra).

rust-highfive assigned nikomatsakis Jan 21, 2019

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 21, 2019

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 21, 2019

mati865 mentioned this pull request Jan 21, 2019

rustup: rls cannot be downloaded for nightly #57771

Closed

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 21, 2019

matthiaskrgr force-pushed the rls branch from 26cbe19 to 4efb826 Compare January 22, 2019 00:52

matthiaskrgr force-pushed the rls branch from 4efb826 to 32f4337 Compare January 22, 2019 02:34

matthiaskrgr force-pushed the rls branch from 32f4337 to 434f848 Compare January 22, 2019 02:41

matthiaskrgr added 2 commits January 22, 2019 18:03

matthiaskrgr force-pushed the rls branch from 434f848 to 7f8e4aa Compare January 22, 2019 17:04

matthiaskrgr changed the title ~~submodules: update rls from ae0d89a to c9d25b6~~ submodules: update rls and clippy Jan 22, 2019

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 22, 2019

bors merged commit 7f8e4aa into rust-lang:master Jan 22, 2019

This was referenced Jan 22, 2019

Initial addition of the Embedded Rust Book #56291

Merged

Change untagged_unions to not allow union fields with drop #56440

Closed

Support multiple versions of MdBook for docs #57495

Merged

matthiaskrgr deleted the rls branch February 29, 2020 14:13

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

submodules: update rls and clippy #57805

submodules: update rls and clippy #57805

matthiaskrgr commented Jan 21, 2019

rust-highfive commented Jan 21, 2019

rust-highfive commented Jan 21, 2019

matthiaskrgr commented Jan 21, 2019

Xanewok commented Jan 21, 2019

bors commented Jan 21, 2019

bors commented Jan 21, 2019

bors commented Jan 21, 2019

Xanewok commented Jan 21, 2019

bors commented Jan 21, 2019

matthiaskrgr commented Jan 21, 2019 •

edited

Loading

Xanewok commented Jan 21, 2019

matthiaskrgr commented Jan 22, 2019 •

edited

Loading

rust-highfive commented Jan 22, 2019

rust-highfive commented Jan 22, 2019

matthiaskrgr commented Jan 22, 2019

Xanewok commented Jan 22, 2019

matthiaskrgr commented Jan 22, 2019

bors commented Jan 22, 2019

bors commented Jan 22, 2019

bors commented Jan 22, 2019

rust-highfive commented Jan 22, 2019

submodules: update rls and clippy #57805

submodules: update rls and clippy #57805

Conversation

matthiaskrgr commented Jan 21, 2019

rust-highfive commented Jan 21, 2019

rust-highfive commented Jan 21, 2019

matthiaskrgr commented Jan 21, 2019

Xanewok commented Jan 21, 2019

bors commented Jan 21, 2019

bors commented Jan 21, 2019

bors commented Jan 21, 2019

Xanewok commented Jan 21, 2019

bors commented Jan 21, 2019

matthiaskrgr commented Jan 21, 2019 • edited Loading

Xanewok commented Jan 21, 2019

matthiaskrgr commented Jan 22, 2019 • edited Loading

rust-highfive commented Jan 22, 2019

rust-highfive commented Jan 22, 2019

matthiaskrgr commented Jan 22, 2019

Xanewok commented Jan 22, 2019

matthiaskrgr commented Jan 22, 2019

bors commented Jan 22, 2019

bors commented Jan 22, 2019

bors commented Jan 22, 2019

rust-highfive commented Jan 22, 2019

matthiaskrgr commented Jan 21, 2019 •

edited

Loading

matthiaskrgr commented Jan 22, 2019 •

edited

Loading