Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bootstrap: Don't rely on any default settings regarding incr. comp. in Cargo #57891

Merged
merged 1 commit into from
Jan 25, 2019

Conversation

michaelwoerister
Copy link
Member

rust-lang/cargo#6564 (temporarily) makes incremental compilation the default for release builds. We don't want this default to apply to building the compiler itself, that is, bootstrap's incremental flag should always be respected. Otherwise we'll get incrementally build releases, which we really don't want :).

r? @Mark-Simulacrum

Anybody else from @rust-lang/release should feel free to r+ this too if they get around to it earlier.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 25, 2019
@michaelwoerister
Copy link
Member Author

@bors p=99 since nightlies would messed up otherwise.

@pietroalbini
Copy link
Member

@bors r+ p=99

@bors
Copy link
Contributor

bors commented Jan 25, 2019

📌 Commit f4fe808 has been approved by pietroalbini

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 25, 2019
@bors
Copy link
Contributor

bors commented Jan 25, 2019

⌛ Testing commit f4fe808 with merge 7187db6...

bors added a commit that referenced this pull request Jan 25, 2019
…pietroalbini

bootstrap: Don't rely on any default settings regarding incr. comp. in Cargo

rust-lang/cargo#6564 (temporarily) makes incremental compilation the default for release builds. We don't want this default to apply to building the compiler itself, that is, `bootstrap`'s `incremental` flag should always be respected. Otherwise we'll get incrementally build releases, which we really don't want `:)`.

r? @Mark-Simulacrum

Anybody else from @rust-lang/release should feel free to r+ this too if they get around to it earlier.
@bors
Copy link
Contributor

bors commented Jan 25, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: pietroalbini
Pushing 7187db6 to master...

@bors bors merged commit f4fe808 into rust-lang:master Jan 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants