Extend E0106, E0261 #57950
Merged
Extend E0106, E0261 #57950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added an example that points out hardly obvious mistake one could make when writing impl for a new type.
Replaced impl block dock with suggested one and made sure that blocks compile.
rust-highfive
added
the
S-waiting-on-review
Closed
|
r? @estebank |
|
r=me after travis is happy |
|
@bors r=estebank rollup |
|
📌 Commit a2b75ed has been approved by |
bors
added
S-waiting-on-bors
Centril
added a commit
to Centril/rust
that referenced
this pull request
Jan 28, 2019
…r=estebank Extend E0106, E0261 This is a reopening of rust-lang#57310 with review comments addressed because the original author has since deleted their fork. From the author (@purple-ice): > Added an example that points out hardly obvious mistake one could make when writing impl for a new type. r? @rust-lang/docs
bors
added a commit
that referenced
this pull request
Jan 29, 2019
Rollup of 7 pull requests Successful merges: - #57045 (Kill remaining uses of mem::uninitialized in libcore, liballoc) - #57674 (Avoid erase_regions_ty queries if there are no regions to erase) - #57833 (Print a slightly clearer message when failing to launch a thread) - #57859 (Fix invalid background color) - #57904 (add typo suggestion to unknown attribute error) - #57915 (Pretty print `$crate` as `crate` or `crate_name` in more cases) - #57950 (Extend E0106, E0261) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a reopening of #57310 with review comments addressed because the original author has since deleted their fork.
From the author (@purple-ice):
r? @rust-lang/docs