Allow #[repr(align(x))] on enums (#57996) #57998
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @steveklabnik (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
rust-highfive
added
the
S-waiting-on-review
|
r? @nagisa cc @eddyb @alexcrichton |
Centril
added
I-nominated
T-lang
|
We discussed this PR briefly in the Lang Team meeting today. Folks generally feel comfortable with this addition (especially since it's unstable). The one question was: is this equivalent to wrapping in a struct with an alignment? Modulo clarifying that part of the spec, we are 👍 |
|
Awesome.
Yes, that is the intent. I added this to the docs. |
Centril
removed
the
T-lang
|
This needs a codegen test IMO. Otherwise looks good. |
|
Makes sense. Added a very basic codegen test (a6fd6ec). |
|
@bors r+ |
|
📌 Commit a6fd6ec has been approved by |
bors
added
S-waiting-on-bors
|
⌛ Testing commit a6fd6ec with merge ff672da096df7ab05d7e7374eeadb299e6a6347e... |
|
💔 Test failed - status-appveyor |
bors
added
S-waiting-on-review
bors
removed
the
S-waiting-on-review
bors
added
the
S-waiting-on-bors
Allow #[repr(align(x))] on enums (#57996) Tracking issue: #57996 Implements an extension of [RFC 1358](https://github.com/rust-lang/rfcs/blob/master/text/1358-repr-align.md) behind a feature flag (`repr_align_enum`). Originally introduced here for structs: #39999. It seems like only HIR-level changes are required, since enums are already aware of their alignment (due to alignment of their limbs). cc @bitshifter
|
💔 Test failed - status-appveyor |
bors
added
S-waiting-on-review
bors
added
S-waiting-on-bors
Allow #[repr(align(x))] on enums (#57996) Tracking issue: #57996 Implements an extension of [RFC 1358](https://github.com/rust-lang/rfcs/blob/master/text/1358-repr-align.md) behind a feature flag (`repr_align_enum`). Originally introduced here for structs: #39999. It seems like only HIR-level changes are required, since enums are already aware of their alignment (due to alignment of their limbs). cc @bitshifter
|
☀️ Test successful - checks-travis, status-appveyor |
Tracking issue: #57996
Implements an extension of RFC 1358 behind a feature flag (
repr_align_enum). Originally introduced here for structs: #39999.It seems like only HIR-level changes are required, since enums are already aware of their alignment (due to alignment of their limbs).
cc @bitshifter