Skip to content

Add debug-info to access variables from generator state #58077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 2, 2019

Conversation

Nemo157
Copy link
Member

@Nemo157 Nemo157 commented Feb 2, 2019

No description provided.

@rust-highfive
Copy link
Contributor

r? @petrochenkov

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 2, 2019
@Nemo157
Copy link
Member Author

Nemo157 commented Feb 2, 2019

I previously ran the tests when I first implemented this, but since then I've got a new laptop and haven't been able to get debuginfo tests running properly; hopefully Travis is happy (although, I just figured out a way to manually test it).

This will make all the variables in the generator available even when they haven't been initialized yet (or after they've been de-initialized), I'm not sure if there's an easy way to make it so the correct variables are specified in each state.

@Nemo157 Nemo157 force-pushed the generator-state-debug-info branch 3 times, most recently from 2e91276 to f5d8005 Compare February 2, 2019 13:12
@Zoxc Zoxc assigned Zoxc and unassigned petrochenkov Feb 3, 2019
@oli-obk oli-obk added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 18, 2019
@Centril
Copy link
Contributor

Centril commented Feb 23, 2019

Ping from triage @Nemo157 :)

@Nemo157 Nemo157 force-pushed the generator-state-debug-info branch from f5d8005 to b78a7e4 Compare February 23, 2019 10:57
@rust-highfive
Copy link
Contributor

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
travis_time:end:01095d63:start=1550919481497837316,finish=1550919578432629687,duration=96934792371
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
Setting environment variables from .travis.yml
$ export IMAGE=x86_64-gnu-llvm-6.0
---

[00:03:18] travis_fold:start:tidy
travis_time:start:tidy
tidy check
[00:03:19] tidy error: /checkout/src/librustc_codegen_ssa/mir/mod.rs:629: line longer than 100 chars
[00:03:20] some tidy checks failed
[00:03:20] 
[00:03:20] 
[00:03:20] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/tidy" "/checkout/src" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "--no-vendor" "--quiet"
[00:03:20] 
[00:03:20] 
[00:03:20] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test src/tools/tidy
[00:03:20] Build completed unsuccessfully in 0:00:47
[00:03:20] Build completed unsuccessfully in 0:00:47
[00:03:20] make: *** [tidy] Error 1
[00:03:20] Makefile:68: recipe for target 'tidy' failed
The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:2b505f33
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
Sat Feb 23 11:03:09 UTC 2019
---
travis_time:end:256d7549:start=1550919790032538963,finish=1550919790037634066,duration=5095103
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:02a0a1d8
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:10ecfcb7
travis_time:start:10ecfcb7
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:02033d00
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@Nemo157 Nemo157 force-pushed the generator-state-debug-info branch from b78a7e4 to 61097bc Compare February 23, 2019 11:13
@Zoxc
Copy link
Contributor

Zoxc commented Feb 27, 2019

@bors r+

@bors
Copy link
Collaborator

bors commented Feb 27, 2019

📌 Commit 61097bc has been approved by Zoxc

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 27, 2019
bors added a commit that referenced this pull request Mar 2, 2019
Add debug-info to access variables from generator state
@bors
Copy link
Collaborator

bors commented Mar 2, 2019

⌛ Testing commit 61097bc with merge 9cfed5d...

@bors
Copy link
Collaborator

bors commented Mar 2, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: Zoxc
Pushing 9cfed5d to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Mar 2, 2019
@bors bors merged commit 61097bc into rust-lang:master Mar 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants