Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make intern_lazy_const actually intern its argument. #58207

Merged
merged 1 commit into from
Feb 9, 2019

Commits on Feb 6, 2019

  1. Make intern_lazy_const actually intern its argument.

    Currently it just unconditionally allocates it in the arena.
    
    For a "Clean Check" build of the the `packed-simd` benchmark, this
    change reduces both the `max-rss` and `faults` counts by 59%; it
    slightly (~3%) increases the instruction counts but the `wall-time` is
    unchanged.
    
    For the same builds of a few other benchmarks, `max-rss` and `faults`
    drop by 1--5%, but instruction counts and `wall-time` changes are in the
    noise.
    
    Fixes rust-lang#57432, fixes rust-lang#57829.
    nnethercote committed Feb 6, 2019
    Configuration menu
    Copy the full SHA
    f2871a9 View commit details
    Browse the repository at this point in the history