Added function to cast &[u8] to &str #5823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Instead of having |
|
@erickt : That was the plan, but sadly the semantic of |
|
Don't r+ yet, need to push a fix first. EDIT: Ready now |
Added str::subslice_offset() Renamed slice_bytes_uniqe to slice_bytes_owned
|
The debug-info tests failed, apparently. Strange, doesn't have anything to do with my code? |
|
@Kimundi it's the recent LLVM upgrade. |
bors
added a commit
that referenced
this pull request
Apr 11, 2013
Added str::from_bytes_with_null Added str::subslice_offset Misc cleanup Closes #5422
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Sep 10, 2020
improve the suggestion of the lint `unit-arg` Fixes rust-lang#5823 Fixes rust-lang#6015 Changes ``` help: move the expression in front of the call... | 3 | g(); | help: ...and use a unit literal instead | 3 | o.map_or((), |i| f(i)) | ``` into ``` help: move the expression in front of the call and replace it with the unit literal `()` | 3 | g(); | o.map_or((), |i| f(i)) | ``` changelog: improve the suggestion of the lint `unit-arg`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added str::from_bytes_with_null
Added str::subslice_offset
Misc cleanup
Closes #5422