Introduce rustc_interface and move some methods there #58250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
Zoxc
force-pushed
the
rustc-interface-1
branch
from
a2f59bf
to
72ba6f8
Compare
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
Zoxc
force-pushed
the
rustc-interface-1
branch
2 times, most recently
from
9d8d8d1
to
772325d
Compare
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
Zoxc
force-pushed
the
rustc-interface-1
branch
from
772325d
to
a7f0143
Compare
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
Zoxc
force-pushed
the
rustc-interface-1
branch
from
a7f0143
to
fc02bd0
Compare
phansch
reviewed
Feb 7, 2019
| } | ||
|
|
||
| pub fn collect_crate_types(session: &Session, attrs: &[ast::Attribute]) -> Vec<config::CrateType> { | ||
| // Unconditionally collect crate types from attributes to make them used |
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
Zoxc
force-pushed
the
rustc-interface-1
branch
from
fc02bd0
to
0fafff9
Compare
oli-obk
reviewed
Feb 7, 2019
| @@ -1282,8 +1282,6 @@ impl<'a, 'gcx, 'tcx> TyCtxt<'a, 'gcx, 'tcx> { | |||
|
|
|||
| let gcx = arenas.global_ctxt.as_ref().unwrap(); | |||
|
|
|||
| sync::assert_send_val(&gcx); | |||
There was a problem hiding this comment.
And/or why was this there at all?
There was a problem hiding this comment.
It was there after we modified GlobalCtxt to be Sync, but didn't yet actually share it across threads.
src/librustc_driver/lib.rs
Outdated
| @@ -148,6 +118,13 @@ const ICE_REPORT_COMPILER_FLAGS_EXCLUDE: &[&str] = &["metadata", "extra-filename | |||
|
|
|||
| const ICE_REPORT_COMPILER_FLAGS_STRIP_VALUE: &[&str] = &["incremental"]; | |||
|
|
|||
| pub fn source_name(input: &Input) -> FileName { | |||
There was a problem hiding this comment.
This should be a method on Input
There was a problem hiding this comment.
A doc comment would be neat, too
src/librustc_interface/passes.rs
Outdated
| use std::mem; | ||
| use std::ops::Generator; | ||
|
|
||
| // Returns all the paths that correspond to generated files. |
There was a problem hiding this comment.
Suggested change
| // Returns all the paths that correspond to generated files. | |
| /// Returns all the paths that correspond to generated files. |
|
☔ The latest upstream changes (presumably #58254) made this pull request unmergeable. Please resolve the merge conflicts. |
bjorn3
requested changes
Feb 7, 2019
| time(sess, "intrinsic checking", || { | ||
| middle::intrinsicck::check_crate(tcx) | ||
| }); | ||
| tcx.analysis(LOCAL_CRATE).ok(); | ||
|
|
There was a problem hiding this comment.
This should return the error, shouldnt't it.
There was a problem hiding this comment.
We pass the compile status to the closure and expect it to handle it. I'll change phase_3_run_analysis_passes to return just R.
Zoxc
force-pushed
the
rustc-interface-1
branch
from
0fafff9
to
024f7d5
Compare
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
Zoxc
force-pushed
the
rustc-interface-1
branch
from
d7d0cec
to
9e4ec00
Compare
|
@bors r=oli-obk |
|
📌 Commit 9e4ec00dba073f668fe777eb6678dd612d3c2770 has been approved by |
bors
added
S-waiting-on-bors
|
☔ The latest upstream changes (presumably #58389) made this pull request unmergeable. Please resolve the merge conflicts. |
bors
added
S-waiting-on-author
Zoxc
force-pushed
the
rustc-interface-1
branch
from
9e4ec00
to
356da36
Compare
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
Zoxc
force-pushed
the
rustc-interface-1
branch
from
356da36
to
0e4fa4f
Compare
|
☔ The latest upstream changes (presumably #58341) made this pull request unmergeable. Please resolve the merge conflicts. |
|
📌 Commit 6d573d8f971f48d21843cd4407662f14323f74d3 has been approved by |
bors
added
S-waiting-on-bors
|
🔒 Merge conflict This pull request and the master branch diverged in a way that cannot be automatically merged. Please rebase on top of the latest master branch, and let the reviewer approve again. How do I rebase?Assuming
You may also read Git Rebasing to Resolve Conflicts by Drew Blessing for a short tutorial. Please avoid the "Resolve conflicts" button on GitHub. It uses Sometimes step 4 will complete without asking for resolution. This is usually due to difference between how Error message |
bors
added
S-waiting-on-author
|
☔ The latest upstream changes (presumably #57760) made this pull request unmergeable. Please resolve the merge conflicts. |
Zoxc
force-pushed
the
rustc-interface-1
branch
from
6d573d8
to
23a51f9
Compare
|
@bors r=oli-obk |
|
📌 Commit 23a51f9 has been approved by |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-travis, status-appveyor |
This was referenced Mar 1, 2019
Closed
Centril
added a commit
to Centril/rust
that referenced
this pull request
Mar 9, 2019
…ister Refactor passes and pass execution to be more parallel For `syntex_syntax` (with 16 threads and 8 cores): - Cuts `misc checking 1` from `0.096s` to `0.08325s`. - Cuts `misc checking 2` from `0.3575s` to `0.2545s`. - Cuts `misc checking 3` from `0.34625s` to `0.21375s`. - Cuts `wf checking` from `0.3085s` to `0.05025s`. Reduces overall execution time for `syntex_syntax` (with 8 threads and cores) from `4.92s` to `4.34s`. Subsumes rust-lang#58494 Blocked on rust-lang#58250 r? @michaelwoerister
Centril
added a commit
to Centril/rust
that referenced
this pull request
Mar 9, 2019
…ister Refactor passes and pass execution to be more parallel For `syntex_syntax` (with 16 threads and 8 cores): - Cuts `misc checking 1` from `0.096s` to `0.08325s`. - Cuts `misc checking 2` from `0.3575s` to `0.2545s`. - Cuts `misc checking 3` from `0.34625s` to `0.21375s`. - Cuts `wf checking` from `0.3085s` to `0.05025s`. Reduces overall execution time for `syntex_syntax` (with 8 threads and cores) from `4.92s` to `4.34s`. Subsumes rust-lang#58494 Blocked on rust-lang#58250 r? @michaelwoerister
Centril
added a commit
to Centril/rust
that referenced
this pull request
Mar 9, 2019
…ister Refactor passes and pass execution to be more parallel For `syntex_syntax` (with 16 threads and 8 cores): - Cuts `misc checking 1` from `0.096s` to `0.08325s`. - Cuts `misc checking 2` from `0.3575s` to `0.2545s`. - Cuts `misc checking 3` from `0.34625s` to `0.21375s`. - Cuts `wf checking` from `0.3085s` to `0.05025s`. Reduces overall execution time for `syntex_syntax` (with 8 threads and cores) from `4.92s` to `4.34s`. Subsumes rust-lang#58494 Blocked on rust-lang#58250 r? @michaelwoerister
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split out from #56732
r? @oli-obk