rustc_codegen_llvm: use opaque LLVM structs for extern type.
#58271
+11
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
@bors try |
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
bors
added a commit
that referenced
this pull request
Feb 7, 2019
rustc_codegen_llvm: use opaque LLVM structs for `extern type`. Mostly an experiment, @RalfJung suggested it could be used to inform LLVM that for e.g.: ```rust extern { type Foo; static BAR: Foo; } ``` `BAR` does not have a known size, and therefore nothing can be assumed about the validity of accesses at arbitrary offsets.
|
💔 Test failed - checks-travis |
bors
added
S-waiting-on-author
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
|
@Mark-Simulacrum Ohh, the coredump backtraces are nice! |
|
You could manually enable an ALT builder for llvm asserts, neither one that's run so far has them enabled. |
|
The LLVM assertion failure is:
|
7 tasks
|
ping from triage @eddyb closing this issue due to inactivity. Thanks. |
Dylan-DPC-zz
added
S-inactive
|
I opened an issue so we don't forget about this: #59095 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly an experiment, @RalfJung suggested it could be used to inform LLVM that for e.g.:
BARdoes not have a known size, and therefore nothing can be assumed about the validity of accesses at arbitrary offsets.