Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

always back ty::Const by an Allocation #58486

Closed
wants to merge 23 commits into from
Closed

always back ty::Const by an Allocation #58486

wants to merge 23 commits into from

Commits on Feb 14, 2019

  1. Setup ty::Const to allow ConstValue::Scalar to be backed by an al… 

    …location
    @oli-obk
    oli-obk committed Feb 14, 2019
    Configuration menu
    Copy the full SHA
    7c966de View commit details
    Browse the repository at this point in the history

  2. Fiddle the corresponding allocation through all RawConst uses

    @oli-obk
    oli-obk committed Feb 14, 2019
    Configuration menu
    Copy the full SHA
    a5a5ef1 View commit details
    Browse the repository at this point in the history

  3. Make const eval not use the hacky op_to_const function

    @oli-obk
    oli-obk committed Feb 14, 2019
    Configuration menu
    Copy the full SHA
    f5fb34c View commit details
    Browse the repository at this point in the history

Commits on Feb 15, 2019

  1. Fix equality check for constants

    @oli-obk
    oli-obk committed Feb 15, 2019
    Configuration menu
    Copy the full SHA
    db168bc View commit details
    Browse the repository at this point in the history

  2. Promoteds always have a backing allocation

    @oli-obk
    oli-obk committed Feb 15, 2019
    Configuration menu
    Copy the full SHA
    9a63fc8 View commit details
    Browse the repository at this point in the history

  3. Fixup: statics are always backed by an allocation

    @oli-obk
    oli-obk committed Feb 15, 2019
    Configuration menu
    Copy the full SHA
    78c36b9 View commit details
    Browse the repository at this point in the history

  4. Update comment and make it truer by actually doing what it says

    @oli-obk
    oli-obk committed Feb 15, 2019
    Configuration menu
    Copy the full SHA
    785302d View commit details
    Browse the repository at this point in the history

  5. Explain the val caching in ty::Const

    @oli-obk
    oli-obk committed Feb 15, 2019
    Configuration menu
    Copy the full SHA
    8b0dd6d View commit details
    Browse the repository at this point in the history

  6. Remove a now-dead function argument

    @oli-obk
    oli-obk committed Feb 15, 2019
    Configuration menu
    Copy the full SHA
    6906379 View commit details
    Browse the repository at this point in the history

  7. Mark a function private that is unused anywhere else

    @oli-obk
    oli-obk committed Feb 15, 2019
    Configuration menu
    Copy the full SHA
    1b93eda View commit details
    Browse the repository at this point in the history

  8. Fold an if on a match returning a bool directly into the match

    @oli-obk
    oli-obk committed Feb 15, 2019
    Configuration menu
    Copy the full SHA
    b3731ee View commit details
    Browse the repository at this point in the history

  9. Synchronize StableHash with the updated PartialEq impl

    @oli-obk
    oli-obk committed Feb 15, 2019
    Configuration menu
    Copy the full SHA
    b0857a7 View commit details
    Browse the repository at this point in the history

  10. Don't create an intermediate place when reading discriminants

    @oli-obk
    oli-obk committed Feb 15, 2019
    Configuration menu
    Copy the full SHA
    1495b6b View commit details
    Browse the repository at this point in the history

  11. Note to self

    @oli-obk
    oli-obk committed Feb 15, 2019
    Configuration menu
    Copy the full SHA
    92e4471 View commit details
    Browse the repository at this point in the history

  12. Insert satisfying op_to_const bbqing sound here.

    @oli-obk
    oli-obk committed Feb 15, 2019
    1 Configuration menu
    Copy the full SHA
    0075868 View commit details
    Browse the repository at this point in the history

  13. Make validity checking use MPlaceTy instead of OpTy

    @oli-obk
    oli-obk committed Feb 15, 2019
    Configuration menu
    Copy the full SHA
    a13cfdb View commit details
    Browse the repository at this point in the history

  14. Eliminate another use of lazy_const_to_op

    @oli-obk
    oli-obk committed Feb 15, 2019
    Configuration menu
    Copy the full SHA
    981a79e View commit details
    Browse the repository at this point in the history

  15. Simplify raw_const_to_mplace

    @oli-obk
    oli-obk committed Feb 15, 2019
    Configuration menu
    Copy the full SHA
    c07162c View commit details
    Browse the repository at this point in the history

  16. Update a comment

    @oli-obk
    oli-obk committed Feb 15, 2019
    Configuration menu
    Copy the full SHA
    defa8d5 View commit details
    Browse the repository at this point in the history

  17. Another bad function bites the dust

    @oli-obk
    oli-obk committed Feb 15, 2019
    Configuration menu
    Copy the full SHA
    b653dc2 View commit details
    Browse the repository at this point in the history

  18. Update an outdated comment

    @oli-obk
    oli-obk committed Feb 15, 2019
    Configuration menu
    Copy the full SHA
    d3d145e View commit details
    Browse the repository at this point in the history

  19. Keep MPlaceTy internals private

    @oli-obk
    oli-obk committed Feb 15, 2019
    Configuration menu
    Copy the full SHA
    1f718b0 View commit details
    Browse the repository at this point in the history

  20. Don't access the stack if not strictly necessary

    @oli-obk
    oli-obk committed Feb 15, 2019
    Configuration menu
    Copy the full SHA
    5ef183d View commit details
    Browse the repository at this point in the history