Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace TimeLine LLVM profiling with the self profiler #58488

Merged
merged 1 commit into from
Mar 14, 2019

Conversation

wesleywiser
Copy link
Member

@wesleywiser wesleywiser commented Feb 15, 2019

No description provided.

@rust-highfive
Copy link
Collaborator

r? @zackmdavis

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 15, 2019
@michaelwoerister
Copy link
Member

Yes, I think this is going in the right direction. However, I'd hold off on doing "instant" events at the moment and only use events with a distinct beginning and end. That is, basically, add a label to GenericActivityStart and GenericActivityEnd and remove GenericEvent.

Let me do another pass over the existing TimeLine events and mark them as either "remove" or "start-end"...

@wesleywiser
Copy link
Member Author

Thanks for all the feedback @michaelwoerister!

src/librustc/session/mod.rs Outdated Show resolved Hide resolved
@bors
Copy link
Contributor

bors commented Feb 17, 2019

☔ The latest upstream changes (presumably #58495) made this pull request unmergeable. Please resolve the merge conflicts.

@Dylan-DPC-zz Dylan-DPC-zz added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 4, 2019
@Dylan-DPC-zz
Copy link

ping from triage @wesleywiser any updates?

@wesleywiser wesleywiser changed the title [WIP] Replace TimeLine LLVM profiling with the self profiler Replace TimeLine LLVM profiling with the self profiler Mar 7, 2019
@wesleywiser wesleywiser marked this pull request as ready for review March 7, 2019 03:40
@bors
Copy link
Contributor

bors commented Mar 12, 2019

⌛ Testing commit 4c8cc14 with merge c9665aa9498cda868eee9a81ef1b93d194254994...

@bors
Copy link
Contributor

bors commented Mar 12, 2019

💥 Test timed out

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 12, 2019
@kennytm
Copy link
Member

kennytm commented Mar 12, 2019

@bors retry

4 hour timeout, a job didn't start at all.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 12, 2019
@bors
Copy link
Contributor

bors commented Mar 13, 2019

⌛ Testing commit 4c8cc14 with merge 557a419e76b9372c1369c2e685549e4b90e00757...

@bors
Copy link
Contributor

bors commented Mar 14, 2019

💔 Test failed - checks-travis

@rust-highfive
Copy link
Collaborator

The job arm-android of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
[01:50:35] test vec::test_splice_unbounded ... ok
[01:50:35] test vec::test_split_at_mut ... ok
[01:50:35] test vec::test_split_off ... ok
[01:50:35] test vec::test_swap_remove_empty ... ok
[01:50:36] died due to signal 11
[01:50:36] 
[01:50:36] 
[01:50:36] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "test" "--target" "arm-linux-androideabi" "-j" "4" "--release" "--locked" "--color" "always" "--features" "panic-unwind backtrace" "--manifest-path" "/checkout/src/libstd/Cargo.toml" "-p" "alloc" "--"
[01:50:36] expected success, got: exit code: 3
---
travis_time:end:2277743e:start=1552526869754793216,finish=1552526869765739725,duration=10946509
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:00006a98
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:01b7bb68
travis_time:start:01b7bb68
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:02f61ea0
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 14, 2019
@wesleywiser
Copy link
Member Author

Looks spurious to me

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 14, 2019
@bors
Copy link
Contributor

bors commented Mar 14, 2019

⌛ Testing commit 4c8cc14 with merge 2a936b710fe891cdfb86df82d231066d94c27412...

@bors
Copy link
Contributor

bors commented Mar 14, 2019

💥 Test timed out

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 14, 2019
@michaelwoerister
Copy link
Member

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 14, 2019
@bors
Copy link
Contributor

bors commented Mar 14, 2019

⌛ Testing commit 4c8cc14 with merge 2a8f6a7...

bors added a commit that referenced this pull request Mar 14, 2019
Replace TimeLine LLVM profiling with the self profiler
@bors
Copy link
Contributor

bors commented Mar 14, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: michaelwoerister
Pushing 2a8f6a7 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Mar 14, 2019
@bors bors merged commit 4c8cc14 into rust-lang:master Mar 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants