Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update clippy, RLS, and rustfmt #58571

Merged
merged 7 commits into from
Feb 19, 2019
Merged

Update clippy, RLS, and rustfmt #58571

merged 7 commits into from
Feb 19, 2019

Conversation

Manishearth
Copy link
Member

moved from #58337

@rust-highfive
Copy link
Collaborator

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive
Copy link
Collaborator

⚠️ Warning ⚠️

  • These commits modify submodules.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 19, 2019
@Manishearth Manishearth mentioned this pull request Feb 19, 2019
Closed
@Manishearth
Copy link
Member Author

@bors r+ p=5

(this is code from another PR moved over, my changes are just a submodule update to master)

p=5 because these bugs have been piling up, and this is a new version of a now-week-old PR

@bors
Copy link
Contributor

bors commented Feb 19, 2019

📌 Commit cd99bd3 has been approved by Manishearth

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 19, 2019
@bors
Copy link
Contributor

bors commented Feb 19, 2019

⌛ Testing commit cd99bd3 with merge 4d66b7b...

bors added a commit that referenced this pull request Feb 19, 2019
@bors
Auto merge of #58571 - Manishearth:rustup, r=Manishearth
4d66b7b 
Update clippy, RLS, and rustfmt

moved from #58337
@bors
Copy link
Contributor

bors commented Feb 19, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: Manishearth
Pushing 4d66b7b to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Feb 19, 2019
@bors bors merged commit cd99bd3 into rust-lang:master Feb 19, 2019
@rust-highfive
Copy link
Collaborator

📣 Toolstate changed by #58571!

Tested on commit 4d66b7b.
Direct link to PR: #58571

🎉 clippy-driver on windows: build-fail → test-pass (cc @Manishearth @llogiq @mcarton @oli-obk @phansch, @rust-lang/infra).
🎉 clippy-driver on linux: build-fail → test-pass (cc @Manishearth @llogiq @mcarton @oli-obk @phansch, @rust-lang/infra).
🎉 rls on windows: build-fail → test-pass (cc @nrc @Xanewok, @rust-lang/infra).
🎉 rls on linux: build-fail → test-pass (cc @nrc @Xanewok, @rust-lang/infra).
🎉 rustfmt on windows: build-fail → test-pass (cc @nrc @topecongiro, @rust-lang/infra).
🎉 rustfmt on linux: build-fail → test-pass (cc @nrc @topecongiro, @rust-lang/infra).

rust-highfive added a commit to rust-lang-nursery/rust-toolstate that referenced this pull request Feb 19, 2019
@rust-highfive
📣 Toolstate changed by rust-lang/rust#58571!
8bf1194 
Tested on commit rust-lang/rust@4d66b7b.
Direct link to PR: <rust-lang/rust#58571>

🎉 clippy-driver on windows: build-fail → test-pass (cc @Manishearth @llogiq @mcarton @oli-obk @phansch, @rust-lang/infra).
🎉 clippy-driver on linux: build-fail → test-pass (cc @Manishearth @llogiq @mcarton @oli-obk @phansch, @rust-lang/infra).
🎉 rls on windows: build-fail → test-pass (cc @nrc @Xanewok, @rust-lang/infra).
🎉 rls on linux: build-fail → test-pass (cc @nrc @Xanewok, @rust-lang/infra).
🎉 rustfmt on windows: build-fail → test-pass (cc @nrc @topecongiro, @rust-lang/infra).
🎉 rustfmt on linux: build-fail → test-pass (cc @nrc @topecongiro, @rust-lang/infra).
@topecongiro topecongiro mentioned this pull request Feb 20, 2019
Closed
@Manishearth Manishearth deleted the rustup branch July 18, 2020 01:15
@Manishearth Manishearth restored the rustup branch July 18, 2020 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@alexcrichton alexcrichton

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Manishearth @rust-highfive @bors @alexcrichton @flip1995