Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add expected/provided byte alignments to validation error message #58658

Merged
merged 4 commits into from
Feb 23, 2019
Merged

Add expected/provided byte alignments to validation error message #58658

merged 4 commits into from
Feb 23, 2019

Conversation

pmccarter
Copy link
Contributor

Fixes #58617

@rust-highfive
Copy link
Collaborator

r? @matthewjasper

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 22, 2019
@matthewjasper
Copy link
Contributor

r=me with comment addressed

cc @oli-obk

@rust-highfive

This comment has been minimized.

Sign in to view
@rust-highfive

This comment has been minimized.

Sign in to view
@Centril
Copy link
Contributor

Centril commented Feb 23, 2019

@bors r=matthewjasper

@bors
Copy link
Contributor

bors commented Feb 23, 2019

📌 Commit d0c110f has been approved by matthewjasper

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 23, 2019
Centril added a commit to Centril/rust that referenced this pull request Feb 23, 2019
@Centril
Rollup merge of rust-lang#58658 - pmccarter:align_msg, r=matthewjasper
6fa3116 
Add expected/provided byte alignments to validation error message

Fixes rust-lang#58617
@Centril Centril mentioned this pull request Feb 23, 2019
Closed
Centril added a commit to Centril/rust that referenced this pull request Feb 23, 2019
@Centril
Rollup merge of rust-lang#58658 - pmccarter:align_msg, r=matthewjasper
d038fb2 
Add expected/provided byte alignments to validation error message

Fixes rust-lang#58617
@Centril Centril mentioned this pull request Feb 23, 2019
Merged
bors added a commit that referenced this pull request Feb 23, 2019
@bors
Auto merge of #58669 - Centril:rollup, r=Centril
7f19f16 
Rollup of 16 pull requests

Successful merges:

 - #58100 (Transition librustdoc to Rust 2018)
 - #58122 (RangeInclusive internal iteration performance improvement.)
 - #58199 (Add better error message for partial move)
 - #58227 (Updated RELEASES.md for 1.33.0)
 - #58353 (Check the Self-type of inherent associated constants)
 - #58453 (SGX target: fix panic = abort)
 - #58476 (Remove `LazyTokenStream`.)
 - #58526 (Special suggestion for illegal unicode curly quote pairs)
 - #58595 (Turn duration consts into associated consts)
 - #58609 (Allow Self::Module to be mutated.)
 - #58628 (Optimise vec![false; N] to zero-alloc)
 - #58643 (Don't generate minification variables if minification disabled)
 - #58648 (Update tests to account for cross-platform testing and miri.)
 - #58654 (Do not underflow after resetting unmatched braces count)
 - #58658 (Add expected/provided byte alignments to validation error message)
 - #58667 (Reduce Miri-related Code Repetition `like (n << amt) >> amt`)

Failed merges:

r? @ghost
@bors bors merged commit d0c110f into rust-lang:master Feb 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewjasper matthewjasper matthewjasper left review comments

Assignees

@matthewjasper matthewjasper

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pmccarter @rust-highfive @matthewjasper @Centril @bors