-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove metadata only codegen backend #58847
Conversation
(rust_highfive has picked a reviewer for you, use r? to override) |
@bors: r+ |
📌 Commit 72dffcced14d7bb1db9ca0310e7a248046c32eff has been approved by |
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
@bors: r- delegate+ |
✌️ @bjorn3 can now approve this pull request |
72dffcc
to
4db55da
Compare
Removed commit 72dffcced14d7bb1db9ca0310e7a248046c32eff ([bootstrap] Remove llvm.enabled config) which was causing this. @bors r=alexcrichton |
📌 Commit 4db55da2bcd8356b38eeca7f4da587c81bb4b658 has been approved by |
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
@@ -109,9 +109,6 @@ pub fn get_codegen_backend(sess: &Session) -> Box<dyn CodegenBackend> { | |||
let codegen_name = sess.opts.debugging_opts.codegen_backend.as_ref() | |||
.unwrap_or(&sess.target.target.options.codegen_backend); | |||
let backend = match &codegen_name[..] { | |||
"metadata_only" => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we're removing this here, I assume we also need to remove this below?
rust/src/librustc_driver/test.rs
Line 100 in 350674b
options.debugging_opts.codegen_backend = Some("metadata_only".to_owned()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The rustc_driver
tests rely on the metadata-only backend since it can't find the real one. How is that resolved in this PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests in rustc_driver
is an artifact of days long before 1.0 (just look at what they are doing - testing lifetime inference? in rustc_driver?).
They should be just removed at long last.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now I get why it failed testing. I thought it was commit 72dffcc, which I removed after seeing the failing test. I will remove the tests from rustc_driver and reintroduce 72dffcc.
@bors r- Failed to test stage1 rustc_driver.
|
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
☔ The latest upstream changes (presumably #58836) made this pull request unmergeable. Please resolve the merge conflicts. |
cc7ff4f
to
8add308
Compare
Rebased |
@bors: r+ |
🔒 Merge conflict This pull request and the master branch diverged in a way that cannot be automatically merged. Please rebase on top of the latest master branch, and let the reviewer approve again. How do I rebase?Assuming
You may also read Git Rebasing to Resolve Conflicts by Drew Blessing for a short tutorial. Please avoid the "Resolve conflicts" button on GitHub. It uses Sometimes step 4 will complete without asking for resolution. This is usually due to difference between how Error message
|
aea0d50
to
0e0488f
Compare
Rebased @bors r=alexcrichton |
📌 Commit 0e0488f has been approved by |
Remove metadata only codegen backend It is unused and probably broken at the moment.
💔 Test failed - status-appveyor |
@bors retry |
Remove metadata only codegen backend It is unused and probably broken at the moment.
☀️ Test successful - checks-travis, status-appveyor |
It is unused and probably broken at the moment.