Rollup of 14 pull requests #58878
Closed
Rollup of 14 pull requests #58878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since there is nothing to optimise there...
Co-Authored-By: RalfJung <post@ralfj.de>
This will allow us to send it across threads and measure things like LLVM time.
There is no longer a need to append the string `", ..."` to a functions args as `...` is parsed as an argument and will appear in the functions arguments.
…r=michaelwoerister [self-profiler] Make the profiler faster/more efficient Related to rust-lang#58372 r? @michaelwoerister
…oerister Use informational target machine for metadata Since there is nothing to optimise there... Should fix rust-lang#58323 but haven’t tested locally. r? @michaelwoerister
…scottmcm
Have all methods of Filter and FilterMap use internal iteration
This PR changes `Filter::{next, next_back, count}` and `FilterMap::{next, next_back}` to all use internal iteration. The `next` and `next_back` methods are changed to directly forward to `try_for_each` and `try_rfold` respectively, using `Result` as the `Try` type. I think that's okay? Alternatively, I could change their implementations to use `LoopState` instead if there's any benefit in doing so.
r? @scottmcm
ManuallyDrop != MaybeUninit Cc @Centril
Replace `s` with `self` in docs for str methods taking self. Cherry picked from PR rust-lang#58596 which is blocked on some intra-doc link bugs.
allow specifying attributes for tool lints Needed for clippy to fix `unused_doc_comments` warnings that will be exposed by rust-lang#57882 (and thus unblock it).
Fixed a syntax error in the pin docs
…i-obk tidy: deny(rust_2018_idioms) r? @oli-obk
…nytm Revert switching to GCP on AppVeyor r? @alexcrichton
…r=oli-obk tools/rustbook: deny(rust_2018_idioms) r? @oli-obk
…t, r=oli-obk
tools/remote-test-{client,server}: deny(rust_2018_idioms)
r? @oli-obk
(+ tiny amount of cleanup)
Fix typo in Vec#resize_with documentation
Forbid duplicating Cargo as a dependency Fixes rust-lang#53005
Fix C-variadic function printing There is no longer a need to append the string `", ..."` to a functions args as `...` is parsed as an argument and will appear in the functions arguments. r? @alexreg cc @alexcrichton Fixes: rust-lang#58853
|
@bors r+ p=15 |
|
📌 Commit 8f8f70e has been approved by |
bors
added
the
S-waiting-on-bors
|
⌛ Testing commit 8f8f70e with merge 1653e3a0cd54fc76b211763d3d10ec77d116e3e9... |
|
💔 Test failed - checks-travis |
bors
added
S-waiting-on-review
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
swithselfin docs for str methods taking self. #58782 (Replaceswithselfin docs for str methods taking self.)Failed merges:
r? @ghost