Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Clippy #58966

Closed
wants to merge 1 commit into from
Closed

Update Clippy #58966

wants to merge 1 commit into from

Conversation

phansch
Copy link
Member

@phansch phansch commented Mar 6, 2019

  • Ensure expect_fun_call bad suggestion is fixed
  • fix or ignore failing doc tests
  • move lint documentation into macro invocations
  • Fix missing_const_for_fn for impl trait methods
  • Don't trigger missing_const_for_fn in external macros

This unblocks #57882

@phansch
Update Clippy submodule
d6034bb 
* Ensure `expect_fun_call` bad suggestion is fixed
* fix or ignore failing doc tests
* move lint documentation into macro invocations
* Fix missing_const_for_fn for impl trait methods
* Don't trigger missing_const_for_fn in external macros
@rust-highfive
Copy link
Collaborator

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive
Copy link
Collaborator

⚠️ Warning ⚠️

  • These commits modify submodules.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 6, 2019
@phansch phansch changed the title Update Clippy submodule Update Clippy Mar 6, 2019
@phansch
Copy link
Member Author

phansch commented Mar 6, 2019

r? @oli-obk

@rust-highfive rust-highfive assigned oli-obk and unassigned nikomatsakis Mar 6, 2019
@oli-obk
Copy link
Contributor

oli-obk commented Mar 6, 2019

@bors r+ p=1

@bors
Copy link
Contributor

bors commented Mar 6, 2019

📌 Commit d6034bb has been approved by oli-obk

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 6, 2019
@bors
Copy link
Contributor

bors commented Mar 6, 2019

⌛ Testing commit d6034bb with merge 46b9384ae95631b6b32bbfd6909ed9afcca55130...

@bors
Copy link
Contributor

bors commented Mar 6, 2019

💔 Test failed - status-appveyor

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 6, 2019
@rust-highfive
Copy link
Collaborator

Your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log. 
Checking out files: 100% (18113/18113), done.
travis_time:end:00a3d61b:start=1551870022790605000,finish=1551870034253551000,duration=11462946000
$ cd rust-lang/rust
$ git checkout -qf 46b9384ae95631b6b32bbfd6909ed9afcca55130
fatal: reference is not a tree: 46b9384ae95631b6b32bbfd6909ed9afcca55130
The command "git checkout -qf 46b9384ae95631b6b32bbfd6909ed9afcca55130" failed and exited with 128 during .
Your build has been stopped.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@phansch
Copy link
Member Author

phansch commented Mar 6, 2019

Is that a spurious failure? The commit 46b9384ae95631b6b32bbfd6909ed9afcca55130 clearly exists?

@oli-obk
Copy link
Contributor

oli-obk commented Mar 6, 2019

fatal: unable to access 'https://github.com/rust-lang/rust.git/': Could not resolve host: github.com

Yes, that looks very spurious

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 6, 2019
@ljedrz ljedrz mentioned this pull request Mar 8, 2019
Merged
3 tasks
@ljedrz
Copy link
Contributor

ljedrz commented Mar 8, 2019

@phansch I also filed a clippy update under #58915. It should be more recent, hope it's ok 🤞.

@phansch
Copy link
Member Author

phansch commented Mar 8, 2019

@ljedrz No problem, thank you!

@phansch phansch closed this Mar 8, 2019
@phansch phansch deleted the update_clippy_submodule branch March 8, 2019 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@oli-obk oli-obk

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@phansch @rust-highfive @oli-obk @bors @ljedrz @nikomatsakis