Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace assert with assert_eq #59124

Closed
wants to merge 1 commit into from
Closed

Replace assert with assert_eq #59124

wants to merge 1 commit into from

Conversation

ohsayan
Copy link
Contributor

@ohsayan ohsayan commented Mar 12, 2019

Use assert_eq! instead of assert! for the tests

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @cramertj (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 12, 2019
@ohsayan ohsayan changed the title Replace assert with assert_eq for better debugging Replace assert with assert_eq Mar 12, 2019
@ohsayan
Copy link
Contributor Author

ohsayan commented Mar 12, 2019

r? @Centril

@rust-highfive rust-highfive assigned Centril and unassigned cramertj Mar 12, 2019
@Centril
Copy link
Contributor

Centril commented Mar 12, 2019

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Mar 12, 2019

📌 Commit 365d918 has been approved by Centril

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 12, 2019
@ohsayan
Copy link
Contributor Author

ohsayan commented Mar 12, 2019

@Centril Checks complete

pietroalbini added a commit to pietroalbini/rust that referenced this pull request Mar 12, 2019
@pietroalbini
Rollup merge of rust-lang#59124 - sntdevco:master, r=Centril
247aa67 
Replace assert with assert_eq

Use `assert_eq!` instead of `assert!` for the tests
@pietroalbini pietroalbini mentioned this pull request Mar 12, 2019
Closed
Centril added a commit to Centril/rust that referenced this pull request Mar 13, 2019
@Centril
Rollup merge of rust-lang#59124 - sntdevco:master, r=Centril
f3dc046 
Replace assert with assert_eq

Use `assert_eq!` instead of `assert!` for the tests
@Centril Centril mentioned this pull request Mar 13, 2019
Merged
bors added a commit that referenced this pull request Mar 13, 2019
@bors
Auto merge of #59151 - Centril:rollup, r=Centril
aa97448 
Rollup of 16 pull requests

Successful merges:

 - #58829 (librustc_interface: Update scoped-tls to 1.0)
 - #58876 (Parse lifetimes that start with a number and give specific error)
 - #58908 (Update rand version)
 - #58998 (Fix documentation of from_ne_bytes and from_le_bytes)
 - #59056 (Use lifetime contravariance to elide more lifetimes in core+alloc+std)
 - #59057 (Standardize `Range*` documentation)
 - #59080 (Fix incorrect links in librustc_codegen_llvm documentation)
 - #59083 (Fix #54822 and associated faulty tests)
 - #59093 (Remove precompute_in_scope_traits_hashes)
 - #59101 (Reduces Code Repetitions like `!n >> amt`)
 - #59121 (impl FromIterator for Result: Use assert_eq! instead of assert!)
 - #59124 (Replace assert with assert_eq)
 - #59129 (Visit impl Trait for dead_code lint)
 - #59130 (Note that NonNull does not launder shared references for mutation)
 - #59132 (ignore higher-ranked object bound conditions created by WF)
 - #59138 (Simplify Iterator::{min, max})

Failed merges:

r? @ghost
@tesuji
Copy link
Contributor

tesuji commented Mar 13, 2019

@sntdevco You should use git revert to revert commit rather then re-adding deleted lines.

@ohsayan
Copy link
Contributor Author

ohsayan commented Mar 13, 2019

@sntdevco You should use git revert to revert commit rather then re-adding deleted lines.

Was in a hurry. Will revert straight away!

@Centril
Copy link
Contributor

Centril commented Mar 13, 2019

I believe the first commit of this PR, before changes to it, was merged in #59151 so I'll close this as done.

@Centril Centril closed this Mar 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Centril Centril

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ohsayan @rust-highfive @Centril @bors @tesuji @cramertj