-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exclude old book redirect stubs from search engines #59197
Conversation
(rust_highfive has picked a reviewer for you, use r? to override) |
Seems fine to me, but since this is primarily a bootstrap change, i want to get another set of eyes on it, to make sure that it's only affecting the book redirects. |
Same question as the robots.txt one; this loses all of our google juice, right? |
With caveat that SEO is mostly speculation… The meta includes Even for pages entirely hidden from the index I expect search engines to contribute the links to overall ranking/authority of the domain (that's how seomoz models rankings). I also expect this to improve ranking of the docs domain by improving CTR and reducing bounce rate (these are metrics tracked by Google). From what I've observed, Google seems to limit results to a few pages from each domain, and these stubs crowd-out actual book from results. Having them gone should make room for the real book. And finally, users complain about being unable to find Rust documentation they're looking for, so having some highly-ranked pages, if they aren't helpful to users, isn't good. |
r? @steveklabnik for SEO approval, from a rustbuild point of view looks fine |
@bors: r+ rollup Yep, thanks @kornelski , that seems to match what I've read about this too. Appreciate your patience. |
📌 Commit 8b5a748 has been approved by |
Exclude old book redirect stubs from search engines Adds `<meta name="robots" content="noindex,follow">` to the `<head>` of old stub pages pointing to the second edition of the book. This is continuation of rust-lang/book#1788
Rollup of 7 pull requests Successful merges: - #59004 ([rustdoc] Improve "in parameters" search and search more generally) - #59026 (Fix moving text in search tabs headers) - #59197 (Exclude old book redirect stubs from search engines) - #59330 (Improve the documentation for std::convert (From, Into, AsRef and AsMut)) - #59424 (Fix code block display in portability element in dark theme) - #59427 (Link to PhantomData in NonNull documentation) - #59432 (Improve some compiletest documentation) Failed merges: r? @ghost
Rollup of 7 pull requests Successful merges: - #59004 ([rustdoc] Improve "in parameters" search and search more generally) - #59026 (Fix moving text in search tabs headers) - #59197 (Exclude old book redirect stubs from search engines) - #59330 (Improve the documentation for std::convert (From, Into, AsRef and AsMut)) - #59424 (Fix code block display in portability element in dark theme) - #59427 (Link to PhantomData in NonNull documentation) - #59432 (Improve some compiletest documentation) Failed merges: r? @ghost
Blocked by #68677 |
Adds
<meta name="robots" content="noindex,follow">
to the<head>
of old stub pages pointing to the second edition of the book.This is continuation of rust-lang/book#1788