-
Notifications
You must be signed in to change notification settings - Fork 13.4k
Generalize diagnostic for x = y
where bool
is the expected type
#59439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
bors
merged 4 commits into
rust-lang:master
from
Centril:generalize-assign-to-bool-diagnostic
Mar 28, 2019
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
7945eff
generalize diagnostic for x = y where type bool is expected.
Centril 05d59fe
add test for assignment x = y where type bool is expected.
Centril 0b9c589
adjust assignment-in-if test accordingly.
Centril ce1c5e0
add negative test case in assignment-expected-bool
Centril File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,34 @@ | ||
// The purpose of this text is to ensure that we get good | ||
// diagnostics when a `bool` is expected but that due to | ||
// an assignment expression `x = y` the type is `()`. | ||
|
||
fn main() { | ||
let _: bool = 0 = 0; //~ ERROR mismatched types [E0308] | ||
|
||
let _: bool = match 0 { | ||
0 => 0 = 0, //~ ERROR mismatched types [E0308] | ||
_ => 0 = 0, //~ ERROR mismatched types [E0308] | ||
}; | ||
|
||
let _: bool = match true { | ||
true => 0 = 0, //~ ERROR mismatched types [E0308] | ||
_ => (), | ||
}; | ||
|
||
if 0 = 0 {} //~ ERROR mismatched types [E0308] | ||
|
||
let _: bool = if { 0 = 0 } { //~ ERROR mismatched types [E0308] | ||
0 = 0 //~ ERROR mismatched types [E0308] | ||
} else { | ||
0 = 0 //~ ERROR mismatched types [E0308] | ||
}; | ||
|
||
let _ = (0 = 0) //~ ERROR mismatched types [E0308] | ||
&& { 0 = 0 } //~ ERROR mismatched types [E0308] | ||
|| (0 = 0); //~ ERROR mismatched types [E0308] | ||
|
||
// A test to check that not expecting `bool` behaves well: | ||
let _: usize = 0 = 0; | ||
//~^ ERROR mismatched types [E0308] | ||
//~| ERROR invalid left-hand side expression [E0070] | ||
} | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.