-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update rustfmt to 1.2.0 #59454
Merged
Merged
Update rustfmt to 1.2.0 #59454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(rust_highfive has picked a reviewer for you, use r? to override) |
|
rust-highfive
added
the
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
label
Mar 27, 2019
Closed
@bors: r+ p=1 |
📌 Commit c728ae0 has been approved by |
bors
added
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Mar 27, 2019
Won’t this also need an RLS bump with a Cargo.toml update? I’m not sure if
Rust patch approach will work since 1.1 (specified by the RLS) and 1.2 are
incompatible
…On Wed, 27 Mar 2019 at 11:43, bors ***@***.***> wrote:
📌 Commit c728ae0
<c728ae0>
has been approved by nrc
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#59454 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AC8y3Vpe1PZgYFCYsDvgW2G7m492CyyVks5va0tpgaJpZM4cMyj2>
.
|
bors
added a commit
to rust-lang/rls
that referenced
this pull request
Mar 27, 2019
Update Rustfmt to 1.2 In case it's needed by rust-lang/rust#59454.
bors
added a commit
to rust-lang/rls
that referenced
this pull request
Mar 27, 2019
Update Rustfmt to 1.2 In case it's needed by rust-lang/rust#59454.
bors
added a commit
to rust-lang/rls
that referenced
this pull request
Mar 27, 2019
Update Rustfmt to 1.2 In case it's needed by rust-lang/rust#59454.
bors
added a commit
that referenced
this pull request
Mar 29, 2019
Rollup of 9 pull requests Successful merges: - #59366 (Update books) - #59436 (Update jemalloc-sys to version 0.3.0) - #59454 (Update rustfmt to 1.2.0) - #59462 (Fix error in Rust 2018 + no_core environment) - #59467 (Better diagnostic for binary operation on BoxedValues) - #59473 (Do not emit incorrect borrow suggestion involving macros and fix overlapping multiline spans) - #59480 (Update stdsimd) - #59486 (Visit `ImplItem` in `dead_code` lint) - #59510 (Rename `type_parameters` to `generics` and so on) Failed merges: - #59516 (Update cargo) r? @ghost
bors
added a commit
that referenced
this pull request
Mar 29, 2019
Rollup of 9 pull requests Successful merges: - #59366 (Update books) - #59436 (Update jemalloc-sys to version 0.3.0) - #59454 (Update rustfmt to 1.2.0) - #59462 (Fix error in Rust 2018 + no_core environment) - #59467 (Better diagnostic for binary operation on BoxedValues) - #59473 (Do not emit incorrect borrow suggestion involving macros and fix overlapping multiline spans) - #59480 (Update stdsimd) - #59486 (Visit `ImplItem` in `dead_code` lint) - #59510 (Rename `type_parameters` to `generics` and so on) Failed merges: - #59516 (Update cargo) r? @ghost
bors
added a commit
to rust-lang/rls
that referenced
this pull request
Apr 5, 2019
Update Rustfmt to 1.2 In case it's needed by rust-lang/rust#59454.
bors
added a commit
to rust-lang/rls
that referenced
this pull request
Apr 5, 2019
Update Rustfmt to 1.2 In case it's needed by rust-lang/rust#59454.
bors
added a commit
to rust-lang/rls
that referenced
this pull request
Apr 5, 2019
Update Rustfmt to 1.2 In case it's needed by rust-lang/rust#59454.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This release includes bug fixes and performance improvements from 1.1.0. Also it adds a new rustfmt tool attribute
#[rustfmt::skip::macros]
, which lets you skip formatting macro calls of your choice.cc @nrc @Centril @Xanewok