musl: build toolchain libs with -fPIC #59468
Conversation
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
r? @nagisa |
|
Hmm. The only reason I could imagine to try to avoid doing this would be if we didn't want to apply position-independent code everywhere for MUSL, and the only reason I could imagine doing that would be if we thought there would be lost optimization opportunities. But, given that we are seeing an important customer (ripgrep) fail to build, and this change fixes it, I'm going to go ahead and take the plunge here, approving the change without first trying to evaluation the performance impact (which I honestly suspect will be insignificant in most and maybe all cases). |
|
@bors r+ |
|
📌 Commit c764890 has been approved by |
bors
added
S-waiting-on-bors
|
r? @pnkfelix |
|
In fact this PR sort of brings PIC back. Before #58575 The day will come when all binutils < 2.26 distros are EOL (for Ubuntu 14.04 it's end of the next month and for CentOS 6 it's end of 2020). That will be beautiful day because |
|
thanks @mati865 for the clarification! |
musl: build toolchain libs with -fPIC Fixes rust-lang#59411
Rollup of 11 pull requests Successful merges: - #58019 (Combine all builtin late lints and make lint checking parallel) - #59358 (Use `track_errors` instead of hand rolling) - #59394 (warn -> deny duplicate match bindings) - #59401 (bootstrap: build crates under libtest with -Z emit-stack-sizes) - #59423 (Visit path in `walk_mac`) - #59468 (musl: build toolchain libs with -fPIC) - #59476 (Use `SmallVec` in `TokenStreamBuilder`.) - #59496 (Remove unnecessary with_globals calls) - #59498 (Use 'write_all' instead of 'write' in example code) - #59503 (Stablize {f32,f64}::copysign().) - #59511 (Fix missed fn rename in #59284) Failed merges: r? @ghost
Rollup of 11 pull requests Successful merges: - #58019 (Combine all builtin late lints and make lint checking parallel) - #59358 (Use `track_errors` instead of hand rolling) - #59394 (warn -> deny duplicate match bindings) - #59401 (bootstrap: build crates under libtest with -Z emit-stack-sizes) - #59423 (Visit path in `walk_mac`) - #59468 (musl: build toolchain libs with -fPIC) - #59476 (Use `SmallVec` in `TokenStreamBuilder`.) - #59496 (Remove unnecessary with_globals calls) - #59498 (Use 'write_all' instead of 'write' in example code) - #59503 (Stablize {f32,f64}::copysign().) - #59511 (Fix missed fn rename in #59284) Failed merges: r? @ghost
Rust is having problems with trusty, in particular, see this bug I filed: rust-lang/rust#59411 This was purpotedly fixed in rust-lang/rust#59468, but it appears the issue is still occurring. This commit tries to update to Ubuntu 16.04 in the hope that it will fix this problem.
Rust is having problems with trusty, in particular, see this bug I filed: rust-lang/rust#59411 This was purpotedly fixed in rust-lang/rust#59468, but it appears the issue is still occurring. This commit tries to update to Ubuntu 16.04 in the hope that it will fix this problem.
Fixes #59411