Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SGX target: Use linker option to avoid code CGU assignment kludge #59624

Merged
merged 1 commit into from
Apr 6, 2019

Conversation

jethrogb
Copy link
Contributor

@jethrogb jethrogb commented Apr 2, 2019

@rust-highfive
Copy link
Contributor

r? @shepmaster

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 2, 2019
@jethrogb
Copy link
Contributor Author

jethrogb commented Apr 4, 2019

r? @alexcrichton

@faern
Copy link
Contributor

faern commented Apr 4, 2019

Would be nice to have this merged before #56410. Since they currently both move the same code around. I can do a lot less with this code in the other PR if this is merged :)

@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Collaborator

bors commented Apr 5, 2019

📌 Commit 0a1a475 has been approved by alexcrichton

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 5, 2019
Centril added a commit to Centril/rust that referenced this pull request Apr 5, 2019
…crichton

SGX target: Use linker option to avoid code CGU assignment kludge

cc @VardhanThigle @faern
Centril added a commit to Centril/rust that referenced this pull request Apr 5, 2019
…crichton

SGX target: Use linker option to avoid code CGU assignment kludge

cc @VardhanThigle @faern
Centril added a commit to Centril/rust that referenced this pull request Apr 5, 2019
…crichton

SGX target: Use linker option to avoid code CGU assignment kludge

cc @VardhanThigle @faern
bors added a commit that referenced this pull request Apr 5, 2019
Rollup of 6 pull requests

Successful merges:

 - #58894 (Fix invalid bounds string generation in rustdoc)
 - #59599 (Updated RELEASES.md for 1.34.0)
 - #59624 (SGX target: Use linker option to avoid code CGU assignment kludge)
 - #59696 (Remove invalid assertion back::link::from add_upstream_rust_crates().)
 - #59707 (Add missing tryfrom example)
 - #59727 (wasi: Use shared API for preopened fds)

Failed merges:

r? @ghost
@bors bors merged commit 0a1a475 into rust-lang:master Apr 6, 2019
@workingjubilee workingjubilee added the O-SGX Target: SGX label Jul 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
O-SGX Target: SGX S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants