-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SGX target: Use linker option to avoid code CGU assignment kludge #59624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r? @shepmaster (rust_highfive has picked a reviewer for you, use r? to override) |
Would be nice to have this merged before #56410. Since they currently both move the same code around. I can do a lot less with this code in the other PR if this is merged :) |
@bors: r+ |
📌 Commit 0a1a475 has been approved by |
Centril
added a commit
to Centril/rust
that referenced
this pull request
Apr 5, 2019
…crichton SGX target: Use linker option to avoid code CGU assignment kludge cc @VardhanThigle @faern
Centril
added a commit
to Centril/rust
that referenced
this pull request
Apr 5, 2019
…crichton SGX target: Use linker option to avoid code CGU assignment kludge cc @VardhanThigle @faern
Centril
added a commit
to Centril/rust
that referenced
this pull request
Apr 5, 2019
…crichton SGX target: Use linker option to avoid code CGU assignment kludge cc @VardhanThigle @faern
bors
added a commit
that referenced
this pull request
Apr 5, 2019
Rollup of 6 pull requests Successful merges: - #58894 (Fix invalid bounds string generation in rustdoc) - #59599 (Updated RELEASES.md for 1.34.0) - #59624 (SGX target: Use linker option to avoid code CGU assignment kludge) - #59696 (Remove invalid assertion back::link::from add_upstream_rust_crates().) - #59707 (Add missing tryfrom example) - #59727 (wasi: Use shared API for preopened fds) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
O-SGX
Target: SGX
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @VardhanThigle @faern