Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 4 pull requests #59657

Merged
merged 9 commits into from
Apr 3, 2019
Merged

Rollup of 4 pull requests #59657

merged 9 commits into from
Apr 3, 2019

Commits on Mar 11, 2019

  1. Add initial implementation of 'sort_at_index' for slices -- analog to…

    … C++'s std::nth_element (a.k.a. quickselect)
    
    Add some more notes to the documentation:
    
    - Mention that the median can be found if we used `len() / 2`.
    - Mention that this function is usually called "kth element" in other libraries.
    
    Address some comments in PR:
    
    - Change wording on some of the documentation
    - Change recursive function into a loop
    
    Update name to `partition_at_index` and add convenience return values.
    
    Address reviewer comments:
    
    - Don't swap on each iteration when searching for min/max element.
    - Add some docs about when we panic.
    - Test that the sum of the lengths of the output matches the length of the input.
    - Style fix for for-loop.
    
    Address more reviewer comments
    
    Fix Rng stuff for test
    
    Fix doc test build
    
    Don't run the partition_at_index test on wasm targets
    
    Miri does not support entropy for test partition_at_index
    Mokosha committed Mar 11, 2019
    Configuration menu
    Copy the full SHA
    3f306db View commit details
    Browse the repository at this point in the history

Commits on Mar 29, 2019

  1. Configuration menu
    Copy the full SHA
    f5fee8f View commit details
    Browse the repository at this point in the history

Commits on Apr 2, 2019

  1. Configuration menu
    Copy the full SHA
    ac29ca7 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    4122d22 View commit details
    Browse the repository at this point in the history
  3. Shrink mir::Statement.

    The `InlineAsm` variant is extremely rare, and `mir::Statement` often
    contributes significantly to peak memory usage.
    nnethercote committed Apr 2, 2019
    Configuration menu
    Copy the full SHA
    d00d639 View commit details
    Browse the repository at this point in the history

Commits on Apr 3, 2019

  1. Rollup merge of rust-lang#55448 - Mokosha:SortAtIndex, r=bluss

    Add 'partition_at_index/_by/_by_key' for slices.
    
    This is an analog to C++'s std::nth_element (a.k.a. quickselect).
    
    Corresponds to tracking bug rust-lang#55300.
    Centril authored Apr 3, 2019
    Configuration menu
    Copy the full SHA
    2f37c5a View commit details
    Browse the repository at this point in the history
  2. Rollup merge of rust-lang#59186 - ssomers:btreeset_intersection_revis…

    …ited_again, r=KodrAus
    
    improve worst-case performance of BTreeSet intersection v3
    
    Variation of [rust-lang#59078](rust-lang#59078) with `Intersection` remaining a struct
    
    r? @scottmcm
    Centril authored Apr 3, 2019
    Configuration menu
    Copy the full SHA
    9898182 View commit details
    Browse the repository at this point in the history
  3. Rollup merge of rust-lang#59514 - tmandry:remove-adt-def-from-project…

    …ion-elem, r=eddyb
    
    Remove adt_def from projections and downcasts in MIR
    
    As part of optimizing generator layouts in MIR, we'd like to allow downcasting generators to variants which do not have a corresponding `def_id`, since they are created by the compiler.
    
    This refactor hopes to allow that, without regressing perf.
    
    r? @eddyb
    Centril authored Apr 3, 2019
    Configuration menu
    Copy the full SHA
    a96e388 View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#59630 - nnethercote:shrink-mir-Statement, r…

    …=pnkfelix
    
    Shrink `mir::Statement`.
    
    The `InlineAsm` variant is extremely rare, and `mir::Statement` often
    contributes significantly to peak memory usage.
    Centril authored Apr 3, 2019
    Configuration menu
    Copy the full SHA
    d31d80b View commit details
    Browse the repository at this point in the history