Update clippy #59783

Manishearth · 2019-04-07T21:22:56Z

Update to rust-lang/rust-clippy@cffb416

Pulls in rust-lang/rust-clippy#3927

Should unbork the build

r? @oli-obk

rust-highfive · 2019-04-07T21:23:06Z

⚠️ Warning ⚠️

These commits modify submodules.

Xanewok · 2019-04-07T21:24:43Z

@bors r+ p=10

bors · 2019-04-07T21:24:44Z

📌 Commit e16dce0 has been approved by Xanewok

bors · 2019-04-07T21:26:20Z

⌛ Testing commit e16dce0 with merge 9ef0230012157287a9da095516f85abe5bd53283...

rust-highfive · 2019-04-07T21:26:57Z

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

travis_time:end:03e96052:start=1554672247955813677,finish=1554672248859197165,duration=903383488
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
$ export GCP_CACHE_BUCKET=rust-lang-ci-cache
Setting environment variables from .travis.yml
---
[00:01:56] 
######################################################################## 100.0%
[00:01:56] extracting /checkout/obj/build/cache/2019-03-20/cargo-beta-x86_64-unknown-linux-gnu.tar.gz
[00:01:56]     Updating crates.io index
[00:02:10] error: failed to select a version for `compiletest_rs`.
[00:02:10]     ... required by package `miri v0.1.0 (/checkout/src/tools/miri)`
[00:02:10] versions that meet the requirements `= 0.3.19` are: 0.3.19
[00:02:10] all possible versions conflict with previously selected packages.
[00:02:10] 
[00:02:10]   previously selected package `compiletest_rs v0.3.21`
[00:02:10]     ... which is depended on by `clippy v0.0.212 (/checkout/src/tools/clippy)`
---
[00:02:10] Makefile:69: recipe for target 'prepare' failed
[00:02:10] make: *** [prepare] Error 1
[00:02:11] Command failed. Attempt 2/5:
[00:02:12]     Updating crates.io index
[00:02:12] error: failed to select a version for `compiletest_rs`.
[00:02:12]     ... required by package `miri v0.1.0 (/checkout/src/tools/miri)`
[00:02:12] versions that meet the requirements `= 0.3.19` are: 0.3.19
[00:02:12] all possible versions conflict with previously selected packages.
[00:02:12] 
[00:02:12]   previously selected package `compiletest_rs v0.3.21`
[00:02:12]     ... which is depended on by `clippy v0.0.212 (/checkout/src/tools/clippy)`
---
[00:02:12] Makefile:69: recipe for target 'prepare' failed
[00:02:12] make: *** [prepare] Error 1
[00:02:14] Command failed. Attempt 3/5:
[00:02:14]     Updating crates.io index
[00:02:15] error: failed to select a version for `compiletest_rs`.
[00:02:15]     ... required by package `miri v0.1.0 (/checkout/src/tools/miri)`
[00:02:15] versions that meet the requirements `= 0.3.19` are: 0.3.19
[00:02:15] all possible versions conflict with previously selected packages.
[00:02:15] 
[00:02:15]   previously selected package `compiletest_rs v0.3.21`
[00:02:15]     ... which is depended on by `clippy v0.0.212 (/checkout/src/tools/clippy)`
---
[00:02:15] Makefile:69: recipe for target 'prepare' failed
[00:02:15] make: *** [prepare] Error 1
[00:02:18] Command failed. Attempt 4/5:
[00:02:18]     Updating crates.io index
[00:02:18] error: failed to select a version for `compiletest_rs`.
[00:02:18]     ... required by package `miri v0.1.0 (/checkout/src/tools/miri)`
[00:02:18] versions that meet the requirements `= 0.3.19` are: 0.3.19
[00:02:18] all possible versions conflict with previously selected packages.
[00:02:18] 
[00:02:18]   previously selected package `compiletest_rs v0.3.21`
[00:02:18]     ... which is depended on by `clippy v0.0.212 (/checkout/src/tools/clippy)`
---
[00:02:18] make: *** [prepare] Error 1
[00:02:18] Makefile:69: recipe for target 'prepare' failed
[00:02:22] Command failed. Attempt 5/5:
[00:02:22]     Updating crates.io index
[00:02:22] error: failed to select a version for `compiletest_rs`.
[00:02:22]     ... required by package `miri v0.1.0 (/checkout/src/tools/miri)`
[00:02:22] versions that meet the requirements `= 0.3.19` are: 0.3.19
[00:02:22] all possible versions conflict with previously selected packages.
[00:02:22] 
[00:02:22]   previously selected package `compiletest_rs v0.3.21`
[00:02:22]     ... which is depended on by `clippy v0.0.212 (/checkout/src/tools/clippy)`
---
travis_time:end:04b43d28:start=1554672405160209137,finish=1554672405165423240,duration=5214103
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:0b686a31
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:06018450
travis_time:start:06018450
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:094fae92
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

bors · 2019-04-07T21:30:07Z

💔 Test failed - checks-travis

rust-highfive · 2019-04-07T21:30:08Z

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

###########################################################               83.1%
######################################################################## 100.0%
[00:01:59] extracting /checkout/obj/build/cache/2019-03-20/cargo-beta-x86_64-unknown-linux-gnu.tar.gz
[00:01:59]     Updating crates.io index
[00:02:14] error: failed to select a version for `compiletest_rs`.
[00:02:14]     ... required by package `miri v0.1.0 (/checkout/src/tools/miri)`
[00:02:14] versions that meet the requirements `= 0.3.19` are: 0.3.19
[00:02:14] all possible versions conflict with previously selected packages.
[00:02:14] 
[00:02:14]   previously selected package `compiletest_rs v0.3.21`
[00:02:14]     ... which is depended on by `clippy v0.0.212 (/checkout/src/tools/clippy)`
---
[00:02:14] make: *** [prepare] Error 1
[00:02:14] Makefile:69: recipe for target 'prepare' failed
[00:02:15] Command failed. Attempt 2/5:
[00:02:15]     Updating crates.io index
[00:02:15] error: failed to select a version for `compiletest_rs`.
[00:02:15]     ... required by package `miri v0.1.0 (/checkout/src/tools/miri)`
[00:02:15] versions that meet the requirements `= 0.3.19` are: 0.3.19
[00:02:15] all possible versions conflict with previously selected packages.
[00:02:15] 
[00:02:15]   previously selected package `compiletest_rs v0.3.21`
[00:02:15]     ... which is depended on by `clippy v0.0.212 (/checkout/src/tools/clippy)`
---
[00:02:15] make: *** [prepare] Error 1
[00:02:15] Makefile:69: recipe for target 'prepare' failed
[00:02:17] Command failed. Attempt 3/5:
[00:02:17]     Updating crates.io index
[00:02:18] error: failed to select a version for `compiletest_rs`.
[00:02:18]     ... required by package `miri v0.1.0 (/checkout/src/tools/miri)`
[00:02:18] versions that meet the requirements `= 0.3.19` are: 0.3.19
[00:02:18] all possible versions conflict with previously selected packages.
[00:02:18] 
[00:02:18]   previously selected package `compiletest_rs v0.3.21`
[00:02:18]     ... which is depended on by `clippy v0.0.212 (/checkout/src/tools/clippy)`
---
[00:02:18] Makefile:69: recipe for target 'prepare' failed
[00:02:18] make: *** [prepare] Error 1
[00:02:21] Command failed. Attempt 4/5:
[00:02:21]     Updating crates.io index
[00:02:21] error: failed to select a version for `compiletest_rs`.
[00:02:21]     ... required by package `miri v0.1.0 (/checkout/src/tools/miri)`
[00:02:21] versions that meet the requirements `= 0.3.19` are: 0.3.19
[00:02:21] all possible versions conflict with previously selected packages.
[00:02:21] 
[00:02:21]   previously selected package `compiletest_rs v0.3.21`
[00:02:21]     ... which is depended on by `clippy v0.0.212 (/checkout/src/tools/clippy)`
---
[00:02:21] make: *** [prepare] Error 1
[00:02:21] Makefile:69: recipe for target 'prepare' failed
[00:02:25] Command failed. Attempt 5/5:
[00:02:25]     Updating crates.io index
[00:02:26] error: failed to select a version for `compiletest_rs`.
[00:02:26]     ... required by package `miri v0.1.0 (/checkout/src/tools/miri)`
[00:02:26] versions that meet the requirements `= 0.3.19` are: 0.3.19
[00:02:26] all possible versions conflict with previously selected packages.
[00:02:26] 
[00:02:26]   previously selected package `compiletest_rs v0.3.21`
[00:02:26]     ... which is depended on by `clippy v0.0.212 (/checkout/src/tools/clippy)`
---
travis_time:end:0c44ce40:start=1554672596360144788,finish=1554672596368494567,duration=8349779
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:02553da4
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:1330b0ab
travis_time:start:1330b0ab
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:072bbc9e
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

Manishearth · 2019-04-07T21:37:28Z

Needs rust-lang/miri#682

Also rust-lang/rust-clippy#3928 is nice to have

Xanewok · 2019-04-07T21:39:28Z

@Manishearth r=me with the linked PRs merged

Manishearth · 2019-04-07T21:39:59Z

Added a commit bumping miri to see if travis likes it. Don't merge, however, since that commit may change.

Manishearth · 2019-04-07T22:25:26Z

@bors r=Xanewok

bors · 2019-04-07T22:25:27Z

📌 Commit 5001ee3 has been approved by Xanewok

Centril · 2019-04-08T00:41:26Z

@bors p=15

Manishearth · 2019-04-09T04:52:05Z

Diffing the actual rustc timing info, it just seems like everything is overall a tiny bit slower.

Might be miri's fault here? Clippy definitely can't slow down everything.

It's also just possible that travis decided to be slow.

bors · 2019-04-09T05:00:19Z

⌛ Testing commit 5001ee3 with merge 66f670ce93487717c057e8127c1ba9f70256b21c...

Manishearth · 2019-04-09T05:01:36Z

@bors retry

yield priority to check if it's not just clippy that's broken

bors · 2019-04-09T05:01:46Z

⌛ Testing commit 5001ee3 with merge 16ef7dceb8d56fabe30ee019395698416a6acde4...

rust-highfive · 2019-04-09T05:02:08Z

Your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

Cloning into 'rust-lang/rust'...
travis_time:end:0ad300cd:start=1554786105032676224,finish=1554786111216547850,duration=6183871626
$ cd rust-lang/rust
$ git checkout -qf 66f670ce93487717c057e8127c1ba9f70256b21c
fatal: reference is not a tree: 66f670ce93487717c057e8127c1ba9f70256b21c
The command "git checkout -qf 66f670ce93487717c057e8127c1ba9f70256b21c" failed and exited with 128 during .
Your build has been stopped.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

Manishearth · 2019-04-09T05:02:10Z

@bors p=rollup retry

bors · 2019-04-09T05:02:20Z

⌛ Testing commit 5001ee3 with merge 7db4df08bfbdba742b1a22b29624dca08dca43e5...

Manishearth · 2019-04-09T05:02:35Z

@bors p=-1 retry

rust-highfive · 2019-04-09T05:03:37Z

Your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

Cloning into 'rust-lang/rust'...
travis_time:end:084b83d8:start=1554786199489834173,finish=1554786206019781813,duration=6529947640
$ cd rust-lang/rust
$ git checkout -qf 7db4df08bfbdba742b1a22b29624dca08dca43e5
fatal: reference is not a tree: 7db4df08bfbdba742b1a22b29624dca08dca43e5
The command "git checkout -qf 7db4df08bfbdba742b1a22b29624dca08dca43e5" failed and exited with 128 during .
Your build has been stopped.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

Manishearth · 2019-04-09T05:04:01Z

@bors p=100

put it back in the queue

rust-highfive · 2019-04-09T05:04:07Z

Your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

Cloning into 'rust-lang/rust'...
travis_time:end:06c01940:start=1554786178365226558,finish=1554786184910941198,duration=6545714640
$ cd rust-lang/rust
$ git checkout -qf 16ef7dceb8d56fabe30ee019395698416a6acde4
fatal: reference is not a tree: 16ef7dceb8d56fabe30ee019395698416a6acde4
The command "git checkout -qf 16ef7dceb8d56fabe30ee019395698416a6acde4" failed and exited with 128 during .
Your build has been stopped.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

bors · 2019-04-09T06:32:21Z

⌛ Testing commit 5001ee3 with merge 930e6c487f73d18d20b548931fde0b9d5d2d7591...

bors · 2019-04-09T07:08:11Z

💔 Test failed - checks-travis

rust-highfive · 2019-04-09T07:08:11Z

Your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

 98 1444M   98 1418M    0     0  8822k      0  0:02:47  0:02:44  0:00:03 10.1M
 98 1444M   98 1429M    0     0  8837k      0  0:02:47  0:02:45  0:00:02 10.4M
 99 1444M   99 1440M    0     0  8854k      0  0:02:47  0:02:46  0:00:01 10.5M
100 1444M  100 1444M    0     0  8858k      0  0:02:47  0:02:47 --:--:-- 10.4M
No output has been received in the last 30m0s, this potentially indicates a stalled build or something wrong with the build itself.
Check the details on how to adjust your build configuration on: https://docs.travis-ci.com/user/common-build-problems/#Build-times-out-because-no-output-was-received
The build has been terminated

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

pietroalbini · 2019-04-09T10:54:11Z

@bors retry

Xanewok · 2019-04-09T10:55:55Z

cc #59810

pietroalbini · 2019-04-09T11:03:12Z

Oh, then we can close this. Thanks for pointing that PR out!

Manishearth · 2019-04-09T14:44:05Z

Looks like we're not the only ones experiencing timeouts

#58972 (comment)

rust-highfive assigned oli-obk Apr 7, 2019

Manishearth mentioned this pull request Apr 7, 2019

Update clippy #59396

Closed

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 7, 2019

Manishearth changed the title ~~Update clippy to cffb416d8951af22bc921b0f2870ddd6bb9d1104~~ Update clippy Apr 7, 2019

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 7, 2019

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 7, 2019

Manishearth mentioned this pull request Apr 7, 2019

Update compiletest rust-lang/miri#682

Merged

Manishearth force-pushed the clippyup branch from 2791dcc to 28c5bf5 Compare April 7, 2019 22:00

Manishearth added 3 commits April 7, 2019 15:24

Update clippy to 0849f73

044e5fd

Bump miri

be52aaf

Bump compiletest_rs in Cargo.lock

5001ee3

Manishearth force-pushed the clippyup branch from 28c5bf5 to 5001ee3 Compare April 7, 2019 22:25

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 7, 2019

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 9, 2019

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 9, 2019

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 9, 2019

pietroalbini closed this Apr 9, 2019

Manishearth mentioned this pull request Apr 9, 2019

Travis mac builds are slower and keep timing out #59815

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update clippy #59783

Update clippy #59783

Manishearth commented Apr 7, 2019 •

edited

Loading

rust-highfive commented Apr 7, 2019

Xanewok commented Apr 7, 2019

bors commented Apr 7, 2019

bors commented Apr 7, 2019

rust-highfive commented Apr 7, 2019

bors commented Apr 7, 2019

rust-highfive commented Apr 7, 2019

Manishearth commented Apr 7, 2019

Xanewok commented Apr 7, 2019

Manishearth commented Apr 7, 2019

Manishearth commented Apr 7, 2019

bors commented Apr 7, 2019

Centril commented Apr 8, 2019

Manishearth commented Apr 9, 2019

bors commented Apr 9, 2019

Manishearth commented Apr 9, 2019

bors commented Apr 9, 2019

rust-highfive commented Apr 9, 2019

Manishearth commented Apr 9, 2019

bors commented Apr 9, 2019

Manishearth commented Apr 9, 2019

rust-highfive commented Apr 9, 2019

Manishearth commented Apr 9, 2019

rust-highfive commented Apr 9, 2019

bors commented Apr 9, 2019

bors commented Apr 9, 2019

rust-highfive commented Apr 9, 2019

pietroalbini commented Apr 9, 2019

Xanewok commented Apr 9, 2019

pietroalbini commented Apr 9, 2019

Manishearth commented Apr 9, 2019

Update clippy #59783

Update clippy #59783

Conversation

Manishearth commented Apr 7, 2019 • edited Loading

rust-highfive commented Apr 7, 2019

Xanewok commented Apr 7, 2019

bors commented Apr 7, 2019

bors commented Apr 7, 2019

rust-highfive commented Apr 7, 2019

bors commented Apr 7, 2019

rust-highfive commented Apr 7, 2019

Manishearth commented Apr 7, 2019

Xanewok commented Apr 7, 2019

Manishearth commented Apr 7, 2019

Manishearth commented Apr 7, 2019

bors commented Apr 7, 2019

Centril commented Apr 8, 2019

Manishearth commented Apr 9, 2019

bors commented Apr 9, 2019

Manishearth commented Apr 9, 2019

bors commented Apr 9, 2019

rust-highfive commented Apr 9, 2019

Manishearth commented Apr 9, 2019

bors commented Apr 9, 2019

Manishearth commented Apr 9, 2019

rust-highfive commented Apr 9, 2019

Manishearth commented Apr 9, 2019

rust-highfive commented Apr 9, 2019

bors commented Apr 9, 2019

bors commented Apr 9, 2019

rust-highfive commented Apr 9, 2019

pietroalbini commented Apr 9, 2019

Xanewok commented Apr 9, 2019

pietroalbini commented Apr 9, 2019

Manishearth commented Apr 9, 2019

Manishearth commented Apr 7, 2019 •

edited

Loading