Added Ascii encoding, some cleanups #5980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| #[cfg(stage2)] | ||
| #[cfg(stage3)] | ||
| #[path = "str/ascii.rs"] | ||
| mod ascii; |
There was a problem hiding this comment.
I don't think this should be a sub-module of str, since it's only related to it in the same way it is to [u8] (conversion). Perhaps a top-level module in libstd?
There was a problem hiding this comment.
Yeah, could put it in a separate top-level module, It's globally imported in the prelude anyway. I'd be in favor of having at least ascii in core though (other byte encodings, codepages etc I'd put in std, though)
Removed deriving Ord, which allowed to remove the stage markers
|
Wait, no r+ yet, found a missing assert... |
|
Ready now. |
bors
added a commit
that referenced
this pull request
Apr 22, 2013
Added Ascii type to use for byte inputs that are known to contain Ascii only.
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Sep 10, 2020
Add a lint to prevent `create_dir` from being used This closes rust-lang#5950 changelog: none
calebcartwright
added a commit
to calebcartwright/rust
that referenced
this pull request
Jun 22, 2024
Subtree push 2023-12-12
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Ascii type to use for byte inputs that are known to contain Ascii only.