Fix rustdoc sidebar z-index

[Enity]

I think the screenshot will say everything:

live example: https://docs.rs/nom/4.2.3/nom/

I chose the smallest z-index to avoid problems with other blocks.

[rust-highfive]

Some changes occurred in HTML/CSS.

cc @GuillaumeGomez

[rust-highfive]

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @GuillaumeGomez (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

[jonas-schievink]

How do you get the sidebar overlap with the content? That seems like a bug.

[Enity]

How do you get the sidebar overlap with the content? That seems like a bug.

there are long blocks at the main content section (https://docs.rs/nom/4.2.3/nom/#macros).
We can customize the line break styles, but these are more breaking changes than in current mr.

By the way, the sidebar should be higher than the main content, right?

[jonas-schievink]

Oh, okay, you have to scroll sideways with a small window.

The description for "Modules" is wrapping correctly, so there must still be another bug regarding the description of macros (and potentially other things). We still might want to merge the z-index change though.

[GuillaumeGomez]

This isn't a good solution. We'd better set a max-width to the main container instead of playing with z-index.

[tesuji]

Did you refresh the cached page (with Ctrl-F5 on Firefox)?

[Enity]

I researched a little more, and found the root of the problem.

Well, there is logic in it, and the wrapped code blocks look a little worse.
But we need to find a compromise.

[GuillaumeGomez]

By adding a little spacing between two code blocks docs maybe?

[jonas-schievink]

Yes, those descriptions should wrap like other descriptions, but the docs themselves could be improved by splitting them up. If the first paragraph is too long it always looks bad when rendered.

[Enity]

This isn't a good solution. We'd better set a max-width to the main container instead of playing with z-index.

If we set the "position: fixed" and do not specify the z-index, the render priority will be determined based on the order in the DOM. Why is an explicit sidebar positioning isn't a good solution?

Yes, those descriptions should wrap like other descriptions, but the docs themselves could be improved by splitting them up. If the first paragraph is too long it always looks bad when rendered.

Changes of word-wrapping should be in another pull request, yea?

[GuillaumeGomez]

Changes of word-wrapping should be in another pull request, yea?

No, the same is fine.

[Enity]

its look fine now:

[GuillaumeGomez]

Thanks!

@bors: r+ rollup

[bors]

📌 Commit 9e17193 has been approved by GuillaumeGomez