Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify the returning of a Result a bit #60041

Merged
merged 1 commit into from
Apr 19, 2019
Merged

Simplify the returning of a Result a bit #60041

merged 1 commit into from
Apr 19, 2019

Conversation

janhohenheim
Copy link
Contributor

No description provided.

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @shepmaster (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 17, 2019
@rust-highfive
Copy link
Collaborator

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
travis_time:end:1be0d33c:start=1555511561041899128,finish=1555511563287386925,duration=2245487797
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
$ export GCP_CACHE_BUCKET=rust-lang-ci-cache
$ export AWS_ACCESS_KEY_ID=AKIA46X5W6CZEJZ6XT55
---
[00:05:13]    Compiling panic_unwind v0.0.0 (/checkout/src/libpanic_unwind)
[00:05:14] error[E0423]: expected value, found struct `File`
[00:05:14]    --> src/libstd/fs.rs:904:47
[00:05:14]     |
[00:05:14] 904 |         fs_imp::File::open(path, &self.0).map(File)
[00:05:14]     |                                               ^^^^ did you mean `File { /* fields */ }`?
[00:05:14]     |
[00:05:14] 10  | use crate::sys::unix::fs::File;
[00:05:14]     |
[00:05:14] 
---
travis_time:end:06716e32:start=1555511891775138881,finish=1555511891780816641,duration=5677760
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:09666163
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:0f698b96
travis_time:start:0f698b96
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:2b4918ac
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@shepmaster
Copy link
Member

Looks reasonable to me — please go ahead and squash those commits and we can merge this.

@janhohenheim
Copy link
Contributor Author

@shepmaster done 👍

@shepmaster
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Apr 18, 2019

📌 Commit 379c541 has been approved by shepmaster

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 18, 2019
Centril added a commit to Centril/rust that referenced this pull request Apr 18, 2019
Simplify the returning of a Result a bit
Centril added a commit to Centril/rust that referenced this pull request Apr 18, 2019
Simplify the returning of a Result a bit
Centril added a commit to Centril/rust that referenced this pull request Apr 18, 2019
Simplify the returning of a Result a bit
Centril added a commit to Centril/rust that referenced this pull request Apr 18, 2019
Simplify the returning of a Result a bit
Centril added a commit to Centril/rust that referenced this pull request Apr 18, 2019
Simplify the returning of a Result a bit
Centril added a commit to Centril/rust that referenced this pull request Apr 18, 2019
Simplify the returning of a Result a bit
Centril added a commit to Centril/rust that referenced this pull request Apr 18, 2019
Simplify the returning of a Result a bit
Centril added a commit to Centril/rust that referenced this pull request Apr 19, 2019
Simplify the returning of a Result a bit
Centril added a commit to Centril/rust that referenced this pull request Apr 19, 2019
Simplify the returning of a Result a bit
Centril added a commit to Centril/rust that referenced this pull request Apr 19, 2019
Simplify the returning of a Result a bit
Centril added a commit to Centril/rust that referenced this pull request Apr 19, 2019
Simplify the returning of a Result a bit
bors added a commit that referenced this pull request Apr 19, 2019
Rollup of 16 pull requests

Successful merges:

 - #59915 (Implement event filtering for self-profiler.)
 - #59933 (Make clear that format padding doesn't work for Debug)
 - #60023 (implement specialized nth_back() for Bytes, Fuse and Enumerate)
 - #60032 (Remove unwanted z-index change)
 - #60041 (Simplify the returning of a Result a bit)
 - #60045 (Suggest appropriate path when calling associated item on bare types)
 - #60052 (Correct unused parameter diagnostic)
 - #60056 (Update rustfmt to 1.2.1)
 - #60060 (whitelist RTM x86 target cpu feature)
 - #60061 (Change suggestion of field when not in self context)
 - #60064 (Point at try `?` on errors affecting the err match arm of the desugared code)
 - #60078 (Use more realistic example for thread builder)
 - #60080 (Fix small errors in docs for `rchunks_exact` and `rchunks_exact_mut`.)
 - #60082 (Update miri)
 - #60097 (Use -mergefunc-use-aliases for any LLVM >= 8)
 - #60098 (libcore: deny `elided_lifetimes_in_paths`)

Failed merges:

r? @ghost
@bors bors merged commit 379c541 into rust-lang:master Apr 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants