Fix broken link in rustc_plugin doc #60131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
tesuji
reviewed
Apr 28, 2019
|
r? @Centril |
|
I don't know what the policy around linking is; r? @ehuss |
|
@bors delegate=ehuss |
|
✌️ @ehuss can now approve this pull request |
|
Considering that these aren't distributed with rustup (AFAIK), and that these are only published on nightly, I'm inclined to just use the full https link. In the rare case someone is working offline, I think they'll be able to figure out what to do. @bors r+ |
|
📌 Commit f77b602 has been approved by |
bors
added
S-waiting-on-bors
|
@bors rollup |
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
May 5, 2019
Fix broken link in rustc_plugin doc fix rust-lang#57489 r? @steveklabnik
bors
added a commit
that referenced
this pull request
May 5, 2019
Rollup of 5 pull requests Successful merges: - #60131 (Fix broken link in rustc_plugin doc) - #60426 (Stop `-O`/`-C opt-level` and `-g`/`-C debuginfo` conflicting) - #60515 (use span instead of div for since version) - #60530 (rustc: rename all occurences of "freevar" to "upvar".) - #60536 (Correct code points to match their textual description) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #57489
r? @steveklabnik