Implement saturating_abs() and saturating_neg() functions for signed integer types #60192
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
rust-highfive
added
the
S-waiting-on-review
|
Please add some tests (especially the corner cases of course) in |
src/libcore/num/mod.rs
Outdated
| $EndFeature, " | ||
| ```"), | ||
|
|
||
| #[unstable(feature = "saturating_neg", issue = "0")] |
There was a problem hiding this comment.
Do we want to make #59983 the tracking issue or is a seperate issue desired?
There was a problem hiding this comment.
My idea was to put the issue ID of this PR therein. If using #59983 is preferred I will happily use that.
There was a problem hiding this comment.
This was more a question to the reviewer. I'm not a core member and therefore cannot decide whether to use 0 for the moment or the Issue. But a trackig issue is always an issue number, never a PR.
|
Thanks for the PR! I agree with @hellow554 that with some tests this is likely good to go! For tracking issues we can either reuse the existing issue (and keep it open after this PR merges) or you can open a dedicated new issue for tracking these APIs, up to you! |
|
Have added tests. I think we can use issue #59983 for tracking. Do I need to remove the "Fixes" line in the commit message so the tracking issue does not close? And what about merging trivial commit a616f10 into fc6272a ? |
either that or you manually reopen the issue afterwards ^^ (please somebody correct me if I'm wrong) |
|
It seems I somehow managed to screw up the force-push as now commit |
|
Go back to the commit you started by using |
… types Similar to wrapping_abs() / wrapping_neg() functions but saturating at the numeric bounds instead of wrapping around. Complements the existing set of functions with saturation mechanics.
|
Thanks a lot for the hints! The PR looks good now, I think. |
|
📌 Commit c7d47c8 has been approved by |
bors
added
S-waiting-on-bors
Implement saturating_abs() and saturating_neg() functions for signed integer types Similar to wrapping_abs() / wrapping_neg() functions but saturating at the numeric bounds instead of wrapping around. Complements the existing set of functions with saturation mechanics. cc #59983
|
☀️ Test successful - checks-travis, status-appveyor |
Similar to wrapping_abs() / wrapping_neg() functions but saturating at the numeric bounds instead of wrapping around. Complements the existing set of functions with saturation mechanics.
cc #59983