-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add extended information for E0594 #60193
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @steveklabnik (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
You need to update tests as well. |
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
Is there a good way to run just the failing doc specs (or at least a smaller number of them)? |
E0594 is not specific to statics (playground producing it without any statics). |
Yeah you're right Denis. This definitely needs work, I might have a bit more of a play and see if I can work out a better way to write this–it may be out of my level of knowledge though. If I don't get to it soon I'll close the PR. |
ping from triage @twe4ked any updates on this? |
Thanks for the ping. I'm not really sure where to take it from here and I know now that there is potentially bunch of information looking. Sorry! |
Thanks!
r? @steveklabnik