Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stabilize str::as_mut_ptr #60356

Merged
merged 1 commit into from
Apr 29, 2019
Merged

Stabilize str::as_mut_ptr #60356

merged 1 commit into from
Apr 29, 2019

Conversation

JohnTitor
Copy link
Member

Closes #58215

@rust-highfive
Copy link
Collaborator

r? @Mark-Simulacrum

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 28, 2019
@jonas-schievink jonas-schievink added the relnotes Marks issues that should be documented in the release notes of the next release. label Apr 28, 2019
@jonas-schievink jonas-schievink added this to the 1.36 milestone Apr 28, 2019
@Mark-Simulacrum
Copy link
Member

r? @alexcrichton

@Centril
Copy link
Contributor

Centril commented Apr 28, 2019

r? @Centril @bors r+ rollup

@bors
Copy link
Contributor

bors commented Apr 28, 2019

📌 Commit 4c0f01c has been approved by Centril

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 28, 2019
@Centril Centril added the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label Apr 28, 2019
@Centril
Copy link
Contributor

Centril commented Apr 28, 2019

FCP completed in #58215.

Centril added a commit to Centril/rust that referenced this pull request Apr 28, 2019
@Centril
Rollup merge of rust-lang#60356 - JohnTitor:stabilize-as-mut-ptr, r=C…
6c22d4f 
…entril

Stabilize str::as_mut_ptr

Closes rust-lang#58215
@Centril Centril mentioned this pull request Apr 28, 2019
Closed
Centril added a commit to Centril/rust that referenced this pull request Apr 29, 2019
@Centril
Rollup merge of rust-lang#60356 - JohnTitor:stabilize-as-mut-ptr, r=C…
c9b7014 
…entril

Stabilize str::as_mut_ptr

Closes rust-lang#58215
@Centril Centril mentioned this pull request Apr 29, 2019
Merged
bors added a commit that referenced this pull request Apr 29, 2019
@bors
Auto merge of #60377 - Centril:rollup-42fxe9u, r=Centril
00859e3 
Rollup of 9 pull requests

Successful merges:

 - #59946 (Fix equivalent string in escape_default docs)
 - #60256 (Option::flatten)
 - #60305 (hir: remove LoweredNodeId)
 - #60334 (Stabilized vectored IO)
 - #60353 (Add test not to forget resolved ICE)
 - #60356 (Stabilize str::as_mut_ptr)
 - #60358 (Clarify the short explanation of E0207)
 - #60359 (resolve: Consider erroneous imports used to avoid duplicate diagnostics)
 - #60360 (Add test case for labeled break in const assignment)

Failed merges:

r? @ghost
@bors bors merged commit 4c0f01c into rust-lang:master Apr 29, 2019
@JohnTitor JohnTitor deleted the stabilize-as-mut-ptr branch April 30, 2019 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Centril Centril

Labels
relnotes Marks issues that should be documented in the release notes of the next release. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.36
Development

Successfully merging this pull request may close these issues.

Tracking issue for str::as_mut_ptr
7 participants
@JohnTitor @rust-highfive @Mark-Simulacrum @Centril @bors @alexcrichton @jonas-schievink