Require a trait in the bounds of existential types #60409

JohnTitor · 2019-04-30T11:48:36Z

Fixes #53090

r? @oli-obk

src/test/ui/existential_types/existential-types-with-no-traits.stderr

oli-obk · 2019-04-30T12:48:31Z

@bors r+

Thanks!

bors · 2019-04-30T12:48:32Z

📌 Commit db7f265 has been approved by oli-obk

@oli-obk

…e, r=oli-obk Require a trait in the bounds of existential types Fixes rust-lang#53090 r? @oli-obk

@oli-obk

…e, r=oli-obk Require a trait in the bounds of existential types Fixes rust-lang#53090 r? @oli-obk

@oli-obk

…e, r=oli-obk Require a trait in the bounds of existential types Fixes rust-lang#53090 r? @oli-obk

rust-highfive · 2019-04-30T13:51:46Z

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

travis_time:end:273f9690:start=1556627412079245594,finish=1556627416078293462,duration=3999047868
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
$ export GCP_CACHE_BUCKET=rust-lang-ci-cache
$ export AWS_ACCESS_KEY_ID=AKIA46X5W6CZEJZ6XT55
---
[01:14:57] .................................................................................................... 300/2958
[01:15:09] .................................................................................................... 400/2958
[01:15:18] .................................................................................................... 500/2958
[01:15:30] .................................................................................................... 600/2958
[01:15:45] ..........................................................................F......................... 700/2958
[01:16:06] .................................................................................................... 900/2958
[01:16:22] .................................................................................................... 1000/2958
[01:16:36] .................................................................................................... 1100/2958
[01:16:46] .................................................................................................... 1200/2958
---
[01:21:14] failures:
[01:21:14] 
[01:21:14] ---- [run-pass] run-pass/existential_type.rs stdout ----
[01:21:14] 
[01:21:14] error: test compilation failed although it shouldn't!
[01:21:14] status: exit code: 1
[01:21:14] command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/run-pass/existential_type.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-pass/existential_type/a" "-Crpath" "-O" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-pass/existential_type/auxiliary"
[01:21:14] ------------------------------------------
[01:21:14] 
[01:21:14] ------------------------------------------
[01:21:14] stderr:
[01:21:14] stderr:
[01:21:14] ------------------------------------------
[01:21:14] error: at least one trait must be specified
[01:21:14]   --> /checkout/src/test/run-pass/existential_type.rs:71:46
[01:21:14]    |
[01:21:14] LL | existential type GenericBound<'a, T: Trait>: 'a;
[01:21:14] 
[01:21:14] error: at least one trait must be specified
[01:21:14]   --> /checkout/src/test/run-pass/existential_type.rs:78:42
[01:21:14]    |
[01:21:14]    |
[01:21:14] LL |     pub existential type Passthrough<T>: 'static;
[01:21:14] 
[01:21:14] error: aborting due to 2 previous errors
[01:21:14] 
[01:21:14] 
---
[01:21:14] thread 'main' panicked at 'Some tests failed', src/tools/compiletest/src/main.rs:517:22
[01:21:14] note: Run with `RUST_BACKTRACE=1` environment variable to display a backtrace.
[01:21:14] 
[01:21:14] 
[01:21:14] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/run-pass" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-pass" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "run-pass" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-6.0/bin/FileCheck" "--host-rustcflags" "-Crpath -O -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--target-rustcflags" "-Crpath -O -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--quiet" "--llvm-version" "6.0.0\n" "--system-llvm" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--llvm-cxxflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
[01:21:14] 
[01:21:14] 
[01:21:14] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
[01:21:14] Build completed unsuccessfully in 0:11:27
[01:21:14] Build completed unsuccessfully in 0:11:27
[01:21:14] Makefile:48: recipe for target 'check' failed
[01:21:14] make: *** [check] Error 1
The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:15066535
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
Tue Apr 30 13:51:39 UTC 2019
---
travis_time:end:0365b980:start=1556632301362664943,finish=1556632301367669463,duration=5004520
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:0ac76e6a
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

JohnTitor · 2019-04-30T13:56:54Z

Oops, I didn't check the run-pass tests. Will fix them.

Centril · 2019-04-30T14:09:04Z

@bors r- meanwhile.

JohnTitor · 2019-04-30T14:41:41Z

@oli-obk Could we remove these lines, or should fix? (These are no longer run-pass.)

rust/src/test/run-pass/existential_type.rs

Lines 70 to 87 in f843ad6

    
           trait Trait {} 
        
           existential type GenericBound<'a, T: Trait>: 'a; 
        
           fn generic_bound<'a, T: Trait + 'a>(t: T) -> GenericBound<'a, T> { 
        
               t 
        
           } 
        
           mod pass_through { 
        
               pub existential type Passthrough<T>: 'static; 
        
               fn define_passthrough<T: 'static>(t: T) -> Passthrough<T> { 
        
                   t 
        
               } 
        
           } 
        
           fn use_passthrough(x: pass_through::Passthrough<u32>) -> pass_through::Passthrough<u32> { 
        
               x 
        
           }

oli-obk · 2019-04-30T15:17:02Z

@JohnTitor keep them as run-pass, but change the bounds to Sized + 'a or Sized + 'static respectively, which will amount to the same thing that we had before and should the tests compile.

JohnTitor · 2019-04-30T15:38:09Z

Thank you @oli-obk! I fixed them.

JohnTitor · 2019-04-30T19:10:13Z

Travis with green

oli-obk · 2019-05-02T09:30:06Z

@bors r+

Thanks!

bors · 2019-05-02T09:30:07Z

📌 Commit 748d978 has been approved by oli-obk

@oli-obk

…e, r=oli-obk Require a trait in the bounds of existential types Fixes rust-lang#53090 r? @oli-obk

@oli-obk

…e, r=oli-obk Require a trait in the bounds of existential types Fixes rust-lang#53090 r? @oli-obk

@ghost

Rollup of 12 pull requests Successful merges: - #59928 (Make deprecation lint `ambiguous_associated_items` deny-by-default) - #60220 (report fatal errors during doctest parsing) - #60373 (Tidy: ensure lang features are sorted by since) - #60388 (Disallow non-explicit elided lifetimes in async fn) - #60393 ( Do not suggest incorrect syntax on pattern type error due to borrow) - #60401 (Rename `RUST_LOG` to `RUSTC_LOG`) - #60409 (Require a trait in the bounds of existential types) - #60455 (Resolve match arm ty when arms diverge) - #60457 (Const prop refactoring) - #60467 (Avoid repeated interning of static strings.) - #60478 (minor compiler doc tweaks) - #60501 (Propagate mutability from arguments to local bindings in async fn) Failed merges: r? @ghost

JohnTitor added 2 commits April 30, 2019 20:43

Add error for existential types

da46eea

Fix tests

bb3549f

rust-highfive assigned oli-obk Apr 30, 2019

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 30, 2019

oli-obk reviewed Apr 30, 2019

View reviewed changes

src/test/ui/existential_types/existential-types-with-no-traits.stderr Show resolved Hide resolved

JohnTitor added 2 commits April 30, 2019 21:28

Use multispan

f56d285

Fix spans

db7f265

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 30, 2019

Centril added a commit to Centril/rust that referenced this pull request Apr 30, 2019

Rollup merge of rust-lang#60409 - JohnTitor:error-for-existential-typ…

eccb332

…e, r=oli-obk Require a trait in the bounds of existential types Fixes rust-lang#53090 r? @oli-obk

Centril mentioned this pull request Apr 30, 2019

Rollup of 5 pull requests #60410

Closed

Centril added a commit to Centril/rust that referenced this pull request Apr 30, 2019

Rollup merge of rust-lang#60409 - JohnTitor:error-for-existential-typ…

77296e8

…e, r=oli-obk Require a trait in the bounds of existential types Fixes rust-lang#53090 r? @oli-obk

Centril mentioned this pull request Apr 30, 2019

Rollup of 6 pull requests #60411

Closed

Centril added a commit to Centril/rust that referenced this pull request Apr 30, 2019

Rollup merge of rust-lang#60409 - JohnTitor:error-for-existential-typ…

28f09a2

…e, r=oli-obk Require a trait in the bounds of existential types Fixes rust-lang#53090 r? @oli-obk

Centril mentioned this pull request Apr 30, 2019

Rollup of 7 pull requests #60412

Closed

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 30, 2019

Fix run-pass test

748d978

bors removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label May 2, 2019

bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label May 2, 2019

Centril added a commit to Centril/rust that referenced this pull request May 2, 2019

Rollup merge of rust-lang#60409 - JohnTitor:error-for-existential-typ…

6e7bcff

…e, r=oli-obk Require a trait in the bounds of existential types Fixes rust-lang#53090 r? @oli-obk

Centril mentioned this pull request May 2, 2019

Rollup of 11 pull requests #60488

Closed

Centril added a commit to Centril/rust that referenced this pull request May 3, 2019

Rollup merge of rust-lang#60409 - JohnTitor:error-for-existential-typ…

f622861

…e, r=oli-obk Require a trait in the bounds of existential types Fixes rust-lang#53090 r? @oli-obk

Centril mentioned this pull request May 3, 2019

Rollup of 12 pull requests #60510

Merged

bors merged commit 748d978 into rust-lang:master May 3, 2019

JohnTitor deleted the error-for-existential-type branch May 3, 2019 18:21

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Require a trait in the bounds of existential types #60409

Require a trait in the bounds of existential types #60409

JohnTitor commented Apr 30, 2019

oli-obk commented Apr 30, 2019

bors commented Apr 30, 2019

rust-highfive commented Apr 30, 2019

JohnTitor commented Apr 30, 2019

Centril commented Apr 30, 2019

JohnTitor commented Apr 30, 2019 •

edited

Loading

oli-obk commented Apr 30, 2019

JohnTitor commented Apr 30, 2019

JohnTitor commented Apr 30, 2019

oli-obk commented May 2, 2019

bors commented May 2, 2019

Require a trait in the bounds of existential types #60409

Require a trait in the bounds of existential types #60409

Conversation

JohnTitor commented Apr 30, 2019

oli-obk commented Apr 30, 2019

bors commented Apr 30, 2019

rust-highfive commented Apr 30, 2019

JohnTitor commented Apr 30, 2019

Centril commented Apr 30, 2019

JohnTitor commented Apr 30, 2019 • edited Loading

oli-obk commented Apr 30, 2019

JohnTitor commented Apr 30, 2019

JohnTitor commented Apr 30, 2019

oli-obk commented May 2, 2019

bors commented May 2, 2019

JohnTitor commented Apr 30, 2019 •

edited

Loading