Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix search sidebar width when no crate select is present #60487

Merged

Conversation

GuillaumeGomez
Copy link
Member

Fixes #60480.

I also fixed the box-shadow that seemed to have been kind of removed?

r? @QuietMisdreavus

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 2, 2019
@QuietMisdreavus
Copy link
Member

Can you add a screenshot with your changes?

@QuietMisdreavus
Copy link
Member

cc @rust-lang/rustdoc in case i drop this review

@GuillaumeGomez
Copy link
Member Author

Sure!

Screenshot from 2019-05-03 10-17-09

@Dylan-DPC-zz
Copy link

bors: r+

@Dylan-DPC-zz
Copy link

meh

@bors: r+

@bors
Copy link
Contributor

bors commented May 20, 2019

📌 Commit e2a2500 has been approved by Dylan-DPC

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 20, 2019
Centril added a commit to Centril/rust that referenced this pull request May 20, 2019
…idth-colors, r=Dylan-DPC

Fix search sidebar width when no crate select is present

Fixes rust-lang#60480.

I also fixed the box-shadow that seemed to have been kind of removed?

r? @QuietMisdreavus
bors added a commit that referenced this pull request May 20, 2019
Rollup of 11 pull requests

Successful merges:

 - #60383 (Fix position source code files toggle)
 - #60453 (Fall back to `/dev/urandom` on `EPERM` for `getrandom`)
 - #60487 (Fix search sidebar width when no crate select is present)
 - #60511 (Fix intra-doc link resolution failure on re-exporting libstd)
 - #60823 (Fix incremental compilation of cdylib emitting spurious unused_attributes lint)
 - #60915 (stable hashing: Remove unused field and add documentation.)
 - #60942 (Misc changes to rustc_metadata)
 - #60952 (Document BinaryHeap time complexity)
 - #60959 (rustc: Improve type size assertions)
 - #60972 (remove confusing remarks about mixed volatile and non-volatile accesses)
 - #60983 (Set -funwind-tables and -fno-exceptions unconditionally for LLVM's libunwind)

Failed merges:

r? @ghost
@bors bors merged commit e2a2500 into rust-lang:master May 21, 2019
@GuillaumeGomez GuillaumeGomez deleted the fix-search-sidebar-width-colors branch May 21, 2019 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Search bar should take all width when no select is alongside (when just one crate is documented)
5 participants