Only hash dep node indices of deps of anon tasks #60573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
| @@ -1021,25 +1021,17 @@ impl CurrentDepGraph { | |||
| fn complete_anon_task(&mut self, kind: DepKind, task_deps: TaskDeps) -> DepNodeIndex { | |||
| debug_assert!(!kind.is_eval_always()); | |||
|
|
|||
| let mut fingerprint = self.anon_id_seed; | |||
There was a problem hiding this comment.
Can you add a comment explaining why this works? Especially why it is OK to stable-hash unstable data like DepNodeIndex values?
|
@bors try |
bors
added a commit
that referenced
this pull request
May 6, 2019
Only hash dep node indices of deps of anon tasks Another change split out from #60035. r? @michaelwoerister
|
📌 Commit 97d3ad0 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
May 7, 2019
Only hash dep node indices of deps of anon tasks Another change split out from #60035. r? @michaelwoerister
|
☀️ Test successful - checks-travis, status-appveyor |
|
Looks like this did not make much of a difference: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another change split out from #60035.
r? @michaelwoerister