Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Symbol more #60630

Merged
merged 5 commits into from
May 13, 2019
Merged

Use Symbol more #60630

merged 5 commits into from
May 13, 2019

Commits on May 12, 2019

  1. Add lots of static Symbols. 

    These will be used in the subsequent commits. Many of them are
attributes.

The commit also adds the ability to handle symbols that aren't
identifiers (e.g. "proc-macro").
    @nnethercote
    nnethercote committed May 12, 2019
    Configuration menu
    Copy the full SHA
    a8245f5 View commit details
    Browse the repository at this point in the history

  2. Rename syntax::symbol::symbols as syntax::symbol::sym. 

    Because it's going to be used a lot.
    @nnethercote
    nnethercote committed May 12, 2019
    Configuration menu
    Copy the full SHA
    79602c8 View commit details
    Browse the repository at this point in the history

  3. Pass a Symbol to check_name, emit_feature_err, and related func… 

    …tions.
    @nnethercote
    nnethercote committed May 12, 2019
    Configuration menu
    Copy the full SHA
    fb084a4 View commit details
    Browse the repository at this point in the history

  4. Remove the equality operation between Symbol and strings. 

    And also the equality between `Path` and strings, because `Path` is made
up of `Symbol`s.
    @nnethercote
    nnethercote committed May 12, 2019
    Configuration menu
    Copy the full SHA
    999c1fc View commit details
    Browse the repository at this point in the history

  5. Return a Symbol from name_or_empty functions.

    @nnethercote
    nnethercote committed May 12, 2019
    Configuration menu
    Copy the full SHA
    ea9fac5 View commit details
    Browse the repository at this point in the history