Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 5 pull requests #60646

Closed
wants to merge 10 commits into from
Closed

Commits on May 5, 2019

  1. to_xe_bytes for isize and usize returns an array of different size

    ... on different platforms.
    
    Official rustdoc of
    [`usize::to_le_bytes`](https://doc.rust-lang.org/std/primitive.usize.html#method.to_le_bytes)
    displays signature
    
    ```
    pub fn to_ne_bytes(self) -> [u8; 8]
    ```
    
    which might be misleading: this function returns 4 bytes on 32-bit
    systems.
    stepancheg committed May 5, 2019
    Configuration menu
    Copy the full SHA
    764e366 View commit details
    Browse the repository at this point in the history

Commits on May 7, 2019

  1. Add test for rust-lang#59972

    tmandry committed May 7, 2019
    Configuration menu
    Copy the full SHA
    2e789b9 View commit details
    Browse the repository at this point in the history

Commits on May 8, 2019

  1. test for rust-lang#50518

    It was fixed somewhere between 1.28.0 and 1.31.1
    
    closes rust-lang#50518
    matklad committed May 8, 2019
    Configuration menu
    Copy the full SHA
    c87d2cc View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    47768b2 View commit details
    Browse the repository at this point in the history
  3. std: Update compiler-builtins crate

    Pulls in a fix for ensuring that wasm targets have code in
    compiler-builtins for `ldexp` which LLVM can generate references to.
    alexcrichton committed May 8, 2019
    Configuration menu
    Copy the full SHA
    7e80355 View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#59979 - stepancheg:num-size, r=ehuss

    to_xe_bytes for isize and usize returns an array of different size
    
    ... on different platforms.
    
    Official rustdoc of
    [`usize::to_le_bytes`](https://doc.rust-lang.org/std/primitive.usize.html#method.to_le_bytes)
    displays signature
    
    ```
    pub fn to_ne_bytes(self) -> [u8; 8]
    ```
    
    which might be misleading: this function returns 4 bytes on 32-bit
    systems.
    
    With this commit applied rustdoc for `isize` and `usize` is this:
    <img width="740" alt="2019-04-15_0020" src="https://user-images.githubusercontent.com/28969/56100765-9f69b380-5f14-11e9-974c-daa25edaa881.png">
    Centril authored May 8, 2019
    Configuration menu
    Copy the full SHA
    50b5e0a View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#60491 - alexcrichton:update-cb, r=nikomatsakis

    std: Update compiler-builtins crate
    
    Pulls in a fix for ensuring that wasm targets have code in
    compiler-builtins for `ldexp` which LLVM can generate references to.
    Centril authored May 8, 2019
    Configuration menu
    Copy the full SHA
    2ace070 View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#60572 - tmandry:issue-59972, r=RalfJung,oli…

    …-obk
    
    Add test for rust-lang#59972
    
    This PR adds a test for rust-lang#59972, which was fixed in rust-lang#59897.
    
    Closes rust-lang#59972.
    
    r? @eddyb
    Centril authored May 8, 2019
    Configuration menu
    Copy the full SHA
    e96e81a View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#60627 - matklad:test, r=estebank

    test for rust-lang#50518
    
    It was fixed somewhere between 1.28.0 and 1.31.1
    
    closes rust-lang#50518
    
    r? @estebank
    
    Where's the best place to add this test? I *think* we want "compile-pass" for this test (no need to run a binary, and not running saves us a millisecond of process creation) , but there's no compile-pass anymore.
    
    Should this be UI test with empty stdout, stderr and zero return code?
    Centril authored May 8, 2019
    Configuration menu
    Copy the full SHA
    124b58a View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#60634 - Centril:lang-items-docs, r=oli-obk

    Document + Cleanup lang_items.rs
    
    Byproduct of work on rust-lang#60607.
    
    r? @oli-obk
    Centril authored May 8, 2019
    Configuration menu
    Copy the full SHA
    dd71238 View commit details
    Browse the repository at this point in the history