[beta] Permit unwinding through FFI by default #60716
Conversation
|
rust-highfive
added
the
S-waiting-on-review
|
#58794 does not seem much closer to being resolved than last time, so perhaps we should also land this on master? (now people are seemingly waiting for an RFC being written, so this might take a long time to be resolved) |
|
I asked that in #58794 (comment) to no response. 😐 |
|
@BatmanAoD unrelated, but try to push that rfc on your own fork instead of the main repo if possible. |
|
I think we should land this on master as well to get beta back in sync with nightly. Cc @rust-lang/lang @bors r+ |
|
📌 Commit 49d6416 has been approved by |
bors
added
S-waiting-on-bors
|
💡 This pull request was already approved, no need to approve it again.
|
|
📌 Commit 49d6416 has been approved by |
|
@pietroalbini Yes, I felt prettyffoolish when I realized I hadn't forked, and even more so when I found that my branch is one of only three in the main repo. I've already opened the PR, though; should I close it and re-open it? |
|
@Centril ^? |
|
I'm not really happy about landing on master as I think the pressure (and constant reminder) to remove the soundness hole is a good thing, but at the same time it adds a plenty of more work... so I leave it up to you. |
Nah... just adds churn, and the discussion has already started. |
|
@bors p=1 rollup=never |
…lacrum [beta] Permit unwinding through FFI by default This repeats #59640 for Rust 1.35, as #58794 is not yet resolved. cc @rust-lang/release r? @Mark-Simulacrum
|
☀️ Test successful - checks-travis, status-appveyor |
This repeats #59640 for Rust 1.35, as #58794 is not yet resolved.
cc @rust-lang/release
r? @Mark-Simulacrum