Remove bitrig support from rust #60775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
|
Ping @joshtriplett . Are you having time for this or should I choose another reviewer? |
|
On May 14, 2019 1:50:35 AM PDT, Marcel Hellwig ***@***.***> wrote:
Ping @joshtriplett . Are you having time for this or should I choose
another reviewer?
Looks generally reasonable to me. r=me if it passes CI. Currently traveling, though, so feel free to pick another reviewer.
|
|
Happy traveling then :) @bors r=joshtriplett |
|
@hellow554: 🔑 Insufficient privileges: Not in reviewers |
|
@bors r=joshtriplett |
|
📌 Commit cc314b0 has been approved by |
bors
added
the
S-waiting-on-bors
|
@bors rollup=never |
bors
added a commit
that referenced
this pull request
May 15, 2019
Remove bitrig support from rust Resolves #60743 using `find` and `rg` I delete every occurence of "bitrig" in the sources, expect for the llvm submodule (is this correct?). There's also this file https://github.com/rust-lang/rls/blob/5b8e99bb61958ca8abcb7c5eda70521726be1065/rls-analysis/test_data/rust-analysis/libstd-af9bacceee784405.json which contains a bitrig string in it. What to do with that?
|
☀️ Test successful - checks-travis, status-appveyor |
gnzlbg
added a commit
to gnzlbg/libc
that referenced
this pull request
May 16, 2019
gnzlbg
added a commit
to gnzlbg/libc
that referenced
this pull request
May 16, 2019
hellow554
added a commit
to hellow554/reference
that referenced
this pull request
Jun 7, 2019
Bitrig support has been removed (by me) in rust-lang/rust#60775
hellow554
added a commit
to hellow554/rustfmt
that referenced
this pull request
Jun 7, 2019
bitrig support has been removed (by me) in rust-lang/rust#60775
topecongiro
pushed a commit
to rust-lang/rustfmt
that referenced
this pull request
Jun 7, 2019
bitrig support has been removed (by me) in rust-lang/rust#60775
ehuss
added a commit
to ehuss/rust-forge
that referenced
this pull request
May 15, 2020
Bitrig support was removed in rust-lang/rust#60775.
Havvy
pushed a commit
to Havvy/reference
that referenced
this pull request
Aug 25, 2020
Bitrig support has been removed (by me) in rust-lang/rust#60775
lambda-fairy
added a commit
to lambda-fairy/rust-errno
that referenced
this pull request
Aug 14, 2024
Bitrig support was removed upstream in rust-lang/rust#60775. From the [merge commit][1] it landed in 1.36.0 which is long before our MSRV of Rust 1.56. [1]: rust-lang/rust@c84a7ab
lambda-fairy
added a commit
to lambda-fairy/rust-errno
that referenced
this pull request
Aug 14, 2024
Bitrig support was removed upstream in rust-lang/rust#60775. From the [merge commit][1] it landed in 1.36.0 which is long before our MSRV of Rust 1.56. This also fixes the `unexpected_cfgs` warning. [1]: rust-lang/rust@c84a7ab
This was referenced Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #60743
using
findandrgI delete every occurence of "bitrig" in the sources, expect for the llvm submodule (is this correct?).There's also this file https://github.com/rust-lang/rls/blob/5b8e99bb61958ca8abcb7c5eda70521726be1065/rls-analysis/test_data/rust-analysis/libstd-af9bacceee784405.json which contains a bitrig string in it. What to do with that?