Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lexer: Disallow bare CR in raw byte strings #60793

Merged
merged 11 commits into from
Jun 11, 2019
Merged

lexer: Disallow bare CR in raw byte strings #60793

merged 11 commits into from
Jun 11, 2019

Commits on Jun 8, 2019

  1. Clean up minor bits

    @Xanewok
    Xanewok committed Jun 8, 2019
    Configuration menu
    Copy the full SHA
    5b17a5e View commit details
    Browse the repository at this point in the history

  2. Separate a scan_raw_string (similar raw_byte variant)

    @Xanewok
    Xanewok committed Jun 8, 2019
    Configuration menu
    Copy the full SHA
    b8e3533 View commit details
    Browse the repository at this point in the history

  3. Remove redundant, commented out code 

    It was commented out as part of
rust-lang@8a8e497.
Done probably by accident, since the code in question was moved to a
match arm, along with newly introduced logic to detect bare CRs in raw
strings.
    @Xanewok
    Xanewok committed Jun 8, 2019
    Configuration menu
    Copy the full SHA
    08ede49 View commit details
    Browse the repository at this point in the history

  4. Validate and transcribe raw strings via unescape module

    @Xanewok
    Xanewok committed Jun 8, 2019
    Configuration menu
    Copy the full SHA
    cab7e7f View commit details
    Browse the repository at this point in the history

  5. Prohibit bare CRs in raw byte strings

    @Xanewok
    Xanewok committed Jun 8, 2019
    Configuration menu
    Copy the full SHA
    49d62e8 View commit details
    Browse the repository at this point in the history

  6. Translate CRLF -> LF in raw (byte) strings

    @Xanewok
    Xanewok committed Jun 8, 2019
    Configuration menu
    Copy the full SHA
    d463274 View commit details
    Browse the repository at this point in the history

Commits on Jun 9, 2019

  1. Add test for raw byte CRLF translation

    @Xanewok
    Xanewok committed Jun 9, 2019
    Configuration menu
    Copy the full SHA
    8cd51ff View commit details
    Browse the repository at this point in the history

  2. Add a doc comment for scan_raw_string

    @Xanewok
    Xanewok committed Jun 9, 2019
    Configuration menu
    Copy the full SHA
    3c1d352 View commit details
    Browse the repository at this point in the history

  3. Actually translate CRLF in raw byte strings and unify unescape impl

    @Xanewok
    Xanewok committed Jun 9, 2019
    Configuration menu
    Copy the full SHA
    735ac05 View commit details
    Browse the repository at this point in the history

  4. Use char byte calculation using existing iterator

    @Xanewok
    Xanewok committed Jun 9, 2019
    Configuration menu
    Copy the full SHA
    63dc7da View commit details
    Browse the repository at this point in the history

Commits on Jun 10, 2019

  1. Don't suggest using \r in raw strings

    @Xanewok
    Xanewok committed Jun 10, 2019
    Configuration menu
    Copy the full SHA
    630d5f3 View commit details
    Browse the repository at this point in the history