Move gensym operations from Symbol to Ident
#60903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
src/libsyntax_pos/symbol.rs
Outdated
| @@ -613,10 +613,12 @@ pub struct Ident { | |||
|
|
|||
| impl Ident { | |||
| #[inline] | |||
| /// constructs a new identifier from a symbol and a span. | |||
There was a problem hiding this comment.
Suggested change
| /// constructs a new identifier from a symbol and a span. | |
| /// Constructs a new identifier from a symbol and a span. |
|
r=me after rebase |
petrochenkov
added
S-waiting-on-author
nnethercote
force-pushed
the
mv-gensyms-from-Symbol-to-Ident
branch
from
17b5966
to
ad5dd49
Compare
|
@bors try |
bors
added a commit
that referenced
this pull request
May 19, 2019
…=<try> Move gensym operations from `Symbol` to `Ident` Gensyms are always at the `Ident` level, and long-term we probably want to record gensym-ness in hygiene data. r? @petrochenkov
nnethercote
force-pushed
the
mv-gensyms-from-Symbol-to-Ident
branch
from
ad5dd49
to
8a96f26
Compare
|
☔ The latest upstream changes (presumably #60969) made this pull request unmergeable. Please resolve the merge conflicts. |
Note that the `is_gensymed` call on `primitive_types` is unnecessary because that table only contains the name of primitive types (e.g. `i32`) and never contains gensyms.
nnethercote
force-pushed
the
mv-gensyms-from-Symbol-to-Ident
branch
from
8a96f26
to
88d2999
Compare
|
@bors try |
bors
added a commit
that referenced
this pull request
May 20, 2019
…=<try> Move gensym operations from `Symbol` to `Ident` Gensyms are always at the `Ident` level, and long-term we probably want to record gensym-ness in hygiene data. r? @petrochenkov
|
☀️ Try build successful - checks-travis |
|
@rust-timer build e67ebe6 |
|
Success: Queued e67ebe6 with parent 128b4c8, comparison URL. |
|
Finished benchmarking try commit e67ebe6: comparison url |
|
It's a slight performance regression, but I think it's necessary to take at some point in order to move gensym-ness away from symbols. We've had a bunch of significantly larger performance improvements related to symbol handling recently, which more than make up for this. @bors r=petrochenkov |
|
📌 Commit 88d2999 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
May 21, 2019
…=petrochenkov Move gensym operations from `Symbol` to `Ident` Gensyms are always at the `Ident` level, and long-term we probably want to record gensym-ness in hygiene data. r? @petrochenkov
|
☀️ Test successful - checks-travis, status-appveyor |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gensyms are always at the
Identlevel, and long-term we probably want to record gensym-ness in hygiene data.r? @petrochenkov