rand: Fix infinite recursion #6097
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`self` has type `&@Rand`, so `*self` will be of type `@Rand` which causes this same impl to be called again.
|
This may also fix #6049 |
|
Well it worked when I made the same change |
|
I'll skip verifying locally (which is what I was holding up on) since it sounds like at least one person who was having the same problem has validated that this fixes the bootstrapping issue. r+ |
bors
added a commit
that referenced
this pull request
Apr 28, 2013
`self` has type `&@Rand`, so `*self` will be of type `@Rand` which causes this same impl to be called again. Fixes #6061
|
Could rustc identity this and either warn or forbid? |
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Dec 6, 2020
add configuration option for minimum supported rust version add msrv attribute to some lints listed in rust-lang#6097 add tests
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Dec 6, 2020
Add support for minimum supported rust version add configuration option for minimum supported rust version add msrv attribute to some lints listed in rust-lang#6097 add tests addresses rust-lang#6097 changelog: Add `msrv` configuration to Clippy. This should get a longer changelog entry.
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Dec 6, 2020
update readme for specifying msrv changelog: add some documentation for the `msrv` feature (rust-lang#6097) related PR: rust-lang/rust-clippy#6201
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Dec 20, 2020
update tests
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Dec 20, 2020
Add MSRV to more lints specified in rust-lang#6097 add MSRV to more lints specified in rust-lang#6097 add instructions for adding msrv in other lints update tests - [x] `redundant_field_names` requires Rust 1.17 due to suggest feature stablized in that version. - [x] `redundant_static_lifetimes` requires Rust 1.17 due to suggest feature stablized in that version. - [x] `filter_map_next` requires Rust 1.30 due to suggest `Iterator::find_map`. - [x] `checked_conversions` requires Rust 1.34 due to suggest `TryFrom`. - [x] `match_like_matches_macro` requires Rust 1.42 due to suggest `matches!`. Addressed in rust-lang#6201 - [x] `manual_strip` requires Rust 1.45 due to suggest `str::{strip_prefix, strip_suffix}`. Addressed in rust-lang#6201 - [x] `option_as_ref_deref` requires Rust 1.40 due to suggest `Option::{as_deref, as_deref_mut}`. Addressed in rust-lang#6201 - [x] `manual_non_exhaustive` requires Rust 1.40 due to suggest `#[non_exhaustive]`. Addressed in rust-lang#6201 - [x] `manual_range_contains` requires Rust 1.35 due to suggest `Range*::contains`. - [x] `use_self` requires Rust 1.37 due to suggest `Self::Variant on enum`. - [x] `mem_replace_with_default` requires Rust 1.40 due to suggest `mem::take`. - [x] `map_unwrap_or` requires Rust 1.41 due to suggest `Result::{map_or, map_or_else}`. - [x] `missing_const_for_fn` requires Rust 1.46 due to `match/if/loop in const fn` needs that version. changelog: Add MSRV config to more lints. ^This is now the complete list, AFAWK
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Dec 20, 2020
add more lints to msrv docs Fixes rust-lang#6097 changelog: None
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
selfhas type&@Rand, so*selfwill be of type@Randwhich causesthis same impl to be called again.
Fixes #6061