Skip to content

Conversation

estebank
Copy link
Contributor

@estebank estebank commented May 20, 2019

Addresses #60976, leaving open to come up with a repro case.

@rust-highfive
Copy link
Contributor

r? @petrochenkov

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 20, 2019
@Centril
Copy link
Contributor

Centril commented May 20, 2019

No regression test?

@estebank
Copy link
Contributor Author

@Centril the repro case is a whole repo (linked in #60976). I can confirm that this PR makes the code compile, but would rather somebody familiar with this part of the codebase to check that the new behavior is valid.

@Centril
Copy link
Contributor

Centril commented May 20, 2019

Sure; it would be good to minimize it if possible tho... :)

@estebank
Copy link
Contributor Author

cc @rust-lang/compiler for visibility

@petrochenkov
Copy link
Contributor

r=me, the fix looks correct, but a test with minimized reproduction would be nice

@petrochenkov petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 20, 2019
@estebank
Copy link
Contributor Author

I won't be having the time to make a repro case. I will merge this PR and leave the report open with E-needstest. (Feel free to r- if you disagree)

@estebank
Copy link
Contributor Author

@bors r=petrochenkov rollup

@bors
Copy link
Collaborator

bors commented May 21, 2019

📌 Commit d320c7c has been approved by petrochenkov

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 21, 2019
Centril added a commit to Centril/rust that referenced this pull request May 21, 2019
Do not fail on child without DefId

Addresses rust-lang#60976, leaving open to come up with a repro case.
Centril added a commit to Centril/rust that referenced this pull request May 21, 2019
Do not fail on child without DefId

Addresses rust-lang#60976, leaving open to come up with a repro case.
Centril added a commit to Centril/rust that referenced this pull request May 22, 2019
Do not fail on child without DefId

Addresses rust-lang#60976, leaving open to come up with a repro case.
Centril added a commit to Centril/rust that referenced this pull request May 22, 2019
Do not fail on child without DefId

Addresses rust-lang#60976, leaving open to come up with a repro case.
bors added a commit that referenced this pull request May 22, 2019
Rollup of 10 pull requests

Successful merges:

 - #59742 (Move `edition` outside the hygiene lock and avoid accessing it)
 - #60581 (convert custom try macro to `?`)
 - #60963 (Update boxed::Box docs on memory layout)
 - #60973 (Avoid symbol interning in `file_metadata`.)
 - #60982 (Do not fail on child without DefId)
 - #60991 (LocalDecl push returns Local len)
 - #60995 (Add stream_to_parser_with_base_dir)
 - #60998 (static_assert: make use of anonymous constants)
 - #61003 (Remove impls for `InternedString`/string equality.)
 - #61006 (adjust deprecation date of mem::uninitialized)

Failed merges:

r? @ghost
@bors bors merged commit d320c7c into rust-lang:master May 22, 2019
@estebank estebank deleted the fix-60976 branch November 9, 2023 05:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants