Box::into_unique: do the reborrow-to-raw *after* destroying the Box #61086
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we first "reborrow" the box to a raw pointer, and then
forget
it. When tracking raw pointers more strictly (something I am experimenting with locally in Miri), the "use" induced by passing the box toforget
invalidates the previously created raw pointer.So adjust my hack from #58429 to reorder the two operations.