Make eval_place iterate instead of recurse #61120

spastorino · 2019-05-24T13:39:20Z

src/librustc_mir/interpret/place.rs

rust-highfive · 2019-05-24T14:22:23Z

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

travis_time:end:00026717:start=1558707159094155353,finish=1558707246343217678,duration=87249062325
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
$ export GCP_CACHE_BUCKET=rust-lang-ci-cache
$ export AWS_ACCESS_KEY_ID=AKIA46X5W6CZEJZ6XT55
---

[00:04:32] travis_fold:start:tidy
travis_time:start:tidy
tidy check
[00:04:33] tidy error: /checkout/src/librustc_mir/interpret/place.rs:624: line longer than 100 chars
[00:04:38] some tidy checks failed
[00:04:38] 
[00:04:38] 
[00:04:38] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/tidy" "/checkout/src" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "--no-vendor" "--quiet"
[00:04:38] 
[00:04:38] 
[00:04:38] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test src/tools/tidy
[00:04:38] Build completed unsuccessfully in 0:01:13
[00:04:38] Build completed unsuccessfully in 0:01:13
[00:04:38] make: *** [tidy] Error 1
[00:04:38] Makefile:67: recipe for target 'tidy' failed
The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:0c4dae90
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
Fri May 24 14:18:53 UTC 2019
---
travis_time:end:38c34e04:start=1558707533990104407,finish=1558707533995545510,duration=5441103
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:1f186c2a
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:17927987
travis_time:start:17927987
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:00598578
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

oli-obk · 2019-05-24T16:08:15Z

@bors r+ rollup

bors · 2019-05-24T16:08:16Z

📌 Commit e7c2777 has been approved by oli-obk

rust-highfive · 2019-05-24T16:51:29Z

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

travis_time:end:14068470:start=1558715660373316718,finish=1558715748610816675,duration=88237499957
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
$ export GCP_CACHE_BUCKET=rust-lang-ci-cache
$ export AWS_ACCESS_KEY_ID=AKIA46X5W6CZEJZ6XT55
---

[00:04:27] travis_fold:start:tidy
travis_time:start:tidy
tidy check
[00:04:27] tidy error: /checkout/src/librustc_mir/interpret/place.rs:624: line longer than 100 chars
[00:04:32] some tidy checks failed
[00:04:32] 
[00:04:32] 
[00:04:32] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/tidy" "/checkout/src" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "--no-vendor" "--quiet"
[00:04:32] 
[00:04:32] 
[00:04:32] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test src/tools/tidy
[00:04:32] Build completed unsuccessfully in 0:01:17
[00:04:32] Build completed unsuccessfully in 0:01:17
[00:04:32] make: *** [tidy] Error 1
[00:04:32] Makefile:67: recipe for target 'tidy' failed
The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:0bf31258
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
Fri May 24 16:40:30 UTC 2019
---
travis_time:end:174628f7:start=1558716031395859265,finish=1558716031401883188,duration=6023923
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:2620c3dc
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:1e04b1e0
travis_time:start:1e04b1e0
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:0ca7d101
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@oli-obk

…i-obk Make eval_place iterate instead of recurse r? @oli-obk

oli-obk · 2019-05-24T17:27:43Z

@bors r-

oli-obk · 2019-05-24T17:28:56Z

@spastorino you have a tidy failure.

you can run tidy with ./x.py test src/tools/tidy

oli-obk · 2019-05-24T17:53:25Z

@bors r+ rollup

bors · 2019-05-24T17:53:26Z

📌 Commit cf9ebe4 has been approved by oli-obk

@oli-obk

…i-obk Make eval_place iterate instead of recurse r? @oli-obk

rust-highfive · 2019-05-24T19:07:35Z

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

travis_time:end:06ca2c10:start=1558720379219979646,finish=1558720470150987339,duration=90931007693
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
$ export GCP_CACHE_BUCKET=rust-lang-ci-cache
$ export AWS_ACCESS_KEY_ID=AKIA46X5W6CZEJZ6XT55
---
[01:09:38] ................................................................................................i... 500/5578
[01:09:42] .................................................................................................... 600/5578
[01:09:46] .................................................................................................... 700/5578
[01:09:50] .................................................................................................... 800/5578
[01:09:56] ...............................................................F.............i...............i...... 900/5578
[01:10:03] ..........iiiii..................................................................................... 1100/5578
[01:10:06] .................................................................................................... 1200/5578
[01:10:08] .................................................................................................... 1300/5578
[01:10:11] .................................................................................................... 1400/5578
---
[01:12:51] failures:
[01:12:51] 
[01:12:51] ---- [ui] ui/consts/static_mut_containing_mut_ref3.rs stdout ----
[01:12:51] 
[01:12:51] error: Error: expected failure status (Some(1)) but received status Some(101).
[01:12:51] status: exit code: 101
[01:12:51] command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/consts/static_mut_containing_mut_ref3.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/consts/static_mut_containing_mut_ref3" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/consts/static_mut_containing_mut_ref3/auxiliary" "-A" "unused"
[01:12:51] ------------------------------------------
[01:12:51] 
[01:12:51] ------------------------------------------
[01:12:51] stderr:
[01:12:51] stderr:
[01:12:51] ------------------------------------------
[01:12:51] error: internal compiler error: src/librustc_mir/interpret/place.rs:604: eval_place_to_mplace called on ((FOO: (u8, u8)).0: u8)
[01:12:51] thread 'rustc' panicked at 'Box<Any>', src/librustc_errors/lib.rs:637:9
[01:12:51] note: Run with `RUST_BACKTRACE=1` environment variable to display a backtrace.
[01:12:51] error: aborting due to previous error
[01:12:51] 
[01:12:51] 
[01:12:51] 
[01:12:51] note: the compiler unexpectedly panicked. this is a bug.
[01:12:51] 
[01:12:51] note: we would appreciate a bug report: https://github.com/rust-lang/rust/blob/master/CONTRIBUTING.md#bug-reports
[01:12:51] 
[01:12:51] note: rustc 1.36.0-dev running on x86_64-unknown-linux-gnu
[01:12:51] 
[01:12:51] note: compiler flags: -Z threads=1 -Z ui-testing -Z unstable-options -C prefer-dynamic -C rpath -C debuginfo=0
[01:12:51] 
[01:12:51] ------------------------------------------
[01:12:51] 
[01:12:51] 
---
[01:12:51] thread 'main' panicked at 'Some tests failed', src/tools/compiletest/src/main.rs:521:22
[01:12:51] note: Run with `RUST_BACKTRACE=1` environment variable to display a backtrace.
[01:12:51] 
[01:12:51] 
[01:12:51] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/ui" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "ui" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-6.0/bin/FileCheck" "--host-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--target-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--quiet" "--llvm-version" "6.0.0\n" "--system-llvm" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--llvm-cxxflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
[01:12:51] 
[01:12:51] 
[01:12:51] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
[01:12:51] Build completed unsuccessfully in 0:04:46
[01:12:51] Build completed unsuccessfully in 0:04:46
[01:12:51] make: *** [check] Error 1
[01:12:51] Makefile:48: recipe for target 'check' failed
The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:15882f9e
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
Fri May 24 19:07:30 UTC 2019

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

spastorino · 2019-05-24T19:46:01Z

@bors r-

bors · 2019-05-24T19:46:02Z

@spastorino: 🔑 Insufficient privileges: Not in reviewers

spastorino · 2019-05-24T20:05:00Z

I think that shouldn't require any special rights, I'm trying to r- a failing PR that I've created /cc @rust-lang/infra. Maybe we can improve this?.

oli-obk · 2019-05-24T20:23:44Z

@bors r- retry

src/librustc_mir/interpret/place.rs

rust-highfive · 2019-05-24T21:54:13Z

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

travis_time:end:3117fd20:start=1558733688206406608,finish=1558733776400721496,duration=88194314888
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
$ export GCP_CACHE_BUCKET=rust-lang-ci-cache
$ export AWS_ACCESS_KEY_ID=AKIA46X5W6CZEJZ6XT55
---
    99% |████████████████████████████████| 542kB 46.3MB/s eta 0:00:01
    100% |████████████████████████████████| 552kB 22.2MB/s 
Requirement already satisfied: PyYAML<=3.13,>=3.10 in /usr/lib/python2.7/dist-packages (from awscli) (3.11)
Collecting botocore==1.12.156 (from awscli)
  Downloading https://files.pythonhosted.org/packages/f5/aa/79fc47ccc3c7d0f36aafb9d85091d7d8a8f10d8ad24ccf3a89cf126b9f4e/botocore-1.12.156-py2.py3-none-any.whl (5.4MB)
    0% |▏                               | 20kB 26.5MB/s eta 0:00:01
    0% |▏                               | 30kB 30.4MB/s eta 0:00:01
    0% |▎                               | 40kB 32.4MB/s eta 0:00:01
    0% |▎                               | 51kB 35.6MB/s eta 0:00:01
---
[00:14:43]    Compiling rustc_typeck v0.0.0 (/checkout/src/librustc_typeck)
[00:14:57] error[E0308]: mismatched types
[00:14:57]    --> src/librustc_mir/interpret/place.rs:636:78
[00:14:57]     |
[00:14:57] 636 |                 PlaceBase::Static(place_static) => self.eval_place_to_mplace(place_static)?.into(),
[00:14:57]     |
[00:14:57]     = note: expected type `&rustc::mir::Place<'_>`
[00:14:57]     = note: expected type `&rustc::mir::Place<'_>`
[00:14:57]                found type `&std::boxed::Box<rustc::mir::Static<'_>>`
[00:15:00] error: aborting due to previous error
[00:15:00] 
[00:15:00] For more information about this error, try `rustc --explain E0308`.
[00:15:00] error: Could not compile `rustc_mir`.
---
travis_time:end:0e6d5203:start=1558734849400642168,finish=1558734849405298164,duration=4655996
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:10b20adb
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:00d8f606
travis_time:start:00d8f606
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:01d07e1f
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

spastorino · 2019-05-24T22:13:36Z

When #61104 is merged this is going to be ready to be merged.

src/librustc_mir/interpret/place.rs

bors · 2019-05-25T12:32:27Z

☔ The latest upstream changes (presumably #61151) made this pull request unmergeable. Please resolve the merge conflicts.

oli-obk · 2019-05-26T07:24:37Z

@bors r+

bors · 2019-05-26T07:24:38Z

📌 Commit e8beea7 has been approved by oli-obk

bors · 2019-05-26T07:29:35Z

💡 This pull request was already approved, no need to approve it again.

There's another pull request that is currently being tested, blocking this pull request: Rollup of 9 pull requests #61201

bors · 2019-05-26T07:29:36Z

📌 Commit e8beea7 has been approved by oli-obk

bors · 2019-05-26T07:29:46Z

💡 This pull request was already approved, no need to approve it again.

There's another pull request that is currently being tested, blocking this pull request: Rollup of 9 pull requests #61201

bors · 2019-05-26T07:29:47Z

📌 Commit e8beea7 has been approved by oli-obk

@oli-obk

…i-obk Make eval_place iterate instead of recurse r? @oli-obk

@ghost

Rollup of 4 pull requests Successful merges: - #61077 (Don't arena-allocate static symbols.) - #61102 (Move path for iterate) - #61120 (Make eval_place iterate instead of recurse) - #61205 (docs: fix typo #61197) Failed merges: r? @ghost

rust-highfive assigned oli-obk May 24, 2019

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 24, 2019

oli-obk requested changes May 24, 2019

View reviewed changes

src/librustc_mir/interpret/place.rs Outdated Show resolved Hide resolved

src/librustc_mir/interpret/place.rs Outdated Show resolved Hide resolved

src/librustc_mir/interpret/place.rs Outdated Show resolved Hide resolved

oli-obk reviewed May 24, 2019

View reviewed changes

src/librustc_mir/interpret/place.rs Outdated Show resolved Hide resolved

spastorino force-pushed the eval-place-iterate branch from 98fd4b0 to e7c2777 Compare May 24, 2019 15:58

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 24, 2019

Centril added a commit to Centril/rust that referenced this pull request May 24, 2019

Rollup merge of rust-lang#61120 - spastorino:eval-place-iterate, r=ol…

cdfacbd

…i-obk Make eval_place iterate instead of recurse r? @oli-obk

Centril mentioned this pull request May 24, 2019

Rollup of 13 pull requests #61127

Closed

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 24, 2019

spastorino force-pushed the eval-place-iterate branch from e7c2777 to cf9ebe4 Compare May 24, 2019 17:49

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 24, 2019

Centril added a commit to Centril/rust that referenced this pull request May 24, 2019

Rollup merge of rust-lang#61120 - spastorino:eval-place-iterate, r=ol…

d214743

…i-obk Make eval_place iterate instead of recurse r? @oli-obk

Centril mentioned this pull request May 24, 2019

Rollup of 16 pull requests #61131

Closed

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 24, 2019

oli-obk reviewed May 24, 2019

View reviewed changes

src/librustc_mir/interpret/place.rs Outdated Show resolved Hide resolved

spastorino force-pushed the eval-place-iterate branch from cf9ebe4 to 807b1e4 Compare May 24, 2019 21:31

RalfJung reviewed May 25, 2019

View reviewed changes

src/librustc_mir/interpret/place.rs Outdated Show resolved Hide resolved

spastorino force-pushed the eval-place-iterate branch from 807b1e4 to 3ba8c8d Compare May 25, 2019 13:30

Make eval_place iterate instead of recurse

e8beea7

spastorino force-pushed the eval-place-iterate branch from 3ba8c8d to e8beea7 Compare May 25, 2019 21:45

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 26, 2019

Centril added a commit to Centril/rust that referenced this pull request May 26, 2019

Rollup merge of rust-lang#61120 - spastorino:eval-place-iterate, r=ol…

c3e1f99

…i-obk Make eval_place iterate instead of recurse r? @oli-obk

Centril mentioned this pull request May 26, 2019

Rollup of 4 pull requests #61210

Merged

bors merged commit e8beea7 into rust-lang:master May 26, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Make eval_place iterate instead of recurse #61120

Make eval_place iterate instead of recurse #61120

spastorino commented May 24, 2019

rust-highfive commented May 24, 2019

oli-obk commented May 24, 2019

bors commented May 24, 2019

rust-highfive commented May 24, 2019

oli-obk commented May 24, 2019

oli-obk commented May 24, 2019

oli-obk commented May 24, 2019

bors commented May 24, 2019

rust-highfive commented May 24, 2019

spastorino commented May 24, 2019

bors commented May 24, 2019

spastorino commented May 24, 2019

oli-obk commented May 24, 2019

rust-highfive commented May 24, 2019

spastorino commented May 24, 2019

bors commented May 25, 2019

oli-obk commented May 26, 2019

bors commented May 26, 2019

bors commented May 26, 2019

bors commented May 26, 2019

bors commented May 26, 2019

bors commented May 26, 2019

Make eval_place iterate instead of recurse #61120

Make eval_place iterate instead of recurse #61120

Conversation

spastorino commented May 24, 2019

rust-highfive commented May 24, 2019

oli-obk commented May 24, 2019

bors commented May 24, 2019

rust-highfive commented May 24, 2019

oli-obk commented May 24, 2019

oli-obk commented May 24, 2019

oli-obk commented May 24, 2019

bors commented May 24, 2019

rust-highfive commented May 24, 2019

spastorino commented May 24, 2019

bors commented May 24, 2019

spastorino commented May 24, 2019

oli-obk commented May 24, 2019

rust-highfive commented May 24, 2019

spastorino commented May 24, 2019

bors commented May 25, 2019

oli-obk commented May 26, 2019

bors commented May 26, 2019

bors commented May 26, 2019

bors commented May 26, 2019

bors commented May 26, 2019

bors commented May 26, 2019