Make cannot move errors more consistent with other borrowck errors #61136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
|
☔ The latest upstream changes (presumably #61150) made this pull request unmergeable. Please resolve the merge conflicts. |
|
@bors r+ |
|
📌 Commit f7808215211a5a0e2102ea9cf1e299850650c147 has been approved by |
bors
added
S-waiting-on-bors
|
or rather, r=me once conflicts are resolved. |
pnkfelix
added
S-waiting-on-author
* Show the place and type being moved * Give a special error for variables in match guard * Simplify search for overloaded deref * Search for overloaded index
matthewjasper
force-pushed
the
cannot-move-errors
branch
from
f780821
to
8ffa408
Compare
|
@bors r=pnkfelix |
|
📌 Commit 8ffa408 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Jun 4, 2019
Make cannot move errors more consistent with other borrowck errors * Note the type of the place being moved in all cases. * Note the place being moved from. * Simplify the search for overloaded place operators * Extend the note for move from overloaded deref apply to all types. * Add a note for moves from overloaded index. * Special case moves for closure captures. r? @pnkfelix
|
☀️ Test successful - checks-travis, status-appveyor |
rust-highfive
added a commit
to rust-lang-nursery/rust-toolstate
that referenced
this pull request
Jun 4, 2019
Tested on commit rust-lang/rust@021a503. Direct link to PR: <rust-lang/rust#61136> 💔 rls on windows: test-pass → test-fail (cc @Xanewok, @rust-lang/infra).
This was referenced Jun 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @pnkfelix