SliceConcatExt::connect defaults to calling join #61146
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @Kimundi (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
|
r? @sfackler |
|
No one externally should be implementing this trait - what's the value in making this change? |
Centril
added
S-waiting-on-author
|
It reduces code duplication. And it won't be a breaking change. |
Centril
added
S-waiting-on-review
|
We also have precedence of when |
|
@bors r+ rollup |
|
📌 Commit 3dd114e has been approved by |
bors
added
S-waiting-on-bors
|
⌛ Testing commit 3dd114e with merge 79c337b8cde437ca1c625ba96661be100806eb1e... |
|
💔 Test failed - status-appveyor |
bors
added
S-waiting-on-review
pietroalbini
added a commit
to pietroalbini/rust
that referenced
this pull request
Jun 21, 2019
…ault-to-join, r=sfackler SliceConcatExt::connect defaults to calling join It makes sense to default a deprecated method to the new one. Precedence example is `Error::cause` defaults to calling `Error::source`.
Centril
added a commit
to Centril/rust
that referenced
this pull request
Jun 21, 2019
…ault-to-join, r=sfackler SliceConcatExt::connect defaults to calling join It makes sense to default a deprecated method to the new one. Precedence example is `Error::cause` defaults to calling `Error::source`.
|
@bors r- |
bors
added
S-waiting-on-author
|
What's wrong? |
|
Oh, that was a spurious failure, sorry! Had to explicitly unapprove failed PRs a few hours ago due to a bors bug, but I didn't look too closely if they were caused by spurious failures. @bors r=sfackler |
|
📌 Commit 3dd114e has been approved by |
bors
added
S-waiting-on-bors
Centril
added a commit
to Centril/rust
that referenced
this pull request
Jun 21, 2019
…ault-to-join, r=sfackler SliceConcatExt::connect defaults to calling join It makes sense to default a deprecated method to the new one. Precedence example is `Error::cause` defaults to calling `Error::source`.
bors
added a commit
that referenced
this pull request
Jun 22, 2019
Rollup of 9 pull requests Successful merges: - #60971 (Add DocFS layer to rustdoc) - #61146 (SliceConcatExt::connect defaults to calling join) - #61181 (Fix theme-checker failure) - #61267 (rustc-book: Update the rustc/clang compatibility table for xLTO.) - #61270 (Remove warnings about incr. comp. generating less debugging output.) - #61681 (Changed the error message to more clearly explain what is allowed) - #61984 (More NodeId pruning) - #62016 (Add test for issue-27697) - #62019 (Remove needless lifetimes) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It makes sense to default a deprecated method to the new one. Precedence example is
Error::causedefaults to callingError::source.