-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Turn turbo 🐟 🍨 into an error #61189
Merged
Merged
Turn turbo 🐟 🍨 into an error #61189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
label
May 25, 2019
r=me when Travis passes. |
@bors r=varkor |
📌 Commit a15df94 has been approved by |
bors
added
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
May 25, 2019
Centril
added a commit
to Centril/rust
that referenced
this pull request
May 26, 2019
Turn turbo 🐟 🍨 into an error Master branch part of rust-lang#60989 r? @varkor
bors
added a commit
that referenced
this pull request
May 26, 2019
Rollup of 9 pull requests Successful merges: - #61087 (Tweak `self` arg not as first argument of a method diagnostic) - #61114 (Vec: avoid creating slices to the elements) - #61144 (Suggest borrowing for loop head on move error) - #61149 (Fix spelling in release notes) - #61161 (MaybeUninit doctest: remove unnecessary type ascription) - #61173 (Auto-derive Encode and Decode implementations of DefPathTable) - #61184 (Add additional trace statements to the const propagator) - #61189 (Turn turbo 🐟 🍨 into an error) - #61193 (Add comment to explain why we change the layout for Projection) Failed merges: r? @ghost
oli-obk
added
the
beta-nominated
Nominated for backporting to the compiler in the beta channel.
label
May 26, 2019
oli-obk
added
the
stable-nominated
Nominated for backporting to the compiler in the stable channel.
label
May 26, 2019
Nominating for stable backport. The backport already exists in #61208 (since this PR does not apply cleanly to stable) |
pietroalbini
added
the
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
label
May 26, 2019
discussed in T-compiler meeting. accepted for backport to beta and stable channels. |
pnkfelix
added
beta-accepted
Accepted for backporting to the compiler in the beta channel.
stable-accepted
Accepted for backporting to the compiler in the stable channel.
labels
Jun 6, 2019
pietroalbini
removed
the
beta-nominated
Nominated for backporting to the compiler in the beta channel.
label
Jun 6, 2019
bors
added a commit
that referenced
this pull request
Jun 6, 2019
[beta] Rollup backports Rolled up: * [beta] Permit unwinding through FFI by default #61569 Cherry-picked: * upgrade rustdoc's `pulldown-cmark` to 0.5.2 #60802 * Fix overflowing literal lint in loops #61098 * Revert edition-guide toolstate override #61110 * Turn turbo 🐟 🍨 into an error #61189 * Bump hashbrown to 0.4.0 #61388 * Fix regression 61475 #61500 r? @ghost
bors
added a commit
that referenced
this pull request
Jun 7, 2019
[beta] Rollup backports Rolled up: * [beta] Permit unwinding through FFI by default #61569 Cherry-picked: * upgrade rustdoc's `pulldown-cmark` to 0.5.2 #60802 * Fix overflowing literal lint in loops #61098 * Revert edition-guide toolstate override #61110 * Turn turbo 🐟 🍨 into an error #61189 * Bump hashbrown to 0.4.0 #61388 * Fix regression 61475 #61500 r? @ghost
Discussed on T-release meeting; declining point release for now based on sum-total of stable-accepted. |
Mark-Simulacrum
removed
stable-nominated
Nominated for backporting to the compiler in the stable channel.
stable-accepted
Accepted for backporting to the compiler in the stable channel.
labels
Jul 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
beta-accepted
Accepted for backporting to the compiler in the beta channel.
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Master branch part of #60989
r? @varkor