-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 9 pull requests #61303
Rollup of 9 pull requests #61303
Commits on Mar 6, 2019
-
Implement
iter::Sum
anditer::Product
forOption
This is similar to the existing implementation for `Result`. It will take each item into the accumulator unless a `None` is returned.
Configuration menu - View commit details
-
Copy full SHA for a35cdd4 - Browse repository at this point
Copy the full SHA a35cdd4View commit details
Commits on Mar 19, 2019
-
Update stable attribute to be since 1.35.0
Co-Authored-By: jtdowney <jdowney@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 8c69876 - Browse repository at this point
Copy the full SHA 8c69876View commit details
Commits on Mar 21, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 422a4c0 - Browse repository at this point
Copy the full SHA 422a4c0View commit details
Commits on May 4, 2019
-
Signed-off-by: wizAmit <amitforfriends_dns@yahoo.com>
Configuration menu - View commit details
-
Copy full SHA for 4d9b9e9 - Browse repository at this point
Copy the full SHA 4d9b9e9View commit details -
hopefully working nth_back on chunks
Signed-off-by: wizAmit <amitforfriends_dns@yahoo.com>
Configuration menu - View commit details
-
Copy full SHA for 73ca8bc - Browse repository at this point
Copy the full SHA 73ca8bcView commit details
Commits on May 5, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 5eb0e08 - Browse repository at this point
Copy the full SHA 5eb0e08View commit details
Commits on May 14, 2019
-
Signed-off-by: wizAmit <amitforfriends_dns@yahoo.com>
Configuration menu - View commit details
-
Copy full SHA for 02a148d - Browse repository at this point
Copy the full SHA 02a148dView commit details -
hopefully working nth_back on chunks
Signed-off-by: wizAmit <amitforfriends_dns@yahoo.com>
Configuration menu - View commit details
-
Copy full SHA for aff83c8 - Browse repository at this point
Copy the full SHA aff83c8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 16223e4 - Browse repository at this point
Copy the full SHA 16223e4View commit details -
Configuration menu - View commit details
-
Copy full SHA for fd15405 - Browse repository at this point
Copy the full SHA fd15405View commit details
Commits on May 22, 2019
-
Signed-off-by: wizAmit <amitforfriends_dns@yahoo.com>
Configuration menu - View commit details
-
Copy full SHA for dc82626 - Browse repository at this point
Copy the full SHA dc82626View commit details -
hopefully working nth_back on chunks
Signed-off-by: wizAmit <amitforfriends_dns@yahoo.com>
Configuration menu - View commit details
-
Copy full SHA for 2080b86 - Browse repository at this point
Copy the full SHA 2080b86View commit details -
Signed-off-by: wizAmit <amitforfriends_dns@yahoo.com>
Configuration menu - View commit details
-
Copy full SHA for 29a103d - Browse repository at this point
Copy the full SHA 29a103dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9309447 - Browse repository at this point
Copy the full SHA 9309447View commit details -
Configuration menu - View commit details
-
Copy full SHA for bcfd1f3 - Browse repository at this point
Copy the full SHA bcfd1f3View commit details
Commits on May 25, 2019
-
Configuration menu - View commit details
-
Copy full SHA for f1d0829 - Browse repository at this point
Copy the full SHA f1d0829View commit details
Commits on May 26, 2019
-
sync::Weak::{as,from,into}_raw
Methods on the Weak to access it as raw pointer to the data.
Configuration menu - View commit details
-
Copy full SHA for f9d328d - Browse repository at this point
Copy the full SHA f9d328dView commit details -
Methods on the Weak to access it as a raw pointer to the data.
Configuration menu - View commit details
-
Copy full SHA for 4f1dcb3 - Browse repository at this point
Copy the full SHA 4f1dcb3View commit details
Commits on May 28, 2019
-
librustc_errors: Move annotation collection to own impl
Extracted from work on rust-lang#59346. This moves the annotation collection to the `FileWithAnnotatedLines` impl to allow re-use in a separate EmitterWriter.
Configuration menu - View commit details
-
Copy full SHA for 96e3fb2 - Browse repository at this point
Copy the full SHA 96e3fb2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0631d19 - Browse repository at this point
Copy the full SHA 0631d19View commit details -
Configuration menu - View commit details
-
Copy full SHA for 120ce12 - Browse repository at this point
Copy the full SHA 120ce12View commit details -
Configuration menu - View commit details
-
Copy full SHA for 03d3290 - Browse repository at this point
Copy the full SHA 03d3290View commit details -
Configuration menu - View commit details
-
Copy full SHA for 29b7c06 - Browse repository at this point
Copy the full SHA 29b7c06View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7fa97c0 - Browse repository at this point
Copy the full SHA 7fa97c0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9f8d934 - Browse repository at this point
Copy the full SHA 9f8d934View commit details
Commits on May 29, 2019
-
Rollup merge of rust-lang#58975 - jtdowney:iter_arith_traits_option, …
…r=dtolnay Implement `iter::Sum` and `iter::Product` for `Option` This is similar to the existing implementation for `Result`. It will take each item into the accumulator unless a `None` is returned. I based a lot of this on rust-lang#38580. From that discussion it didn't seem like this addition would be too controversial or difficult. One thing I still don't understand is picking the values for the `stable` attribute. This is my first non-documentation PR for rust so I am open to any feedback on improvements.
Configuration menu - View commit details
-
Copy full SHA for 8e3f003 - Browse repository at this point
Copy the full SHA 8e3f003View commit details -
Rollup merge of rust-lang#60542 - timvermeulen:step_sub_usize, r=scot…
…tmcm Add Step::sub_usize Required for rust-lang#54054. I'm aware that the `Step` trait needs a rework, but this still seems like a reasonable addition? This currently doesn't compile because Chalk contains a type that implement this trait, and this is a breaking change. How can that be fixed?
Configuration menu - View commit details
-
Copy full SHA for 85c975b - Browse repository at this point
Copy the full SHA 85c975bView commit details -
Rollup merge of rust-lang#60555 - timvermeulen:rchunks_nth_back, r=sc…
…ottmcm Implement nth_back for RChunks(Exact)(Mut) Part of rust-lang#54054. These implementations may not be optimal because of the use of `self.len()`, but it's quite cheap and simplifies the code a lot. There's quite some duplication going on here, I wouldn't mind cleaning this up later. A good next step would probably be to add private `split_off_up_to`/`split_off_from` helper methods for slices since their behavior is commonly useful throughout the `Chunks` types. r? @scottmcm
Configuration menu - View commit details
-
Copy full SHA for 966e354 - Browse repository at this point
Copy the full SHA 966e354View commit details -
Rollup merge of rust-lang#60766 - vorner:weak-into-raw, r=sfackler
Weak::into_raw Hello This is my first shot at rust-lang#60728. I'd like to consult it a bit before moving further. The biggest question I have is if this API makes sense. My motivation for it is to be able to store the `Weak` in `AtomicPtr`. For that I don't actually need for the pointer to point to the `T`, any pointer (maybe casted to `usize`) would be good enough, but this mirrors what `Arc` does and could be useful for other things too (like comparing if Arc and Weak point to the same thing without playing with the counts), while some opaque pointer wouldn't. Some secondary questions, if this is deemed desirable are: * The weak pointer may be dangling if it is created by `Weak::new()`. It would make sense to treat this as NULL, but that is incompatible with `T: ?Sized` ‒ both `new()` and `ptr::null()` are available only for sized types. The current implementation is therefore also available only for sized `T`s. It would be possible to allow `?Sized` if the API would be `fn into_raw(self) -> Option<NonNull<T>>` and `fn from_raw(NonNull<T>)`, but that's different API than `Arc` has. What would be preferred? * There's a FIXME in my code about what I suspect could be UB. Is it really UB & how to get the pointer correctly? Is manual offsetting of the pointer the only way? * Am I missing some other necessary thing around the feature gates and such? * Is the documentation understandable? I know writing docs is not my strongest skill :-|. Thinks I'd like to do as part of the PR, but are not yet done: * Turn the referenced issue into tracking issue for the feature flag. * Once the `sync::Weak` is considered reasonable, I'd do the equivalent for `rc::Weak`. * This might call for few more tests than what is currently part of the documentation.
Configuration menu - View commit details
-
Copy full SHA for c98841b - Browse repository at this point
Copy the full SHA c98841bView commit details -
Rollup merge of rust-lang#61048 - wizAmit:feature/nth_back_chunks, r=…
…scottmcm Feature/nth back chunks A succinct implementation for nth_back on chunks. Thank you @timvermeulen for the guidance. r? @timvermeulen
Configuration menu - View commit details
-
Copy full SHA for aad084a - Browse repository at this point
Copy the full SHA aad084aView commit details -
Rollup merge of rust-lang#61191 - phansch:annotate_snippet_refactorin…
…gs1, r=estebank librustc_errors: Move annotation collection to own impl Extracted from work on rust-lang#59346. This moves the annotation collection to the `FileWithAnnotatedLines` impl to allow easier re-use in a separate EmitterWriter. Even without that new EmitterWriter present, I think it makes sense to have this as an associated function.
Configuration menu - View commit details
-
Copy full SHA for cd38c8f - Browse repository at this point
Copy the full SHA cd38c8fView commit details -
Rollup merge of rust-lang#61291 - spastorino:avoid-unneeded-bug-call,…
… r=estebank Avoid unneeded bug!() call r? @oli-obk
Configuration menu - View commit details
-
Copy full SHA for e0bb093 - Browse repository at this point
Copy the full SHA e0bb093View commit details -
Rollup merge of rust-lang#61294 - eddyb:no-trait-nor-impl, r=varkor
Rename `TraitOrImpl` to `Assoc` and `trait_or_impl` to `assoc`.
Configuration menu - View commit details
-
Copy full SHA for 2af35bf - Browse repository at this point
Copy the full SHA 2af35bfView commit details -
Rollup merge of rust-lang#61297 - eddyb:forsaken-stats, r=nagisa
Remove LLVM instruction stats and other (obsolete) codegen stats. Both `-Z count_llvm_insns` and `-Z codegen-stats` are removed, as (AFAIK) they have been of little use in the last few years, especially after the transition to MIR->LLVM codegen. Other than for the LLVM instruction counts, `-Z codegen-stats` has long been obsoleted anyway. r? @nagisa cc @rust-lang/compiler
Configuration menu - View commit details
-
Copy full SHA for c0142ac - Browse repository at this point
Copy the full SHA c0142acView commit details