Set ellipsis_inclusive_range_patterns lint to warn #61342

memoryruins · 2019-05-30T08:27:19Z

Continuing #54910, the ellipsis_inclusive_range_patterns lint is set to warn.

r? @Centril

src/test/run-pass/binding/pat-ranges.rs

src/test/run-pass/associated-consts/associated-const-range-match-patterns.rs

src/test/run-pass/inc-range-pat.rs

src/test/run-pass/issues/issue-15881-model-lexer-dotdotdot.rs

src/test/ui/lint/issue-54538-unused-parens-lint.rs

Centril · 2019-05-30T09:10:18Z

@rust-lang/lang N.B. This transitions a Rust 2018 idiom lint towards Warn by default instead of Allow. The justification was given by @aturon in #28237 (comment).

I believe @joshtriplett's comment in #61203 (comment) applies here as well:

Note that under normal circumstances, I'd say we need a crater run to assess the impact of even a new warning, as that can cause build failures (deny(warnings)). However, as this was announced and advertised as part of the Rust 2018 edition, I think we can reasonably introduce it as an idiom lint, to be enabled as part of that family of lints.

This is probably less widespread than dyn Trait also, so we should be good.

Centril

Thanks! r=me rollup with green travis.

memoryruins · 2019-05-30T12:09:40Z

@bors r=Centril rollup

bors · 2019-05-30T12:09:41Z

@memoryruins: 🔑 Insufficient privileges: not in try users

bors · 2019-05-30T12:09:43Z

@memoryruins: 🔑 Insufficient privileges: Not in reviewers

memoryruins · 2019-05-30T12:10:01Z

It was worth a shot :)

Centril · 2019-05-30T12:21:39Z

Hehe :)

@bors r+ rollup

bors · 2019-05-30T12:21:40Z

📌 Commit e18885e has been approved by Centril

@Centril

…e_patterns, r=Centril Set ellipsis_inclusive_range_patterns lint to warn Continuing rust-lang#54910, the `ellipsis_inclusive_range_patterns` lint is set to warn. r? @Centril

@Centril

…e_patterns, r=Centril Set ellipsis_inclusive_range_patterns lint to warn Continuing rust-lang#54910, the `ellipsis_inclusive_range_patterns` lint is set to warn. r? @Centril

@Centril

…e_patterns, r=Centril Set ellipsis_inclusive_range_patterns lint to warn Continuing rust-lang#54910, the `ellipsis_inclusive_range_patterns` lint is set to warn. r? @Centril

@ghost

Rollup of 10 pull requests Successful merges: - #60897 (error: remove StringError from Debug output) - #61278 (Miri: give machine the chance to tag all allocations) - #61304 (Speed up Azure CI installing Windows dependencies) - #61342 (Set ellipsis_inclusive_range_patterns lint to warn) - #61344 (Add regression test for const generics ICE) - #61359 (Fix links in Deref documentation) - #61363 (Stabilize iter_nth_back feature) - #61369 (Fixed lifetime misspelling) - #61372 (Migrate some books to mdbook version 0.2) - #61374 (Explicitly suggest 'type_ascription' feature) Failed merges: r? @ghost

@Centril

…e_patterns, r=Centril Set ellipsis_inclusive_range_patterns lint to warn Continuing rust-lang#54910, the `ellipsis_inclusive_range_patterns` lint is set to warn. r? @Centril

@ghost

Rollup of 11 pull requests Successful merges: - #60897 (error: remove StringError from Debug output) - #61304 (Speed up Azure CI installing Windows dependencies) - #61319 (Swap order of `unsafe async fn` to `async unsafe fn`) - #61342 (Set ellipsis_inclusive_range_patterns lint to warn) - #61344 (Add regression test for const generics ICE) - #61359 (Fix links in Deref documentation) - #61363 (Stabilize iter_nth_back feature) - #61369 (Fixed lifetime misspelling) - #61372 (Migrate some books to mdbook version 0.2) - #61374 (Explicitly suggest 'type_ascription' feature) - #61382 (Fixed a typo in core::convert::AsMut) Failed merges: r? @ghost

Changed from `allow` to `warn` in rust-lang/rust#61342

Fix ellipsis_inclusive_range_patterns lint warnings Changed from `allow` to `warn` in rust-lang/rust#61342 changelog: none

Pkgsrc changes: * Add a patch to llvm to deal with const dli_saddr. * Adapt two other patches. * Cross-build currently fails, so i386, powerpc and sparc64 bootstrap kits for 1.37.0 are built natively. Missing aarch64 hardware, so that's not available yet. * Bump bootstrap requirements to 1.36.0 except for armv7-unknown-netbsd-eabihf which I've not managed to cross-build. Upstream changes: Version 1.37.0 (2019-08-15) ========================== Language -------- - `#[must_use]` will now warn if the type is contained in a [tuple][61100], [`Box`][62228], or an [array][62235] and unused. - [You can now use the `cfg` and `cfg_attr` attributes on generic parameters.][61547] - [You can now use enum variants through type alias.][61682] e.g. You can write the following: ```rust type MyOption = Option<u8>; fn increment_or_zero(x: MyOption) -> u8 { match x { MyOption::Some(y) => y + 1, MyOption::None => 0, } } ``` - [You can now use `_` as an identifier for consts.][61347] e.g. You can write `const _: u32 = 5;`. - [You can now use `#[repr(align(X)]` on enums.][61229] - [The `?`/_"Kleene"_ macro operator is now available in the 2015 edition.][60932] Compiler -------- - [You can now enable Profile-Guided Optimization with the `-C profile-generate` and `-C profile-use` flags.][61268] For more information on how to use profile guided optimization, please refer to the [rustc book][rustc-book-pgo]. - [The `rust-lldb` wrapper script should now work again.][61827] Libraries --------- - [`mem::MaybeUninit<T>` is now ABI-compatible with `T`.][61802] Stabilized APIs --------------- - [`BufReader::buffer`] - [`BufWriter::buffer`] - [`Cell::from_mut`] - [`Cell<[T]>::as_slice_of_cells`][`Cell<slice>::as_slice_of_cells`] - [`DoubleEndedIterator::nth_back`] - [`Option::xor`] - [`Wrapping::reverse_bits`] - [`i128::reverse_bits`] - [`i16::reverse_bits`] - [`i32::reverse_bits`] - [`i64::reverse_bits`] - [`i8::reverse_bits`] - [`isize::reverse_bits`] - [`slice::copy_within`] - [`u128::reverse_bits`] - [`u16::reverse_bits`] - [`u32::reverse_bits`] - [`u64::reverse_bits`] - [`u8::reverse_bits`] - [`usize::reverse_bits`] Cargo ----- - [`Cargo.lock` files are now included by default when publishing executable crates with executables.][cargo/7026] - [You can now specify `default-run="foo"` in `[package]` to specify the default executable to use for `cargo run`.][cargo/7056] Misc ---- Compatibility Notes ------------------- - [Using `...` for inclusive range patterns will now warn by default.][61342] Please transition your code to using the `..=` syntax for inclusive ranges instead. - [Using a trait object without the `dyn` will now warn by default.][61203] Please transition your code to use `dyn Trait` for trait objects instead. [62228]: rust-lang/rust#62228 [62235]: rust-lang/rust#62235 [61802]: rust-lang/rust#61802 [61827]: rust-lang/rust#61827 [61547]: rust-lang/rust#61547 [61682]: rust-lang/rust#61682 [61268]: rust-lang/rust#61268 [61342]: rust-lang/rust#61342 [61347]: rust-lang/rust#61347 [61100]: rust-lang/rust#61100 [61203]: rust-lang/rust#61203 [61229]: rust-lang/rust#61229 [60932]: rust-lang/rust#60932 [cargo/7026]: rust-lang/cargo#7026 [cargo/7056]: rust-lang/cargo#7056 [`BufReader::buffer`]: https://doc.rust-lang.org/std/io/struct.BufReader.html#method.buffer [`BufWriter::buffer`]: https://doc.rust-lang.org/std/io/struct.BufWriter.html#method.buffer [`Cell::from_mut`]: https://doc.rust-lang.org/std/cell/struct.Cell.html#method.from_mut [`Cell<slice>::as_slice_of_cells`]: https://doc.rust-lang.org/std/cell/struct.Cell.html#method.as_slice_of_cells [`DoubleEndedIterator::nth_back`]: https://doc.rust-lang.org/std/iter/trait.DoubleEndedIterator.html#method.nth_back [`Option::xor`]: https://doc.rust-lang.org/std/option/enum.Option.html#method.xor [`RefCell::try_borrow_unguarded`]: https://doc.rust-lang.org/std/cell/struct.RefCell.html#method.try_borrow_unguarded [`Wrapping::reverse_bits`]: https://doc.rust-lang.org/std/num/struct.Wrapping.html#method.reverse_bits [`i128::reverse_bits`]: https://doc.rust-lang.org/std/primitive.i128.html#method.reverse_bits [`i16::reverse_bits`]: https://doc.rust-lang.org/std/primitive.i16.html#method.reverse_bits [`i32::reverse_bits`]: https://doc.rust-lang.org/std/primitive.i32.html#method.reverse_bits [`i64::reverse_bits`]: https://doc.rust-lang.org/std/primitive.i64.html#method.reverse_bits [`i8::reverse_bits`]: https://doc.rust-lang.org/std/primitive.i8.html#method.reverse_bits [`isize::reverse_bits`]: https://doc.rust-lang.org/std/primitive.isize.html#method.reverse_bits [`slice::copy_within`]: https://doc.rust-lang.org/std/primitive.slice.html#method.copy_within [`u128::reverse_bits`]: https://doc.rust-lang.org/std/primitive.u128.html#method.reverse_bits [`u16::reverse_bits`]: https://doc.rust-lang.org/std/primitive.u16.html#method.reverse_bits [`u32::reverse_bits`]: https://doc.rust-lang.org/std/primitive.u32.html#method.reverse_bits [`u64::reverse_bits`]: https://doc.rust-lang.org/std/primitive.u64.html#method.reverse_bits [`u8::reverse_bits`]: https://doc.rust-lang.org/std/primitive.u8.html#method.reverse_bits [`usize::reverse_bits`]: https://doc.rust-lang.org/std/primitive.usize.html#method.reverse_bits [rustc-book-pgo]: https://doc.rust-lang.org/rustc/profile-guided-optimization.html

Set ellipsis_inclusive_range_patterns lint to warn

bf0da6c

rust-highfive assigned Centril May 30, 2019

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 30, 2019

Centril added relnotes Marks issues that should be documented in the release notes of the next release. T-lang Relevant to the language team labels May 30, 2019

Centril added this to the 1.37 milestone May 30, 2019

Centril suggested changes May 30, 2019

View reviewed changes

memoryruins force-pushed the ellipsis_inclusive_range_patterns branch from a982d59 to e18885e Compare May 30, 2019 10:16

Update ui and run-pass for ellipsis_inclusive_range_patterns lint

e18885e

Centril approved these changes May 30, 2019

View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 30, 2019

Centril mentioned this pull request May 30, 2019

Rollup of 3 pull requests #61354

Closed

Centril mentioned this pull request May 30, 2019

Rollup of 2 pull requests #61355

Closed

memoryruins mentioned this pull request May 30, 2019

Tracking issue for warning for rust_2018_idioms by default #54910

Open

11 tasks

Centril mentioned this pull request May 30, 2019

Rollup of 10 pull requests #61379

Closed

pietroalbini mentioned this pull request May 31, 2019

Rollup of 11 pull requests #61394

Merged

bors merged commit e18885e into rust-lang:master Jun 1, 2019

phansch added a commit to phansch/rust-clippy that referenced this pull request Jun 1, 2019

Fix ellipsis_inclusive_range_patterns lint warnings

6feef17

Changed from `allow` to `warn` in rust-lang/rust#61342

phansch mentioned this pull request Jun 1, 2019

Fix ellipsis_inclusive_range_patterns lint warnings rust-lang/rust-clippy#4158

Merged

bors added a commit to rust-lang/rust-clippy that referenced this pull request Jun 1, 2019

Auto merge of #4158 - phansch:rustup_tests, r=Manishearth

f3087c3

Fix ellipsis_inclusive_range_patterns lint warnings Changed from `allow` to `warn` in rust-lang/rust#61342 changelog: none

kevinmehall mentioned this pull request Jun 4, 2019

Replace deprecated ... range syntax with ..= rust-lang/book#1977

Merged

memoryruins deleted the ellipsis_inclusive_range_patterns branch June 6, 2019 23:50

jebrosen mentioned this pull request Jun 19, 2019

Inclusive range patterns are always output as ..., which is linted against. dtolnay/syn#650

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Set ellipsis_inclusive_range_patterns lint to warn #61342

Set ellipsis_inclusive_range_patterns lint to warn #61342

Uh oh!

memoryruins commented May 30, 2019

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Centril commented May 30, 2019

Uh oh!

Centril left a comment

Uh oh!

memoryruins commented May 30, 2019

Uh oh!

bors commented May 30, 2019

Uh oh!

bors commented May 30, 2019

Uh oh!

memoryruins commented May 30, 2019

Uh oh!

Centril commented May 30, 2019

Uh oh!

bors commented May 30, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Set ellipsis_inclusive_range_patterns lint to warn #61342

Set ellipsis_inclusive_range_patterns lint to warn #61342

Uh oh!

Conversation

memoryruins commented May 30, 2019

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Centril commented May 30, 2019

Uh oh!

Centril left a comment

Choose a reason for hiding this comment

Uh oh!

memoryruins commented May 30, 2019

Uh oh!

bors commented May 30, 2019

Uh oh!

bors commented May 30, 2019

Uh oh!

memoryruins commented May 30, 2019

Uh oh!

Centril commented May 30, 2019

Uh oh!

bors commented May 30, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants